You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-21] [$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment #68722
But if we type any text after the emoji, the emoji size and input height will changes which will trigger the onScroll in this case:
Screen.Recording.2025-08-19.at.16.01.55.mov
But this bug doesn't happen if we do directly into input send message composer which is (ReportActionCompose)
It's because right here we prevent from hiding any suggestions if the onScroll trigger is likely coming from the layout changes
changed the title [-]chat-@ mention suggestions not displayed on new line after emoji in edit comment[/-][+][$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/+]on Aug 21, 2025
@thesahindia , I wasn't able to test on the Android phone at the bank and I'm not back there til Monday so added External. Can you please test, ideally on a physical device, and share details? Assuming you're able to reproduce, please review the above proposals. thx
changed the title [-][$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/-][+][Due for payment 2025-10-21] [$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/+]on Oct 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.30-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@thesahindia@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: It was an edge case missed in the implementation
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Aug 19, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.NJ-2020 commentedon Aug 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat
@mention suggestions are not displayed on new line after emoji in edit commentWhat is the root cause of that problem?
We'll close the mention suggestions here automatically whenever the user scrolls the input
App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Line 508 in d1b5bdd
App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Lines 316 to 323 in d1b5bdd
But if we type any text after the emoji, the emoji size and input height will changes which will trigger the
onScrollin this case:Screen.Recording.2025-08-19.at.16.01.55.mov
But this bug doesn't happen if we do directly into input send message composer which is (ReportActionCompose)
It's because right here we prevent from hiding any suggestions if the
onScrolltrigger is likely coming from the layout changesApp/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
Line 634 in d1b5bdd
App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
Lines 535 to 540 in d1b5bdd
What changes do you think we should make in order to solve the problem?
We should do same way as we do for ReportActionCompose/ComposerWithSuggestions
App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
Lines 157 to 175 in d1b5bdd
App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
Lines 375 to 377 in d1b5bdd
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
[-]chat-@ mention suggestions not displayed on new line after emoji in edit comment[/-][+][$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/+]melvin-bot commentedon Aug 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021958601260731157450
melvin-bot commentedon Aug 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)mallenexpensify commentedon Aug 21, 2025
@thesahindia , I wasn't able to test on the Android phone at the bank and I'm not back there til Monday so added
External. Can you please test, ideally on a physical device, and share details? Assuming you're able to reproduce, please review the above proposals. thxmelvin-bot commentedon Aug 26, 2025
@thesahindia Huh... This is 4 days overdue. Who can take care of this?
52 remaining items
[-][$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/-][+][Due for payment 2025-10-21] [$250] chat-@ mention suggestions not displayed on new line after emoji in edit comment[/+]melvin-bot commentedon Oct 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.30-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 14, 2025
@thesahindia @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mallenexpensify commentedon Oct 22, 2025
Payment Summary
Contributor: @NJ-2020 paid $250 via Upwork
Contributor+: @thesahindia due $250 via NewDot
@NJ-2020 can you please accept the job below? Please reply here and tag me once you have.
@thesahindia plz complete the BZ checklist.
NJ-2020 commentedon Oct 23, 2025
@mallenexpensify Accepted, thanks.
mallenexpensify commentedon Oct 24, 2025
@NJ-2020 paid, summary updated above.
@thesahindia plz complete the BZ checklist.
thesahindia commentedon Oct 25, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: It was an edge case missed in the implementation
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
mallenexpensify commentedon Oct 27, 2025
Test case created, thx!
garrettmknight commentedon May 21, 2026
$250 approved for @thesahindia