You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-27] [$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled #68739
Version Number: V9.1.96-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#68004 Email or phone of affected tester (no customers): Slottwo1 2@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 phone App Component: Money Requests
Action Performed:
Launch app
Go to workspace settings
Go offline
Enable distance rate
Open distance rate
Add a rate
Go to more features - disable and enable the rate
Open distance rate
Note first distance rate is enabled
Turn on internet
Note second rate is enabled
Expected Result:
In offline, after re-enabling distance rate, second distance rate must not be enabled when turn on internet.
Actual Result:
In offline, after re-enabling distance rate, second distance rate also enabled when turn on internet.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
We can call API.write for the enable feature API that changes the policy data
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/-][+][$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/+]on Aug 27, 2025
changed the title [-][$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/-][+][Due for payment 2025-10-27] [$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/+]on Oct 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@parasharrajat@stephanieelliott / @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to workspace settings
Go offline
Enable distance rate
Open distance rate
Add a rate
Go to more features - disable and enable the rate
Open distance rate
Note first distance rate is enabled
Turn on internet
Verify that: In offline, after re-enabling distance rate, second distance rate must not be enabled when turn on internet.
Activity
melvin-bot commentedon Aug 19, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Aug 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In offline, after re-enabling distance rate, second distance rate also enabled when turn on internet.
What is the root cause of that problem?
When we disable and enable the distance rate in offline mode, both APIs are removed from the queue based on
resolveEnableFeatureConflicts.App/src/libs/API/index.ts
Lines 195 to 205 in d1b5bdd
Only the distance rate API is called, which enables the rate.
What changes do you think we should make in order to solve the problem?
We should only remove duplicate enabled feature API for the features that don't change the data, like expenseify card, company card.
const deleteRequestIndex = persistedRequests.findIndex(
(request) => availableRemoveDuplicateEnableFeatureConflicts.includes(command) && request.command === command && request.data?.policyID === parameters.policyID && request.data?.enabled !== parameters.enabled,
);
App/src/libs/actions/RequestConflictUtils.ts
Lines 202 to 206 in d1b5bdd
App/src/libs/API/index.ts
Lines 195 to 205 in d1b5bdd
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
We can call
API.writefor the enable feature API that changes the policy dataReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Aug 22, 2025
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Aug 26, 2025
@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
[-]Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/-][+][$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/+]melvin-bot commentedon Aug 27, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021960500223321046518
melvin-bot commentedon Aug 27, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)33 remaining items
[-][$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/-][+][Due for payment 2025-10-27] [$250] Workspace - In offline, after re-enabling distance rate, second distance rate also enabled[/+]melvin-bot commentedon Oct 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 20, 2025
@parasharrajat @stephanieelliott / @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Oct 27, 2025
Payment Summary
Upwork Job
BugZero Checklist (@stephanieelliott)
parasharrajat commentedon Oct 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57486/files#r2468175378
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
stephanieelliott commentedon Oct 31, 2025
Test case here: https://github.com/Expensify/Expensify/issues/563305
stephanieelliott commentedon Oct 31, 2025
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @parasharrajat due $250 via NewDot
parasharrajat commentedon Nov 9, 2025
Payment requested as per #68739 (comment)
trjExpensify commentedon Nov 17, 2025
approved $250 for @parasharrajat.