You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting checklist completion] [CFI] [$250] Add the "Add expense" button to two areas of the product #68772
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
Add the "Add expense" button to two areas of the product
What is the root cause of that problem?
New feat
What changes do you think we should make in order to solve the problem?
We should add the add expense button in MoneyRequestReportTotalSpend or MoneyRequestReportTransactionList and in TransactionGroupListItem.
We should use isAddExpenseAction(report, transactions ?? [], isReportArchived) for conditionally rendering the button and follow the same approach as in MoneyReportHeader.
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
changed the title [-][Due for payment 2025-10-31] [CFI] [$250] Add the "Add expense" button to two areas of the product[/-][+][Awaiting checklist completion] [CFI] [$250] Add the "Add expense" button to two areas of the product[/+]on Oct 31, 2025
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug. New feat
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Aug 19, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Aug 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add the "Add expense" button to two areas of the product
What is the root cause of that problem?
new feat
What changes do you think we should make in order to solve the problem?
we want to add the Add expense button here
MoneyRequestReportTotalSpendandTransactionGroupListItemlike we did here in
MoneyRequestReportPreviewContentApp/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 569 to 579 in 1ef115b
for
MoneyRequestReportTransactionListwe should add the dropDownButton inMoneyRequestReportTotalSpendthat we display hereApp/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 327 to 334 in 1ef115b
we should add the button in this view
App/src/components/MoneyRequestReportView/MoneyRequestReportTotalSpend.tsx
Line 39 in 1ef115b
like this
ButtonWithDropdownMenuhereApp/src/components/SelectionList/Search/TransactionGroupListItem.tsx
Lines 186 to 193 in 1ef115b
like this
we can use the anchorAlignment in
MoneyRequestReportTotalSpendto display the model in right side to prevent overlapping the LHNWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Transection list result
Transection group list item
Krishna2323 commentedon Aug 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add the "Add expense" button to two areas of the product
What is the root cause of that problem?
New feat
What changes do you think we should make in order to solve the problem?
MoneyRequestReportTotalSpendorMoneyRequestReportTransactionListand inTransactionGroupListItem.isAddExpenseAction(report, transactions ?? [], isReportArchived)for conditionally rendering the button and follow the same approach as inMoneyReportHeader.App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 225 to 239 in 1ef115b
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 327 to 334 in 1ef115b
App/src/components/SelectionList/Search/TransactionGroupListItem.tsx
Lines 186 to 193 in 1ef115b
App/src/components/MoneyReportHeader.tsx
Lines 538 to 569 in 1ef115b
App/src/components/MoneyReportHeader.tsx
Lines 783 to 791 in 1ef115b
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Result
Krishna2323 commentedon Aug 19, 2025
PROPOSAL UPDATED
samranahm commentedon Aug 19, 2025
Proposal updated
twisterdotcom commentedon Aug 20, 2025
I think this is a NewFeature, not a Bug @jamesdeanexpensify
melvin-bot commentedon Aug 20, 2025
Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Aug 20, 2025
99 remaining items
[-][Due for payment 2025-10-31] [CFI] [$250] Add the "Add expense" button to two areas of the product[/-][+][Awaiting checklist completion] [CFI] [$250] Add the "Add expense" button to two areas of the product[/+]brunovjk commentedon Oct 31, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug. New feat
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/564337
Regression Test Proposal
Precondition: Admin creates a workspace and invites 2 members.
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-539a-a814-5448-53a664cbe181brunovjk commentedon Oct 31, 2025
All yours @twisterdotcom. Thank you.
Krishna2323 commentedon Oct 31, 2025
Requested in ND.
twisterdotcom commentedon Nov 3, 2025
Updated payment summary.
JmillsExpensify commentedon Nov 3, 2025
$250 approved for @Krishna2323
brunovjk commentedon Nov 3, 2025
Requested in ND.
m-natarajan commentedon Nov 3, 2025
@brunovjk Add expense button not displayed for empty reports in Reports > Reports. Is this expected or an potential issue?
Recording.1867.mp4
brunovjk commentedon Nov 3, 2025
I believe that's expected. #71267 (comment)
cc: @Krishna2323 @trjExpensify
m-natarajan commentedon Nov 3, 2025
Ok, Noted. Thanks
garrettmknight commentedon Nov 4, 2025
$250 approved for @brunovjk