Skip to content

Expense - Missing composer after simultaneously submit&receive expense offline and return online #68805

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-349/folder/13177075/41237834/849025984
Email or phone of affected tester (no customers): sdjdosinjsdoinjs1@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User A and User B have never chatted before
  1. Go to staging.new.expensify.com
  2. [User A] Go offline
  3. [User A] Submit an expense to User B
  4. [User B] While online, submit an expense to User A
  5. [User A] Go online

Expected Result:

After returning online, 1:1 DM with User B will show the composer

Actual Result:

After returning online, 1:1 DM with User B does not show the composer.
The report is also not highlighted in LHN.
URL shows https://staging.new.expensify.com/r

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6921469_1755640505808.Screen_Recording_2025-08-20_at_05.51.48.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 19, 2025
  2. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Aug 19, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lanitochka17 commented on Aug 19, 2025

    @lanitochka17
    Author

    Production:

    Recording.3643.mp4
  7. mallenexpensify commented on Aug 20, 2025

    @mallenexpensify
    Contributor

    hmm.. wasn't able to reproduce, and/or.. I see the composer in the vid above, as well as mine

    2025-08-19_17-38-09.mp4
  8. mjasikowski commented on Aug 20, 2025

    @mjasikowski
    Contributor

    Can't reproduce either. @lanitochka17 can you please re-test?

  9. lanitochka17 commented on Aug 20, 2025

    @lanitochka17
    Author

    @mjasikowski The issue is reproduced with new accounts.

  10. lanitochka17 commented on Aug 20, 2025

    @lanitochka17
    Author

    issue is reproducible on mWeb too

    ScreenRecording_08-21-2025.00-15-17_1.MP4
  11. rushatgabhane commented on Aug 20, 2025

    @rushatgabhane
    Member

    @BlameGPT find offending PRs

  12. BlameGPT commented on Aug 20, 2025

    @BlameGPT
    Contributor

    Lowkey sus PRs fr fr

    If not above, check these

  13. mallenexpensify commented on Aug 20, 2025

    @mallenexpensify
    Contributor

    Thanks @rushatgabhane , @mjasikowski , do any of those look like the culprit?

  14. mjasikowski commented on Aug 21, 2025

    @mjasikowski
    Contributor

    Trying again, and:

    Can't reproduce on mac/firefox.
    Can't reproduce on mWeb on my iPhone.

  15. mjasikowski commented on Aug 21, 2025

    @mjasikowski
    Contributor

    Still can't reliably reproduce, but looking at the code, it's most likely this PR causing the problem: #68527

    It changed the route fetching and now runs inside a strict guard that requires the active route to include the optimistic ID. If the user is on generic /r, the guard skips reroute entirely, the optimistic report gets cleared, and you’re left on /r with no composer and no LHN highlight.

  16. mjasikowski commented on Aug 21, 2025

    @mjasikowski
    Contributor

    I'm doing an ad hoc build with reverted #68527 in this PR: #68917 - I'll ask QA to test that so we know for sure if the error is caused by that particular PR.

  17. mjasikowski commented on Aug 21, 2025

    @mjasikowski
    Contributor

    Ad hoc build ready, asked QA for a re-test: https://expensify.slack.com/archives/C9YU7BX5M/p1755781959411029

  18. mjasikowski commented on Aug 22, 2025

    @mjasikowski
    Contributor

    The offending PR was reverted, closing this for now until it resurfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions