Skip to content

[HOLD] The green unread message bar disappears too fast #6896

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Post a bunch of messages, a few screens worth
  2. Make a very early one unread
  3. Switch to a different chat
  4. Switch back to the test chat
  5. It'll show the green unread badge at the top
  6. Scroll back only a little
  7. The badge will disappear she mark everything as read before you actually get to the oldest unread message

Expected Result:

User should actually read the message before green bar disappears

Actual Result:

The green unread message bar disappears too fast once user opens the chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20211223-160754_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640238392016700

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 23, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. mallenexpensify commented on Dec 24, 2021

    @mallenexpensify
    Contributor

    I have a feeling the logic we're using now for when/how we show the green line for unread messages isn't correct, beyond this one issue. if/when someone ends up working on this, can you test many examples on many platforms? If you run into bugs or have improvement recommendations, can you report them in #expensify-open-source? We'll likely want to create stand-alone issues and not want to use this one as a catch-all.

  3. MelvinBot commented on Dec 27, 2021

    @MelvinBot
    Contributor

    @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. MelvinBot commented on Dec 29, 2021

    @MelvinBot
    Contributor

    @jasperhuangg Eep! 4 days overdue now. Issues have feelings too...

  5. MelvinBot commented on Dec 31, 2021

    @MelvinBot
    Contributor

    @jasperhuangg 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  6. mallenexpensify commented on Dec 31, 2021

    @mallenexpensify
    Contributor

    Not sure if this is directly related but it has to do with chats being marked as read when they're not. On staging now.
    #6874
    #6898

  7. marcaaron commented on Dec 31, 2021

    @marcaaron
    Contributor

    Just chatting with @mallenexpensify a bit about this in a 1:1 and wanted to share some context.

    This issue feels a bit nuanced and may require a rework of how we are detecting and storing which messages are "read". My current understanding is that we mark the last read action we have immediately when opening a report and do not track which individual messages have been read or not read (i.e. by looking to see if they are "in view" and checking on scroll).

    So to detect that messages 90-100 have been "read" but 80-90 are "unread" isn't something we are able to do yet. On OldDot we are set up to do this with the Intersection Observer API and some similar mechanism in the Expensify app.

    Maybe it would be good to discuss this one internally a bit, put a plan together, and then apply the External label. Feels like a good opportunity to re-evaluate how our "read" indicators and notifications work in a holistic way.

  8. changed the title [-]The green unread message bar disappears too fast[/-] [+][HOLD] The green unread message bar disappears too fast[/+] on Jan 13, 2022
  9. added and removed on Feb 9, 2022
  10. MelvinBot commented on Mar 4, 2022

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. melvin-bot commented on May 16, 2022

    @melvin-bot

    @mvtglobally, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions