You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD] The green unread message bar disappears too fast #6896
I have a feeling the logic we're using now for when/how we show the green line for unread messages isn't correct, beyond this one issue. if/when someone ends up working on this, can you test many examples on many platforms? If you run into bugs or have improvement recommendations, can you report them in #expensify-open-source? We'll likely want to create stand-alone issues and not want to use this one as a catch-all.
Just chatting with @mallenexpensify a bit about this in a 1:1 and wanted to share some context.
This issue feels a bit nuanced and may require a rework of how we are detecting and storing which messages are "read". My current understanding is that we mark the last read action we have immediately when opening a report and do not track which individual messages have been read or not read (i.e. by looking to see if they are "in view" and checking on scroll).
So to detect that messages 90-100 have been "read" but 80-90 are "unread" isn't something we are able to do yet. On OldDot we are set up to do this with the Intersection Observer API and some similar mechanism in the Expensify app.
Maybe it would be good to discuss this one internally a bit, put a plan together, and then apply the External label. Feels like a good opportunity to re-evaluate how our "read" indicators and notifications work in a holistic way.
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
MelvinBot commentedon Dec 23, 2021
Triggered auto assignment to @jasperhuangg (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mallenexpensify commentedon Dec 24, 2021
I have a feeling the logic we're using now for when/how we show the green line for unread messages isn't correct, beyond this one issue. if/when someone ends up working on this, can you test many examples on many platforms? If you run into bugs or have improvement recommendations, can you report them in #expensify-open-source? We'll likely want to create stand-alone issues and not want to use this one as a catch-all.
MelvinBot commentedon Dec 27, 2021
@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
MelvinBot commentedon Dec 29, 2021
@jasperhuangg Eep! 4 days overdue now. Issues have feelings too...
MelvinBot commentedon Dec 31, 2021
@jasperhuangg 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mallenexpensify commentedon Dec 31, 2021
Not sure if this is directly related but it has to do with chats being marked as read when they're not. On staging now.
#6874
#6898
marcaaron commentedon Dec 31, 2021
Just chatting with @mallenexpensify a bit about this in a 1:1 and wanted to share some context.
This issue feels a bit nuanced and may require a rework of how we are detecting and storing which messages are "read". My current understanding is that we mark the last read action we have immediately when opening a report and do not track which individual messages have been read or not read (i.e. by looking to see if they are "in view" and checking on scroll).
So to detect that messages 90-100 have been "read" but 80-90 are "unread" isn't something we are able to do yet. On OldDot we are set up to do this with the Intersection Observer API and some similar mechanism in the Expensify app.
Maybe it would be good to discuss this one internally a bit, put a plan together, and then apply the
Externallabel. Feels like a good opportunity to re-evaluate how our "read" indicators and notifications work in a holistic way.[-]The green unread message bar disappears too fast[/-][+][HOLD] The green unread message bar disappears too fast[/+]MelvinBot commentedon Mar 4, 2022
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon May 16, 2022
@mvtglobally, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.