Skip to content

[LHN Bugs] [Due for payment 2025-10-13] Drag and drop multiple receipts is causing RBRs in users account #69013

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.97-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify @danielrvidal
Slack conversation (hyperlinked to channel name): #Concierge AI

Action Performed:

  1. Create a new account
  2. Go through onboarding, doesn’t matter how
  3. Create expense
  4. Click Try it out but don’t go through the McTest flow, go back
  5. Drag and drop two receipts in receipt upload
  6. Select Manager McTest as recipiient
  7. It creates 3 expenses, a fake Mctest one and the two recceipts, but with an upload RBR
  8. It also creates a hidden expense in your LHN, which looks like your SelfDM?

Expected Result:

It should only have the two receipts submitted to McTest, no receipts/messages in your SelfDM, and no RBRs

Actual Result:

Creates 3 expenses, a fake Mctest one and the two recceipts, but with an upload RBR, It also creates a hidden expense in your LHN, which looks like your SelfDM?

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2025-08-21_23-37-39.mp4
Recording.1545.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021960083438497739385
  • Upwork Job ID: 1960083438497739385
  • Last Price Increase: 2025-08-25
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  2. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Aug 22, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Creates 3 expenses, a fake Mctest one and the two recceipts, but with an upload RBR, It also creates a hidden expense in your LHN, which looks like your SelfDM?

    What is the root cause of that problem?

    We had the logic to removeDraftTransactions only when the page is mounted

    removeDraftTransactions(true);

    if users goback, this logic is not triggered again because the page is still in the stack. We want to do it because on mobile we show the previous captured receipts when users back to scan page, then users can add, edit or delete. But on large screen we don't show the previous uploaded receipts, then we want to reset the scan flow

    What changes do you think we should make in order to solve the problem?

    In IOURequestStepScan, trigger removeDraftTransactions when the tab is active and on web/desktop platform only

    useEffect(() => {
            if (isMobile() || !isTabActive) {
                return;
            }
    
            removeTransactionReceipt(CONST.IOU.OPTIMISTIC_TRANSACTION_ID);
            removeDraftTransactions(true);
        }, [isTabActive]);
    

    we also can do it in this hook

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can consider to display the uploaded receipts on web/desktop like what we did in mobile

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. Christinadobrzyn commented on Aug 25, 2025

    @Christinadobrzyn
    Contributor

    I can reproduce this, let's start with External

  5. melvin-bot commented on Aug 25, 2025

    @melvin-bot
  6. changed the title [-]Drag and drop multiple receipts is causing RBRs in users account[/-] [+][$250] Drag and drop multiple receipts is causing RBRs in users account[/+] on Aug 25, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 25, 2025
  8. 87 remaining items

  9. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    @shubham1206agra @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. danielrvidal commented on Oct 6, 2025

    @danielrvidal
    Contributor

    Woo, great work team!

  11. changed the title [-][Due for payment 2025-10-13] Drag and drop multiple receipts is causing RBRs in users account[/-] [+][LHN Bugs] [Due for payment 2025-10-13] Drag and drop multiple receipts is causing RBRs in users account[/+] on Oct 6, 2025
  12. moved this from HIGH to MEDIUM or LOW in [#whatsnext] #migrateon Oct 6, 2025
  13. Christinadobrzyn commented on Oct 7, 2025

    @Christinadobrzyn
    Contributor

    @shubham1206agra do we need a regression test? TY!

  14. shubham1206agra commented on Oct 10, 2025

    @shubham1206agra
    Contributor

    @Christinadobrzyn No as this was an edge case

  15. Christinadobrzyn commented on Oct 14, 2025

    @Christinadobrzyn
    Contributor

    Sounds good, thanks @shubham1206agra!

    The payment summary is here - #69013 (comment)

    @shubham1206agra please make sure to request payment through ND. Thank you everyone!

  16. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Oct 14, 2025
  17. JmillsExpensify commented on Oct 21, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions