Repository navigation
[Due for payment 2025-11-11] Remove Onyx.connect() for the key: ONYXKEYS.NVP_ONBOARDING in src/libs/actions/Welcome/OnboardingFlow.ts #69028
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/actions/Welcome/OnboardingFlow.ts
- Onyx Key:
ONYXKEYS.NVP_ONBOARDING - Reference:
Line 20: ONYXKEYS.NVP_ONBOARDING
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
tgolen commentedon Aug 22, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/actions/Welcome/OnboardingFlow.tsto removeOnyx.connect()references #69027melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.11 remaining items
[-]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_ONBOARDING` in `src/libs/actions/Welcome/OnboardingFlow.ts`[/-][+][Due for payment 2025-11-11] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_ONBOARDING` in `src/libs/actions/Welcome/OnboardingFlow.ts`[/+]melvin-bot commentedon Nov 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 4, 2025
@shubham1206agra @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allgandalf commentedon Nov 5, 2025
I require payment for this job via ND
allgandalf commentedon Nov 10, 2025
No checklist here, please see
#69028 (comment)
allgandalf commentedon Nov 12, 2025
bump for payment @trjExpensify
trjExpensify commentedon Nov 12, 2025
Apols, I was travelling yesterday!
Payment summary as follows:
Go ahead and request!
quinthar commentedon Nov 19, 2025
Approve $250 to @allgandalf
garrettmknight commentedon Dec 1, 2025
$250 approved for @shubham1206agra