You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - App returns to Inbox instead of Reports after deleting expense on Reports #69043
Version Number: 9.1.98-0 Reproducible in staging?: Y Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#67999 Email or phone of affected tester (no customers):sdjoinsdjdosjdos1@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Submit an expense to the workspace chat
Go to Reports > Reports
Open the expense report from Step 3
Click More > Delete
Expected Result:
App will return to Reports after deleting expense on Reports
Actual Result:
App returns to Inbox instead of Reports after deleting expense on Reports
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6924124_1755884310680.delete_expense.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Reports - App returns to Inbox instead of Reports after deleting expense on Reports
What is the root cause of that problem?
When deleting a money request from the Search > Money Request Report screen, we always relay on getNavigationUrlOnMoneyRequestDelete to decide which report to navigate next.
However, in the Search flow, there's no logic to navigate back from MONEY_REQUEST_REPORT after deleting expense.
What changes do you think we should make in order to solve the problem?
we should explicitly check the route and canGoBack and go back to previous page safely
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 22, 2025
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 22, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 22, 2025
💬 A slack conversation has been started in #expensify-open-source
lanitochka17 commentedon Aug 22, 2025
Production:
Recording.3657.mp4
samranahm commentedon Aug 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - App returns to Inbox instead of Reports after deleting expense on Reports
What is the root cause of that problem?
When deleting a money request from the Search > Money Request Report screen, we always relay on getNavigationUrlOnMoneyRequestDelete to decide which report to navigate next.
However, in the Search flow, there's no logic to navigate back from MONEY_REQUEST_REPORT after deleting expense.
What changes do you think we should make in order to solve the problem?
we should explicitly check the route and
canGoBackand go back to previous page safelylike we did here
App/src/components/MoneyReportHeader.tsx
Lines 318 to 321 in 91f5892
we can add this logic
above the
goBackRoutecheckApp/src/components/MoneyReportHeader.tsx
Lines 1270 to 1272 in 91f5892
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
thienlnam commentedon Aug 25, 2025
Guessing this will be fixed by this revert #69183
aldo-expensify commentedon Aug 25, 2025
Yep, this is working now
Screen.Recording.2025-08-25.at.2.31.17.PM.mov