Skip to content

[Due for payment 2025-09-30] [$250] Wrong take-off time in Concierge reply in the Trip room #69077

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13177079/test-cases/41237918
Email or phone of affected tester (no customers): applausetester+190302lsn@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: new expensifail account is set up with travel feature in OD

  1. Sign in to ND
  2. Click FAB, '"Book travel"
  3. Book a one-way flight from SEA to SFO at least one month in advance
  4. When the flight is confirmed, navigate to ND and open a trip room
  5. Check the flight time in Concierge replies

Expected Result:

The correct take-off time is shown in the Concierge replies in the trip room

Actual Result:

Wrong take-off time in Concierge reply in the Trip room

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6924139_1755884788583.Trip_room_wrong_time.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021959973452610988351
  • Upwork Job ID: 1959973452610988351
  • Last Price Increase: 2025-09-01
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  2. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. jliexpensify commented on Aug 25, 2025

    @jliexpensify
    Contributor

    @lanitochka17 just wondering, what was the tester's local time in Expensify?

    I'm clarifying with the Travel team here.

  4. changed the title [-]Travel - Wrong take-off time in Concierge reply in the Trip room[/-] [+][WAITING ON SLACK CONFIRMATION] Travel - Wrong take-off time in Concierge reply in the Trip room[/+] on Aug 25, 2025
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 25, 2025
  6. changed the title [-][WAITING ON SLACK CONFIRMATION] Travel - Wrong take-off time in Concierge reply in the Trip room[/-] [+][$250] [WAITING ON SLACK CONFIRMATION] Travel - Wrong take-off time in Concierge reply in the Trip room[/+] on Aug 25, 2025
  7. melvin-bot commented on Aug 25, 2025

    @melvin-bot
  8. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  9. 32 remaining items

  10. melvin-bot commented on Sep 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Sep 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.16-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jjcoffee requires payment through NewDot Manual Requests
    • @TaduJR requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Sep 23, 2025

    @melvin-bot

    @jjcoffee @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. jliexpensify commented on Sep 28, 2025

    @jliexpensify
    Contributor

    Bunmping @jjcoffee for the checklist, and @TaduJR - could you share your Upworks profile (and add it to your GH profile)?

  14. jliexpensify commented on Sep 29, 2025

    @jliexpensify
    Contributor

    Payment Summary

    • C: @TaduJR $250 (to be paid via Upworks)
    • C+: @jjcoffee $250 (to be paid via New Expensify)

    NEW UPWORKS JOB - https://www.upwork.com/jobs/~021972807527208010064

  15. TaduJR commented on Sep 30, 2025

    @TaduJR
    Contributor

    Accepted @jliexpensify

  16. jjcoffee commented on Sep 30, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/62776/files#r2390436094

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Have a travel-enabled account.

    Test:

    1. Click FAB, '"Book travel"
    2. Book a one-way flight from SEA to SFO at least one month in advance
    3. When the flight is confirmed, navigate to ND and open a trip room
    4. Check the flight time in Concierge replies
    5. Verify that the correct take-off time is shown in the Concierge replies in the trip room

    Do we agree 👍 or 👎

  17. trjExpensify commented on Sep 30, 2025

    @trjExpensify
    Contributor

    approved $250 for @jjcoffee.

  18. melvin-bot commented on Sep 30, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @jjcoffee owed $250 via NewDot
    • ROLE: @TaduJR paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@jliexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1959973452610988351/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  19. jliexpensify commented on Oct 1, 2025

    @jliexpensify
    Contributor

    Paid and job closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions