Skip to content

[Due for payment 2025-09-04] Search - Undefined is shown instred of bank name #69125

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.98-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #66078
Email or phone of affected tester (no customers): tester+ndcardtests@applausecard.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Have an account with Expensify Card
  • Have an account with initiated withdrawals to your Expensify Card
    Steps
  1. Go to Reports
  2. In search type: type:expense group-by:withdrawal-id withdrawal-type:expensify-card
  3. Verify you see your withdrawals correctly

Expected Result:

Withdrawals must be correctly displayed

Actual Result:

Undefined is shown instred of bank name

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 24, 2025
  2. melvin-bot commented on Aug 24, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 24, 2025

    @melvin-bot

    Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Aug 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Aug 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. s77rt commented on Aug 24, 2025

    @s77rt
    Member

    Will handle in #69123 but this does not have to be a deploy blocker as real users don't know how to get these results (easily)

  7. jasperhuangg commented on Aug 25, 2025

    @jasperhuangg
    Contributor

    @s77rt I'm not sure that I agree with you. It seems QA followed the exact testing steps outlined in #66078 and immediately hit this bug, and it looks pretty ugly to users.

    Can you outline why it would be difficult for users to encounter this case? If a user is already using aggregates, it seems pretty easy to encounter this bug. I'm inclined to revert the PR so you can fix it in a follow-up in case there are other edge cases that weren't caught in the PR stage.

  8. jasperhuangg commented on Aug 25, 2025

    @jasperhuangg
    Contributor

    @JS00001 ^ what are your thoughts on this, since you authored the original issue?

    cc @thienlnam

  9. 5 remaining items

  10. luacmartins commented on Aug 25, 2025

    @luacmartins
    Contributor

    I agree with @s77rt and @JS00001

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2025
  12. changed the title [-]Search - `Undefined` is shown instred of bank name[/-] [+][Due for payment 2025-09-04] Search - `Undefined` is shown instred of bank name[/+] on Aug 28, 2025
  13. melvin-bot commented on Aug 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.99-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @s77rt requires payment through NewDot Manual Requests
  14. melvin-bot commented on Aug 28, 2025

    @melvin-bot

    @luacmartins / @JS00001 @CortneyOfstad @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. s77rt commented on Aug 30, 2025

    @s77rt
    Member

    No payment is due. A regression from #66078

  16. s77rt commented on Aug 30, 2025

    @s77rt
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Search: Add WithdrawalIDListItemHeader #66078

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      Bug requires regression test: No, bug caught during PR testing and don't think it requires a test. Also it's unlikely to resurface

  17. JS00001 commented on Sep 2, 2025

    @JS00001
    Contributor

    No payment due so going to close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions