Skip to content

[Due for payment 2025-09-19] [$250] Optimistic report name computation causing unexpected log out? #69175

Closed

Description

@neil-marcellini

Problem

The Optimistic report name computation PR / feature creates a middleware in the API's prepareRequest, which is likely introducing a race condition that affects authentication and other actions. This causes requests to not be properly stored in Onyx, resulting in users being unexpectedly logged out in various scenarios.

Please see this Slack conversation for more context.

Solution

The exact root cause of this race condition needs to be identified and resolved.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021960016385628235477
  • Upwork Job ID: 1960016385628235477
  • Last Price Increase: 2025-09-01
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 25, 2025
  2. changed the title [-]Optimistic report name computation causing unexpected log out?[/-] [+][$250] Optimistic report name computation causing unexpected log out?[/+] on Aug 25, 2025
  3. melvin-bot commented on Aug 25, 2025

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 25, 2025
  5. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  6. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. MelvinBot commented on Aug 25, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  8. neil-marcellini commented on Aug 27, 2025

    @neil-marcellini
    ContributorAuthor

    We might fix it in this PR, or deploy it behind a very restrictive beta and fix it separately.

    Reimplementation of Optimistic report names functionality

  9. 10 remaining items

  10. sosek108 commented on Sep 5, 2025

    @sosek108
    Contributor

    I've updated original PR with changes described in previous comment.

    @neil-marcellini @thesahindia @RachCHopkins
    can we create adhoc and ensure by QA that my fix resolves problem?

  11. neil-marcellini commented on Sep 8, 2025

    @neil-marcellini
    ContributorAuthor

    I reviewed the PR. I don't think we need to run the whole QA regression test suite on it before merging, if that's what you were asking for. But we can certainly run tests ourselves on the adhoc build.

  12. neil-marcellini commented on Sep 8, 2025

    @neil-marcellini
    ContributorAuthor

    The root cause has been identified, and won't be included when re-applying the feature, so this can been closed.

  13. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Sep 8, 2025
  14. sosek108 commented on Sep 9, 2025

    @sosek108
    Contributor

    @neil-marcellini

    I don't think we need to run the whole QA regression test suite on it before merging, if that's what you were asking for.

    No, of course not. I meant that someone other by me verify if the bug is not present anymore

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 12, 2025
  16. changed the title [-][$250] Optimistic report name computation causing unexpected log out?[/-] [+][Due for payment 2025-09-19] [$250] Optimistic report name computation causing unexpected log out?[/+] on Sep 12, 2025
  17. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
    • @thesahindia requires payment through NewDot Manual Requests
  19. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    @thesahindia @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNeeds ReproductionReproducible steps neededWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions