Skip to content

[Due for payment 2025-12-26] [Due for payment 2025-12-16] [SAML] [Tracking] Bring SAML Configuration to NewDot #69195

Closed
17 of 17 issues completed

Description

@mountiny

DESIGN DOC ➡️

Predesign links

Proposal

For a full Proposal with Strategy and Background sections, check out the post here.

Problem:

When a migrated domain admin needs to update their SAML settings, if they can’t do that in NewDot, then they’re forced to return to Classic - potentially never coming back thinking NewDot isn’t suitable for their needs.

Solution:

Build domain verification and SAML configuration natively in NewDot. Introduce a new Security section within the Workspaces tab to house these features. This section will allow domain admins to:

  • Verify their private domain.
  • Configure SAML by entering IP metadata or uploading a certificate.
  • Enable or disable SAML enforcement for domain members.

The new Security section will serve as the foundation for future domain-level controls (e.g. security groups, resetting and enforcing 2FA, managing domain members and admins), enabling a more scalable and intuitive admin experience in NewDot.


Note: The naming of the section (Security) is to be discussed in predesign, and it might not be named that way even though the proposal does use this name.

Tasks

  • Post Proposal (full Problem/Solution statement) in #whatsnext https://expensify.slack.com/archives/CC7NECV4L/p1755084010282689
  • Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
  • Paste Proposal in the space above with a link to the Slack thread
  • Email strategy@expensify.com and paste in the Proposal
  • Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section. https://expensify.slack.com/archives/C07NMDKEFMH/p1756219527675449
  • Fill out the High-level overview of the problem, Timeline, Terminology, and High-level of proposed solution sections of the Design Doc
  • Email strategy@expensify.com (continue the same email chain as before - your last message should be the WN Proposal) with the link to your Design Doc containing your high-level problem and solution
  • Add the DesignDocReview label to get the High-level overview of the problem and High-level of proposed solution section reviewed
  • Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
  • Fill out the Detailed implementation of the solution and related sections.
  • Re-add the DesignDocReview label to this issue
  • Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Email strategy@expensify.com one last time to let them know the Design Doc is moving into the implementation phase
  • Implement the changes
  • Add regression tests so that QA can test your feature with every deploy (instructions) https://github.com/Expensify/Expensify/issues/578651
  • Send out a follow up email to strategy@expensify.com once everything has been implemented and do a Project Wrap-Up retrospective that provides:
    • Summary of what we accomplished with this project
    • What went well?
    • What could we have done better?
    • What did we learn?
Issue OwnerCurrent Issue Owner: @mountiny

Activity

  1. self-assigned this
    on Aug 25, 2025
  2. added theissue type on Aug 25, 2025
  3. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  4. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  5. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  6. 118 remaining items

  7. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.84-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @s77rt does not require payment (Contractor)
    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @mhawryluk does not require payment (Contractor)
  8. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ZhenjaHorbach] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  9. melvin-bot commented on Dec 26, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @s77rt does not require payment (Contractor)
    • Reviewer: @ZhenjaHorbach owed $250 via NewDot
    • Contributor: @mhawryluk does not require payment (Contractor)

    BugZero Checklist (@johncschuster)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. mountiny commented on Dec 29, 2025

    @mountiny
    ContributorAuthor

    Waiting for tests and then we can send a wrap up

  11. mountiny commented on Jan 5, 2026

    @mountiny
    ContributorAuthor

    Only final tests pending and wrap up

  12. johncschuster commented on Jan 8, 2026

    @johncschuster
    Contributor

    How are we doing on the final tests, @mountiny?

  13. mountiny commented on Jan 8, 2026

    @mountiny
    ContributorAuthor
  14. mountiny commented on Jan 19, 2026

    @mountiny
    ContributorAuthor

    Testing is all done and follow ups are fixed, the regression tests are conducted during staging regression. Wrap up sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDesignDocNewFeatureSomething to build that is a new item.WeeklyKSv2

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions