Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daledah
Slack conversation (hyperlinked to channel name): #Open Source
Action Performed:
Scenario 1: Incorrect selection state after resizing
- Go to workspace chat
- Create two expenses
- Open the expense report
- Select one expense and observe the header state (correct)
- Deselect the expense
- Resize the screen to a smaller width (<800px)
- Select one expense
- Observe that the header now incorrectly shows “Select multiple” view
- Resize the screen back to large screen (>800px) and observe the state
Scenario 2: Header not updating on resize in selection mode
- Open expense chat
- Create two expenses
- Open the expense report
- Select one expense (enter selection mode)
- Resize the screen to small (<800px)
- Observe that the header does not adapt to the small-screen layout
Expected Result:
There's a checkbox displayed inside each expense row, with checked state for selected expense, The header is updated to "Select multiple" view
Actual Result:
There's no checkboxes shown on expense rows to indicate selection state, The header is not updated to "Select multiple" view
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Screen.Recording.2025-08-26.at.00.47.01.mp4
Screen.Recording.2025-08-26.at.00.26.23.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021968479782341761773
- Upwork Job ID: 1968479782341761773
- Last Price Increase: 2025-09-25
- Automatic offers:
- daledah | Contributor | 108963337
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @VictoriaExpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Aug 26, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.m-natarajan commentedon Aug 26, 2025
Proposal by @daledah
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace empty state animation is not centered on Android
What is the root cause of that problem?
Currently we don't handle selection mode when there's changes in the selected expense state in
SearchContextProviderWe already have logics for this issue inside
SelectionListWithModalApp/src/components/SelectionListWithModal/index.tsx
Lines 50 to 80 in a5f72ac
So similar issue is not reproducible in other lists.
What changes do you think we should make in order to solve the problem?
We should implement logics similar to
SelectionListWithModalforSearchContextProvider. We can move it to a hook like "useHandleSelectionMode" and use it in bothSelectionListWithModalandSearchContextProviderto prevent repetitive code.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
daledah commentedon Aug 26, 2025
Added an additional proposal for the Scenario 1
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense report header is not updated when resizing screen in selection mode
What is the root cause of that problem?
Only in small screen, when selecting the expense,
isMobileSelectionModeEnabledis set totrue.App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 345 to 347 in a5f72ac
We show only
HeaderWithBackButtonwhenisMobileSelectionModeEnabled, without taking screensize into accountApp/src/components/MoneyReportHeader.tsx
Lines 1076 to 1091 in a5f72ac
So when resizing to bigger width, the header is not updated to expected view.
What changes do you think we should make in order to solve the problem?
We should add
shouldUseNarrowLayoutcheck to hereApp/src/components/MoneyReportHeader.tsx
Line 1076 in a5f72ac
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Aug 29, 2025
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Sep 2, 2025
@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Sep 4, 2025
@adelekennedy Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Sep 8, 2025
@adelekennedy 12 days overdue. Walking. Toward. The. Light...
melvin-bot commentedon Sep 9, 2025
@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Sep 11, 2025
This issue has not been updated in over 14 days. @adelekennedy eroding to Weekly issue.
61 remaining items
daledah commentedon Nov 3, 2025
@ZhenjaHorbach we have a follow up pr here
ZhenjaHorbach commentedon Nov 13, 2025
BugZero Checklist:
Unfortunately, I did not find a suitable PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Scenario 1: Incorrect selection state after resizing
Scenario 2: Header not updating on resize in selection mode
Scenario 3:
Do we agree 👍 or 👎
ZhenjaHorbach commentedon Nov 13, 2025
@VictoriaExpensify
We are ready for payment!
VictoriaExpensify commentedon Nov 18, 2025
Request to add reg test to BrowserStack raised - https://github.com/Expensify/Expensify/issues/569077
VictoriaExpensify commentedon Nov 18, 2025
Payment Summary:
C: @daledah paid $250 via Upwork
C+: @ZhenjaHorbach owed $250 via NewDot
Thanks!
ZhenjaHorbach commentedon Nov 18, 2025
Requested in ND!
JmillsExpensify commentedon Nov 20, 2025
$250 approved for @ZhenjaHorbach