Skip to content

VBA - Placeholder text for address field in company information page is displayed as "Personal address" #6928

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create NewDot account, verify it.
  2. Create workspace and start the add VBA flow
  3. Check the placeholder text for address field in "Company information" step

Expected Result:

You should see the inputs for the fields Company address, City, Zip Code, and State

Actual Result:

'Personal address' placeholder instead "Company address' on Company information page.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.24

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5390496_Company

Bug5390496_address.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Dec 29, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Dec 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mananjadhav commented on Dec 29, 2021

    @mananjadhav
    Collaborator

    This commit here is causing the issue
    3cddfcf

    Basically, we moved the "AddressSearch" from "Personal" and "Company" step to a separate component but kept the placeholder as common.personalAddress only.

    We can quickly resolve this:

    1. By either adding a prop addressTranslateKey and passing common.personalAddress and common.companyAddress respectively.
    2. Or we make a generic key that works for both

    Tagging @aldo-expensify as he seems to be the author of the commit.

  4. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    @mananjadhav You are right, thanks for finding that. I'll start working on it now.

  5. mananjadhav commented on Dec 29, 2021

    @mananjadhav
    Collaborator

    @aldo-expensify I wasn't sure if the team is working due to holidays. I've created a quick PR as it was a deploy blocker. You can use it if you want.

  6. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    I've created a quick PR as it was a deploy blocker. You can use it if you want.

    Thanks, looks fine. I was just doubting if we wanted to go this way or we make a generic key that works for both. I guess this way is better because even if it makes the code a bit uglier, it is better for the user experience than having a common text.

    If later we decide that it was better to have a common translation, we can change it later.

  7. mananjadhav commented on Dec 29, 2021

    @mananjadhav
    Collaborator

    If later we decide that it was better to have a common translation, we can change it later.

    Exactly.

  8. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    PR has been merged to staging and looks fixed now.

    Screen Shot 2021-12-29 at 4 14 35 PM
    Screen Shot 2021-12-29 at 4 15 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions