You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes #6931
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
#6811 is my PR. The change that I made was to allow pasting for mobile devices. This problem exists in the production too (where my code doesn't exist) and seems to be unrelated to my PR.
@akshayasalvi your PR#6811 has Desktop and Web checked off as platforms where PR applies and should be tested. Are you saying it is incorrectly marked?
Well when I marked Desktop and Web, it was just to ensure that it didn't break anything that worked already. The intended PR changes were supposed to be for Mobile Web, iOS and Android.
and as I described the issue exists in production as well and hence not related to my PR.
Ohhh, I know now. The number you are copying is at the top of the note... it is part of the "title", if I copy "2021" from the date in the title you see in my video, it doesn't work 😮
Maybe something besides just numbers get copied to the clipboard...
Update: We are getting the following text pasted: *2021*, which gets rejected for not being a number.
So... as @akshayasalvi pointed out, I confirmed that this problem is already in production and doesn't seem to be related to the changes introduced by #6811
I'll remove the deploy blocker label because it is NOT a regression, but I'll keep the GH issue because it is something we have to fix.
I would suggest a solution that simply strips anything that is not a number or . from the text being pasted.
changed the title [-]Mac - Safari - IOU - Unable to paste the amount copied from notes [/-][+][HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes [/+]on Jan 20, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.31-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
OSBotify commentedon Dec 29, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Dec 29, 2021
Triggered auto assignment to @Julesssss (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.akshayasalvi commentedon Dec 29, 2021
#6811 is my PR. The change that I made was to allow pasting for mobile devices. This problem exists in the production too (where my code doesn't exist) and seems to be unrelated to my PR.
mvtglobally commentedon Dec 29, 2021
@akshayasalvi your PR#6811 has Desktop and Web checked off as platforms where PR applies and should be tested. Are you saying it is incorrectly marked?
akshayasalvi commentedon Dec 29, 2021
Well when I marked Desktop and Web, it was just to ensure that it didn't break anything that worked already. The intended PR changes were supposed to be for Mobile Web, iOS and Android.
and as I described the issue exists in production as well and hence not related to my PR.
aldo-expensify commentedon Dec 29, 2021
Hmm, I tested this in staging in Safari + Mac (Web) and it seems to work fine:
Screen.Recording.2021-12-29.at.3.45.37.PM.mov
I used
Cmd + cto copy andCmd + vto paste, did you do something different?kavimuru commentedon Dec 29, 2021
@aldo-expensify Still able to reproduce. I used right click menu
Recording.10.mp4
.
aldo-expensify commentedon Dec 29, 2021
@kavimuru hmm I tried with the right click menu and it worked... 😕 I'm no sure about what could be making the difference...
Screen.Recording.2021-12-29.at.5.28.10.PM.mov
aldo-expensify commentedon Dec 29, 2021
Ohhh, I know now. The number you are copying is at the top of the note... it is part of the "title", if I copy "2021" from the date in the title you see in my video, it doesn't work 😮
Maybe something besides just numbers get copied to the clipboard...
Update: We are getting the following text pasted:
*2021*, which gets rejected for not being a number.aldo-expensify commentedon Dec 29, 2021
So... as @akshayasalvi pointed out, I confirmed that this problem is already in production and doesn't seem to be related to the changes introduced by #6811
I'll remove the
deploy blockerlabel because it is NOT a regression, but I'll keep the GH issue because it is something we have to fix.I would suggest a solution that simply strips anything that is not a number or
.from the text being pasted.47 remaining items
[-]Mac - Safari - IOU - Unable to paste the amount copied from notes [/-][+][HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes [/+]botify commentedon Jan 20, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.31-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-27. 🎊
mvtglobally commentedon Jan 25, 2022
Issue not reproducible during KI retests. (Second week)
mvtglobally commentedon Feb 1, 2022
Issue not reproducible during KI retests. (Third week)
Julesssss commentedon Feb 1, 2022
Not overdue
parasharrajat commentedon Feb 1, 2022
cc: @MitchExpensify for payment processing. He was removed accidentally.

aldo-expensify commentedon Feb 1, 2022
Adding @MitchExpensify again as I removed him accidentally
MitchExpensify commentedon Feb 1, 2022
@songlang1994 I am getting a "This profile no longer available" when going to issue your payment:

Thanks to Upwork's automatic closing of jobs I've created a new job post here that I can use to issue your C+ payment @parasharrajat - Offer sent!
songlang1994 commentedon Feb 2, 2022
@MitchExpensify Should I do anything for this?
MitchExpensify commentedon Feb 2, 2022
Weird, @songlang1994 I just looked again and now see the option to complete payment - Sent! Sorry for the delay
MitchExpensify commentedon Feb 2, 2022
Also C+ payment has been sent and contract ended @parasharrajat , thank you!