Skip to content

[HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes  #6931

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #6811

Action Performed:

  1. Copy a numeric value from Notes on MAC (it has to be a "title" in notes)
  2. Go to FAB
  3. Click on Send money or Request money option
  4. Paste the amount

Expected Result:

You should be able to paste the amount

Actual Result:

Unable paste the amount copied from notes in MAC.
Working if I copy paste from text edit and msword
Chrome need to select "paste and match style"

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web - Safari

Version Number: v1.1.24-0

Reproducible in staging?: Yes

Reproducible in production?: new feature

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Issue was found when executing #6811
https://user-images.githubusercontent.com/43996225/147685859-16450305-f862-4f6d-872f-4594fde2ce6a.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Dec 29, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Dec 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. akshayasalvi commented on Dec 29, 2021

    @akshayasalvi
    Contributor

    #6811 is my PR. The change that I made was to allow pasting for mobile devices. This problem exists in the production too (where my code doesn't exist) and seems to be unrelated to my PR.

  4. mvtglobally commented on Dec 29, 2021

    @mvtglobally

    @akshayasalvi your PR#6811 has Desktop and Web checked off as platforms where PR applies and should be tested. Are you saying it is incorrectly marked?

  5. akshayasalvi commented on Dec 29, 2021

    @akshayasalvi
    Contributor

    Well when I marked Desktop and Web, it was just to ensure that it didn't break anything that worked already. The intended PR changes were supposed to be for Mobile Web, iOS and Android.

    and as I described the issue exists in production as well and hence not related to my PR.

  6. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    Hmm, I tested this in staging in Safari + Mac (Web) and it seems to work fine:

    Screen.Recording.2021-12-29.at.3.45.37.PM.mov

    I used Cmd + c to copy and Cmd + v to paste, did you do something different?

  7. kavimuru commented on Dec 29, 2021

    @kavimuru
    Author

    @aldo-expensify Still able to reproduce. I used right click menu

    Recording.10.mp4

    .

  8. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    @kavimuru hmm I tried with the right click menu and it worked... 😕 I'm no sure about what could be making the difference...

    Screen.Recording.2021-12-29.at.5.28.10.PM.mov
  9. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    Ohhh, I know now. The number you are copying is at the top of the note... it is part of the "title", if I copy "2021" from the date in the title you see in my video, it doesn't work 😮

    Maybe something besides just numbers get copied to the clipboard...

    Update: We are getting the following text pasted: *2021*, which gets rejected for not being a number.

  10. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    So... as @akshayasalvi pointed out, I confirmed that this problem is already in production and doesn't seem to be related to the changes introduced by #6811

    I'll remove the deploy blocker label because it is NOT a regression, but I'll keep the GH issue because it is something we have to fix.

    I would suggest a solution that simply strips anything that is not a number or . from the text being pasted.

  11. 47 remaining items

  12. changed the title [-]Mac - Safari - IOU - Unable to paste the amount copied from notes [/-] [+][HOLD for payment 2022-01-27] Mac - Safari - IOU - Unable to paste the amount copied from notes [/+] on Jan 20, 2022
  13. botify commented on Jan 20, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.31-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-27. 🎊

  14. mvtglobally commented on Jan 25, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  15. mvtglobally commented on Feb 1, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Third week)

  16. Julesssss commented on Feb 1, 2022

    @Julesssss
    Contributor

    Not overdue

  17. parasharrajat commented on Feb 1, 2022

    @parasharrajat
    Member

    cc: @MitchExpensify for payment processing. He was removed accidentally.
    image

  18. aldo-expensify commented on Feb 1, 2022

    @aldo-expensify
    Contributor

    Adding @MitchExpensify again as I removed him accidentally

  19. MitchExpensify commented on Feb 1, 2022

    @MitchExpensify
    Contributor

    @songlang1994 I am getting a "This profile no longer available" when going to issue your payment:
    image

    image

    Thanks to Upwork's automatic closing of jobs I've created a new job post here that I can use to issue your C+ payment @parasharrajat - Offer sent!

  20. songlang1994 commented on Feb 2, 2022

    @songlang1994
    Contributor

    @MitchExpensify Should I do anything for this?

  21. MitchExpensify commented on Feb 2, 2022

    @MitchExpensify
    Contributor

    Weird, @songlang1994 I just looked again and now see the option to complete payment - Sent! Sorry for the delay

  22. MitchExpensify commented on Feb 2, 2022

    @MitchExpensify
    Contributor

    Also C+ payment has been sent and contract ended @parasharrajat , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions