You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - White screen displayed after log out #6932
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Is it possible for AppState.addEventListener('change', appStateChangeCallback); to return undefined? I failed to find what it returns in the documentation :(
Unfortunately, PR was merged before I was able to test it.
But we are planning to upgrade the RN to v65 and this problem will be resolved there. cc: @roryabraham
Thanks @parasharrajat. Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x. So the real fix is to upgrade react native version. I already tested @roryabraham's PR on iOS and everything looks good. We might want more eyes on that PR.
@parasharrajat@roryabraham Are we going to merge the RN upgrade PR soon? If not then we should merge the null check PR so that it can be removed from DeployBlocker. If we'll merge soon then that's the ideal fix.
Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x.
But... removeEventListener doesn't seem to be used here, the new way .remove() is being used.
Are we going to merge the RN upgrade PR soon
I don't think that the PR upgrading RN will be cherry picked to staging, so I agree with we should merge the null check PR so that it can be removed from DeployBlocker.
Activity
OSBotify commentedon Dec 29, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Dec 29, 2021
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mananjadhav commentedon Dec 29, 2021
This has cropped up in #6898. The undefined check for the appStateSubscription is missing.
App/src/libs/AppStateMonitor/index.js
Lines 27 to 30 in 29e469a
Change it to:
As I commented in slack, there's a follow up PR being worked on to upgrade RN which would be the ideal fix.
cc - @aswin-s @parasharrajat Since you guys were involved in the PR.
aldo-expensify commentedon Dec 29, 2021
Is it possible for
AppState.addEventListener('change', appStateChangeCallback);to returnundefined? I failed to find what it returns in the documentation :(Documentation: https://reactnative.dev/docs/appstate#addeventlistener
parasharrajat commentedon Dec 29, 2021
Unfortunately, PR was merged before I was able to test it.
But we are planning to upgrade the RN to v65 and this problem will be resolved there. cc: @roryabraham
aswin-s commentedon Dec 29, 2021
Thanks @parasharrajat. Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x. So the real fix is to upgrade react native version. I already tested @roryabraham's PR on iOS and everything looks good. We might want more eyes on that PR.
mananjadhav commentedon Dec 29, 2021
@parasharrajat @roryabraham Are we going to merge the RN upgrade PR soon? If not then we should merge the null check PR so that it can be removed from DeployBlocker. If we'll merge soon then that's the ideal fix.
aldo-expensify commentedon Dec 29, 2021
But...
removeEventListenerdoesn't seem to be used here, the new way.remove()is being used.I don't think that the PR upgrading RN will be cherry picked to staging, so I agree with
we should merge the null check PR so that it can be removed from DeployBlocker.aldo-expensify commentedon Dec 29, 2021
Which PR? #6898?
parasharrajat commentedon Dec 29, 2021
Yup. 6898.
aldo-expensify commentedon Dec 29, 2021
PR with fixed merged and CP'd to staging.
mvtglobally commentedon Dec 31, 2021
Retested. Issue is Fixed.