Skip to content

Android - White screen displayed after log out #6932

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Send some messages or request money
  4. Log out

Expected Result:

User should log out from the account and login screen appears

Actual Result:

White screen displayed after log out

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: v1.1.24.0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5390623_Screenshot_20211229-101859_New_Expensify

Bug5390623_20211229_172356.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Dec 29, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Dec 29, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mananjadhav commented on Dec 29, 2021

    @mananjadhav
    Collaborator

    This has cropped up in #6898. The undefined check for the appStateSubscription is missing.

    const appStateChangeSubscription = AppState.addEventListener('change', appStateChangeCallback);
    return () => {
    appStateChangeSubscription.remove();
    };

    Change it to:

    if (!appStateChangeSubscription) {
        return;
    }
    appStateChangeSubscription.remove();
    
    

    As I commented in slack, there's a follow up PR being worked on to upgrade RN which would be the ideal fix.

    cc - @aswin-s @parasharrajat Since you guys were involved in the PR.

  4. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    Is it possible for AppState.addEventListener('change', appStateChangeCallback); to return undefined? I failed to find what it returns in the documentation :(

    Documentation: https://reactnative.dev/docs/appstate#addeventlistener

  5. parasharrajat commented on Dec 29, 2021

    @parasharrajat
    Member

    Unfortunately, PR was merged before I was able to test it.
    But we are planning to upgrade the RN to v65 and this problem will be resolved there. cc: @roryabraham

  6. aswin-s commented on Dec 29, 2021

    @aswin-s
    Contributor

    Thanks @parasharrajat. Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x. So the real fix is to upgrade react native version. I already tested @roryabraham's PR on iOS and everything looks good. We might want more eyes on that PR.

  7. mananjadhav commented on Dec 29, 2021

    @mananjadhav
    Collaborator

    @parasharrajat @roryabraham Are we going to merge the RN upgrade PR soon? If not then we should merge the null check PR so that it can be removed from DeployBlocker. If we'll merge soon then that's the ideal fix.

  8. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    Yes as explained over here, removeEventListener was deprecated only in version 0.65 and we are still on 0.64.x.

    But... removeEventListener doesn't seem to be used here, the new way .remove() is being used.

    Are we going to merge the RN upgrade PR soon

    I don't think that the PR upgrading RN will be cherry picked to staging, so I agree with we should merge the null check PR so that it can be removed from DeployBlocker.

  9. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    Unfortunately, PR was merged before I was able to test it.

    Which PR? #6898?

  10. parasharrajat commented on Dec 29, 2021

    @parasharrajat
    Member

    Yup. 6898.

  11. aldo-expensify commented on Dec 29, 2021

    @aldo-expensify
    Contributor

    PR with fixed merged and CP'd to staging.

  12. mvtglobally commented on Dec 31, 2021

    @mvtglobally

    Retested. Issue is Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions