You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Due for payment 2025-09-26] User setting - limited copilot unable to add personal bank account #69768
Version Number: 9.2.1-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: NA Email or phone of affected tester (no customers): NA Issue reported by: Applause Internal Team Device used: Win11/Chrome App Component: User Settings
Action Performed:
Precondition: user A have Collect workspace with personal bank accounts are added
[User A] Navigate to Profile >> Security >> Add user B as a Copilot with Limited access
[User B] logged in >> Switch to User A account
[User B] Navigate to Profile>> Wallet >> Click "Add bank account".
Expected Result:
User B with Limited Copilot access should be allowed to add a personal bank account when co-piloted in. We allow adding business bank accounts in NewDot as a limited access copilot and we allow adding both personal and business bank accounts as as limited access copilot in OldDot.
Actual Result:
User B is blocked from adding personal bank accounts via Wallet tab.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can render WorkspaceWorkflowsPage (with USD currency policy) and verify the delegate no access modal shows when pressing the add bank account button for limited copilot access.
Hm, I just tested and was able to add a personal bank account as a limited copilot from OldDot. I wonder why we prevent this in NewDot. I'd expect them to be the same.
We discussed in slack and confirmed the original behavior described in OP is wrong. We allow limited access copilots to add both business and personal bank accounts in OldDot. We want the same in NewDot. So to change that, we need to allow them to add personal bank accounts in NewDot. I updated OP to reflect that, so everyone can update their proposals now 👍
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition: User B sets user A as a copilot (full or limited, both should act the same in this flow).
Login with user A.
Switch to user B.
Open the wallet page.
Click on Add bank account / Enable wallet.
Verify the flow is opened and allowed for copilot.
Activity
melvin-bot commentedon Sep 3, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Sep 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User setting - limited copilot able to add bank account
What is the root cause of that problem?
We have not implement the
showDelegateNoAccessModalin addBankAccount flow hereApp/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
Lines 266 to 276 in 7959604
What changes do you think we should make in order to solve the problem?
We should get the
DelegateNoAccessContextand us it no limited access delegetorlike we did here
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Line 188 in 7959604
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Sep 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Limited copilot can add business bank account.
What is the root cause of that problem?
Currently we don't have any logic to prevent copilot from adding the business bank account.
App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
Lines 266 to 276 in f20a6b8
What changes do you think we should make in order to solve the problem?
We should show the same modal when copilot is trying to do restricted action.
We can fix other cases if found
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can render WorkspaceWorkflowsPage (with USD currency policy) and verify the delegate no access modal shows when pressing the add bank account button for limited copilot access.
joekaufmanexpensify commentedon Sep 3, 2025
@dylanexpensify @dangrous is it expected that a limited access copilot is allowed to add a business bank account?
joekaufmanexpensify commentedon Sep 4, 2025
Hm, I just tested and was able to add a personal bank account as a limited copilot from OldDot. I wonder why we prevent this in NewDot. I'd expect them to be the same.
joekaufmanexpensify commentedon Sep 4, 2025
Discussing more in slack
joekaufmanexpensify commentedon Sep 5, 2025
We discussed in slack and confirmed the original behavior described in OP is wrong. We allow limited access copilots to add both business and personal bank accounts in OldDot. We want the same in NewDot. So to change that, we need to allow them to add personal bank accounts in NewDot. I updated OP to reflect that, so everyone can update their proposals now 👍
melvin-bot commentedon Sep 5, 2025
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
50 remaining items
joekaufmanexpensify commentedon Sep 26, 2025
Bumped checklist in slack
ikevin127 commentedon Sep 26, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition: User B sets user A as a copilot (full or limited, both should act the same in this flow).
Do we agree 👍 or 👎.
ikevin127 commentedon Sep 27, 2025
@joekaufmanexpensify Can I have a payment summary confirmation for ND request please ?
joekaufmanexpensify commentedon Sep 29, 2025
Regression issue here
joekaufmanexpensify commentedon Sep 29, 2025
Payment Summary
joekaufmanexpensify commentedon Sep 29, 2025
@mkzie2 $250 sent and contract ended!
joekaufmanexpensify commentedon Sep 29, 2025
Upwork job closed.
joekaufmanexpensify commentedon Sep 29, 2025
@ikevin127 please request payment at your earliest convenience. Closing as this is otherwise all set. Thanks everyone!
twisterdotcom commentedon Sep 29, 2025
@ikevin127 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-d9be-a371-b6c4-926a37063c21