Skip to content

[$250] [Due for payment 2025-09-26] User setting - limited copilot unable to add personal bank account #69768

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): NA
Issue reported by: Applause Internal Team
Device used: Win11/Chrome
App Component: User Settings

Action Performed:

Precondition: user A have Collect workspace with personal bank accounts are added

  1. Open the link www.staging.new.expensify.com
  2. [user A] User logged in
  3. [User A] Navigate to Profile >> Security >> Add user B as a Copilot with Limited access
  4. [User B] logged in >> Switch to User A account
  5. [User B] Navigate to Profile>> Wallet >> Click "Add bank account".

Expected Result:

User B with Limited Copilot access should be allowed to add a personal bank account when co-piloted in. We allow adding business bank accounts in NewDot as a limited access copilot and we allow adding both personal and business bank accounts as as limited access copilot in OldDot.

Actual Result:

User B is blocked from adding personal bank accounts via Wallet tab.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6933968_1756881510388.Recording__1997__2_.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021971316057028584743
  • Upwork Job ID: 1971316057028584743
  • Last Price Increase: 2025-09-25
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 3, 2025
  2. melvin-bot commented on Sep 3, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Sep 3, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User setting - limited copilot able to add bank account

    What is the root cause of that problem?

    We have not implement the showDelegateNoAccessModal in addBankAccount flow here

    onPress={() => {
    if (isAccountLocked) {
    showLockedAccountModal();
    return;
    }
    if (!isCurrencySupportedForGlobalReimbursement((policy?.outputCurrency ?? '') as CurrencyType, isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND))) {
    setIsUpdateWorkspaceCurrencyModalOpen(true);
    return;
    }
    navigateToBankAccountRoute(route.params.policyID, ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID));
    }}

    What changes do you think we should make in order to solve the problem?

    We should get the DelegateNoAccessContext and us it no limited access delegetor

    like we did here

    const {isDelegateAccessRestricted, showDelegateNoAccessModal} = useContext(DelegateNoAccessContext);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. bernhardoj commented on Sep 3, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Limited copilot can add business bank account.

    What is the root cause of that problem?

    Currently we don't have any logic to prevent copilot from adding the business bank account.

    onPress={() => {
    if (isAccountLocked) {
    showLockedAccountModal();
    return;
    }
    if (!isCurrencySupportedForGlobalReimbursement((policy?.outputCurrency ?? '') as CurrencyType, isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND))) {
    setIsUpdateWorkspaceCurrencyModalOpen(true);
    return;
    }
    navigateToBankAccountRoute(route.params.policyID, ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID));
    }}

    What changes do you think we should make in order to solve the problem?

    We should show the same modal when copilot is trying to do restricted action.

    const {isActingAsDelegate, showDelegateNoAccessModal} = useContext(DelegateNoAccessContext);
    if (isActingAsDelegate) {
        showDelegateNoAccessModal();
        return;
    }

    We can fix other cases if found

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can render WorkspaceWorkflowsPage (with USD currency policy) and verify the delegate no access modal shows when pressing the add bank account button for limited copilot access.

  5. joekaufmanexpensify commented on Sep 3, 2025

    @joekaufmanexpensify
    Contributor

    @dylanexpensify @dangrous is it expected that a limited access copilot is allowed to add a business bank account?

  6. joekaufmanexpensify commented on Sep 4, 2025

    @joekaufmanexpensify
    Contributor

    Hm, I just tested and was able to add a personal bank account as a limited copilot from OldDot. I wonder why we prevent this in NewDot. I'd expect them to be the same.

    Image
  7. joekaufmanexpensify commented on Sep 4, 2025

    @joekaufmanexpensify
    Contributor
  8. joekaufmanexpensify commented on Sep 5, 2025

    @joekaufmanexpensify
    Contributor

    We discussed in slack and confirmed the original behavior described in OP is wrong. We allow limited access copilots to add both business and personal bank accounts in OldDot. We want the same in NewDot. So to change that, we need to allow them to add personal bank accounts in NewDot. I updated OP to reflect that, so everyone can update their proposals now 👍

  9. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 5, 2025
  11. 50 remaining items

  12. joekaufmanexpensify commented on Sep 26, 2025

    @joekaufmanexpensify
    Contributor
  13. ikevin127 commented on Sep 26, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A - Result of the original design.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition: User B sets user A as a copilot (full or limited, both should act the same in this flow).

    1. Login with user A.
    2. Switch to user B.
    3. Open the wallet page.
    4. Click on Add bank account / Enable wallet.
    5. Verify the flow is opened and allowed for copilot.

    Do we agree 👍 or 👎.

  14. ikevin127 commented on Sep 27, 2025

    @ikevin127
    Contributor

    @joekaufmanexpensify Can I have a payment summary confirmation for ND request please ?

  15. joekaufmanexpensify commented on Sep 29, 2025

    @joekaufmanexpensify
    Contributor

    Regression issue here

  16. joekaufmanexpensify commented on Sep 29, 2025

    @joekaufmanexpensify
    Contributor

    Payment Summary

    • Contributor: @mkzie2 due $250 via Upwork
    • Contributor+: @ikevin127 due $250 via NewDot
  17. joekaufmanexpensify commented on Sep 29, 2025

    @joekaufmanexpensify
    Contributor

    @mkzie2 $250 sent and contract ended!

  18. joekaufmanexpensify commented on Sep 29, 2025

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  19. joekaufmanexpensify commented on Sep 29, 2025

    @joekaufmanexpensify
    Contributor

    @ikevin127 please request payment at your earliest convenience. Closing as this is otherwise all set. Thanks everyone!

  20. twisterdotcom commented on Sep 29, 2025

    @twisterdotcom
    Contributor

    @ikevin127 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-d9be-a371-b6c4-926a37063c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions