Skip to content

[Due for payment 2025-10-28] [Due for payment 2025-10-27] [Create Automated Test] Account - GBR: validate unvalidated contact method #69920

Closed

Description

@clarajones-expensify

This issue is to track the creation of automated tests to ensure that all Red Brick Road and Green Brick Road flows are working as expected. This issue covers one specific instance of where the Brick Road shows up and the criteria for it doing so.

Section: Account
Type: GBR
Criteria for showing the brick road: Validate unvalidated contact method
Intentional?: Yes
What the green/red dot links to: NA

Project Tracker: #66716

Issue OwnerCurrent Issue Owner: @clarajones-expensify

Activity

  1. melvin-bot commented on Sep 4, 2025

    @melvin-bot

    Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

  2. added
    InternalRequires API changes or must be handled by Expensify staff
    Hot PickReady for an engineer to pick up and run with
    on Sep 8, 2025
  3. melvin-bot commented on Sep 29, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  4. jnowakow commented on Oct 13, 2025

    @jnowakow
    Contributor

    Hello, I'll grab this one :)

  5. self-assigned this
    on Oct 13, 2025
  6. removed
    Hot PickReady for an engineer to pick up and run with
    on Oct 13, 2025
  7. jnowakow commented on Oct 13, 2025

    @jnowakow
    Contributor

    @mountiny as I understand this RBR is displayed on ContactMethodsPage

    Image

    It's presence is derived from LoginList Onyx collection:

    let indicator;
    if (Object.values(login?.errorFields ?? {}).some((errorField) => !isEmptyObject(errorField))) {
    indicator = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
    } else if (!login?.validatedDate && !isDefaultContactMethod) {
    indicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
    } else if (!login?.validatedDate && isDefaultContactMethod && loginNames.length > 1) {
    indicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
    }

    So there's no direct information from BE that this RBR should be shown. This means that tests should be added in App, right?

  8. jnowakow commented on Oct 13, 2025

    @jnowakow
    Contributor

    Looking at #69919 I assume that yes, the tests should be in App :)

  9. 33 remaining items

  10. changed the title [-][Due for payment 2025-10-27] [Create Automated Test] Account - GBR: validate unvalidated contact method[/-] [+][Due for payment 2025-10-28] [Due for payment 2025-10-27] [Create Automated Test] Account - GBR: validate unvalidated contact method[/+] on Oct 21, 2025
  11. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
    • @situchan requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    @situchan @clarajones-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @jnowakow is from an agency-contributor and not due payment
    • ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@clarajones-expensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. clarajones-expensify commented on Oct 30, 2025

    @clarajones-expensify
    ContributorAuthor

    @mountiny this should be $125 right?

  15. situchan commented on Oct 30, 2025

    @situchan
    Contributor

    Looks like 2 PRs were linked to this issue.
    The first PR I reviewed was not [No QA] PR and required testing so standard rate may apply

  16. clarajones-expensify commented on Oct 31, 2025

    @clarajones-expensify
    ContributorAuthor

    Got it, @mountiny do you have a take on what the price for this one should be? Thank you!

  17. mountiny commented on Nov 3, 2025

    @mountiny
    Contributor

    $250 for @situchan for this PR #72463

  18. clarajones-expensify commented on Nov 3, 2025

    @clarajones-expensify
    ContributorAuthor

    @situchan - just sent you an offer on upwork!

  19. clarajones-expensify commented on Nov 4, 2025

    @clarajones-expensify
    ContributorAuthor

    Payment Summary

    Contributor: @situchan paid $250 via Upwork

  20. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions