You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for 548993][$250] Report field updates system message not shown in expense details after submitting #70173
Version Number: 9.2.3-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#66918 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari App Component: Other
Action Performed:
Sign in to ND
Create a workspace, enable report fields for the workspace.
On the Report Fields section, click Add Field
Click Name and enter "Importance", click Type > choose Text, > keep Initial Value blank
Create an expense in the workspace chat
Open the expense details, scroll to the top of the report click the Report Field "Importance"
Enter value in the report field, Save
Verify the change is reflected in the report audit trail
Submit the expense
Change the value in the report field
Check the system message in the report details - there is no new message about the value update in the report audit trail
Navigate to the Reports/Chats, click on the system message from step 8
Expected Result:ystem message about change in the report field appears in the expense details after submitting the expense
Actual Result:
System message about change in the report field does not appear in the expense details after submitting the expense. When navigating to the Reports/Chats and clicking on the message, "Not here" page is shown for 2-3 seconds, then the system message finally appears in the expense thread
What changes do you think we should make in order to solve the problem?
Can update to re-trigger api to fetch new data here
if(value!==''){updateReportField({...report,reportID: report.reportID},{...reportField, value},reportField,policyasunknownasPolicy,hasOtherViolations);openReport(report.reportID);// Or getNewerActions}goBack();
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Update to
API.write(WRITE_COMMANDS.SET_REPORT_FIELD,parameters,{optimisticData, failureData, successData}).then(()=>{// Refresh report actions to ensure the backend-generated CHANGE_FIELD action is visible// The backend creates the actual action but doesn't return it in the SET_REPORT_FIELD responseopenReport(reportID);});// OrAPI.write(WRITE_COMMANDS.SET_REPORT_FIELD,parameters,{optimisticData, failureData, successData}).then(()=>{// The backend creates a CHANGE_FIELD action but doesn't return it in the SET_REPORT_FIELD response.// We need to fetch newer actions to ensure the backend-generated action becomes visible.// This is a workaround until the backend includes the action in the SET_REPORT_FIELD response.getNewerActions(reportID,optimisticChangeFieldAction.reportActionID);});
Or update BE API for SET_REPORT_FIELD to return change log data as well
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Report field updates system message not shown in expense details after submitting[/-][+][HOLD for 548993][$250] Report field updates system message not shown in expense details after submitting[/+]on Oct 7, 2025
@Christinadobrzyn please retest this via QA once #71978 is closed. We duplicated efforts here, thinking if there is a way we can avoid this in future 🤔
Activity
melvin-bot commentedon Sep 9, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lorretheboy commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report field updates system message not shown in expense details after submitting
What is the root cause of that problem?
The backend creates a CHANGE_FIELD action but doesn't return it in the SET_REPORT_FIELD response
App/src/libs/actions/Report.ts
Line 2508 in 25fe0eb
What changes do you think we should make in order to solve the problem?
Can update to re-trigger api to fetch new data here
App/src/pages/EditReportFieldPage.tsx
Lines 73 to 76 in ddfb213
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Update to
Or update BE API for SET_REPORT_FIELD to return change log data as well
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
dmkt9 commentedon Sep 9, 2025
BE issue
Christinadobrzyn commentedon Sep 9, 2025
Thanks for the direction @dmkt9 - looking for an internal volunteer
allgandalf commentedon Sep 11, 2025
Hmm, looking, if this doesn't take a lot of time, I'll pick up but if it does take I'll keep it open for others
allgandalf commentedon Sep 11, 2025
@dmkt9 @Christinadobrzyn I think this is an frontend, BE does return the report action on update:
{ "key": "reportActions_780096523297963", "onyxMethod": "merge", "value": { "4561095984781356303": { "actionName": "CHANGEFIELD", "actorAccountID": 39, "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_17.png", "created": "2025-09-11 09:28:55.552", "lastModified": "2025-09-11 09:28:55.552", "message": [ { "html": "", "text": "", "type": "COMMENT", "whisperedTo": [] } ], "originalMessage": { "fieldName": "Test field", "isNewDot": true, "lastModified": "2025-09-11 09:28:55.552", "newType": "text", "newValue": "Without approve", "oldType": "text", "oldValue": "Without submit" }, "person": [ { "style": "strong", "text": "fadlsklksafdfsada", "type": "TEXT" } ], "reportActionID": "4561095984781356303", "shouldShow": true } } },@dmkt9 can you please explain more about how this can be a backend issue?
lorretheboy commentedon Sep 11, 2025
@allgandalf could u please help check my proposal. It may answer your question
dmkt9 commentedon Sep 11, 2025
@allgandalf You can see the BE return
"html": "". ThenopenReportwill return the correct valueallgandalf commentedon Sep 11, 2025
Interesting, I'll take a look
42 remaining items
Christinadobrzyn commentedon Sep 30, 2025
following https://github.com/Expensify/Expensify/issues/548993
trjExpensify commentedon Oct 7, 2025
What's the purpose of having this open? Can we close it in favour of https://github.com/Expensify/Expensify/issues/548993, or minimally put it on hold or something?
Christinadobrzyn commentedon Oct 7, 2025
Good point, I was thinking we can keep this open to see if we need QA to retest after https://github.com/Expensify/Expensify/issues/548993 is closed.
I'll add a hold to this for testing once https://github.com/Expensify/Expensify/issues/548993 is closed.
[-][$250] Report field updates system message not shown in expense details after submitting[/-][+][HOLD for 548993][$250] Report field updates system message not shown in expense details after submitting[/+]Christinadobrzyn commentedon Oct 15, 2025
watching https://github.com/Expensify/Expensify/issues/548993
allgandalf commentedon Oct 15, 2025
Hello, While i was working on https://github.com/Expensify/Auth/pull/17433, another dupe issue was created last week which had the same RCA, A BE fix was created and merged for that issue https://github.com/Expensify/Auth/pull/17644.
So now there is no need for https://github.com/Expensify/Auth/pull/17433 to be merged, since we already have the fix merged, I will go forward and close https://github.com/Expensify/Expensify/issues/548993.
@Christinadobrzyn please retest this via QA once #71978 is closed. We duplicated efforts here, thinking if there is a way we can avoid this in future 🤔
Christinadobrzyn commentedon Oct 22, 2025
#71978 is closed, asking QA to retest! We can compensate you @allgandalf? https://expensify.slack.com/archives/C9YU7BX5M/p1761092941188549
allgandalf commentedon Oct 22, 2025
No, I worked on the BE for this issue, and i get paid an hourly rate, so no compensation due for this job thanks :)
m-natarajan commentedon Oct 22, 2025
Not repro on Windows 10/Chrome/Build v9.2.36-0
2025-10-22.06-53-27.mp4
Christinadobrzyn commentedon Oct 22, 2025
Awesome, ok let's close! Thanks everyone, let me know if I've missed anything.