You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-09] [$250] Chat-Delete expense in offline remove them immediately instead of grey out #70185
Version Number: v9.2.3-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#69872 Email or phone of affected tester (no customers):ndk.2303+approver@gmail.com Issue reported by: Applause Internal Team Device used: Windows 11 Home/Chrome App Component: Money Requests
Then the one transaction view appears because we only have one transaction.
What changes do you think we should make in order to solve the problem?
We should introduce isOffline parameter in getAllNonDeletedTransactions function, and don't filter out the transaction if it's pending delete or the iou action related to this one is pending delete. If we always want to keep the pending delete transaction, we can do the logic without isOffline param. Small improvement can be done in the PR.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Test getAllNonDeletedTransactions function and verify that this function keep the pending delete transaction when isOffline parameter is true.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
The expense is removed immediately when delete it in offline mode
What is the root cause of that problem?
Because the getAllNonDeletedTransactions function filters out transactions that are pending deletion, even though visibleTransactions has an exception for offline mode, those pending-deletion transactions are still excluded from the list:
What changes do you think we should make in order to solve the problem?
We should allow transactions with pending deletion actions to pass through getAllNonDeletedTransactions, and defer the filtering logic to visibleTransactions.
Note: It may be worth reviewing all usages of getAllNonDeletedTransactions and adjusting them accordingly if needed.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add test coverage for getAllNonDeletedTransactions.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Chat-Delete expense in offline remove them immediately instead of grey out[/-][+][$250] Chat-Delete expense in offline remove them immediately instead of grey out[/+]on Sep 9, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Sep 9, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The expense is removed immediately when delete it in offline mode
What is the root cause of that problem?
We already avoid filtering out the pending delete transaction in
visibleTransactions, but it's filtered out ingetAllNonDeletedTransactionsApp/src/pages/home/ReportScreen.tsx
Lines 308 to 315 in a24b0c0
Then the one transaction view appears because we only have one transaction.
What changes do you think we should make in order to solve the problem?
We should introduce
isOfflineparameter ingetAllNonDeletedTransactionsfunction, and don't filter out the transaction if it's pending delete or the iou action related to this one is pending delete. If we always want to keep the pending delete transaction, we can do the logic withoutisOfflineparam. Small improvement can be done in the PR.And then we pass
isOfflinetogetAllNonDeletedTransactionshere.App/src/pages/home/ReportScreen.tsx
Lines 308 to 315 in a24b0c0
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Test
getAllNonDeletedTransactionsfunction and verify that this function keep the pending delete transaction whenisOfflineparameter istrue.What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
dmkt9 commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The expense is removed immediately when delete it in offline mode
What is the root cause of that problem?
Because the
getAllNonDeletedTransactionsfunction filters out transactions that are pending deletion, even thoughvisibleTransactionshas an exception for offline mode, those pending-deletion transactions are still excluded from the list:App/src/libs/MoneyRequestReportUtils.ts
Lines 74 to 82 in 32cf88b
App/src/pages/home/ReportScreen.tsx
Lines 308 to 313 in 32cf88b
What changes do you think we should make in order to solve the problem?
We should allow transactions with pending deletion actions to pass through
getAllNonDeletedTransactions, and defer the filtering logic tovisibleTransactions.App/src/libs/MoneyRequestReportUtils.ts
Line 79 in 32cf88b
Note: It may be worth reviewing all usages of
getAllNonDeletedTransactionsand adjusting them accordingly if needed.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add test coverage for
getAllNonDeletedTransactions.What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Chat-Delete expense in offline remove them immediately instead of grey out[/-][+][$250] Chat-Delete expense in offline remove them immediately instead of grey out[/+]melvin-bot commentedon Sep 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021965420260416143565
melvin-bot commentedon Sep 9, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)suneox commentedon Sep 10, 2025
@nkdengineer proposal LGTM
🎀 👀 🎀 C+ reviewed
23 remaining items
melvin-bot commentedon Oct 2, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 2, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 2, 2025
@suneox @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Oct 12, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/65247/files#r2424620671
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: It isn't an impactful bug
bfitzexpensify commentedon Oct 14, 2025
@nkdengineer please accept the Upwork job offer.
Payment summary:
@suneox due $250 via NewDot Manual Requests
@nkdengineer due $250 via Upwork
nkdengineer commentedon Oct 15, 2025
@bfitzexpensify I will get paid via NewDot
bfitzexpensify commentedon Oct 15, 2025
OK, great.
Payment summary:
@nkdengineer due $250 via NewDot Manual Requests
twisterdotcom commentedon Oct 26, 2025
@suneox has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-5f58-a12d-b7de-5c89bf6996b1JmillsExpensify commentedon Nov 4, 2025
$250 approved for @nkdengineer