Skip to content

[Due for payment 2025-10-03] [Due for payment 2025-10-01] [$250] [Duplicate policy] Better error handling when duplicating workspace fails #70290

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

  1. Have a workspace where you are admin but not the owner
  2. Make sure this workspace has a lot of categories and tags and members
  3. Try to duplicate this workspace
  4. Navigate to the duplicated workspace settings

Expected Result:

Describe what you think should've happened

When this action fails, we should show the RBR on the left had side of the settings under More features, that will clear the workspace when dismissed

Right now the error only shows in the categories:

Image

and the requests are failing

Image

Actual Result:

Describe what actually happened

We should add a RBR error under the more features tab that will explain the error and let the user clear it

Image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021968043468136655861
  • Upwork Job ID: 1968043468136655861
  • Last Price Increase: 2025-09-16
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 10, 2025
  2. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. DylanDylann commented on Sep 10, 2025

    @DylanDylann
    Contributor

    @mountiny Could I help on this issue too?

  4. mountiny commented on Sep 10, 2025

    @mountiny
    ContributorAuthor

    nothing needed right now but maybe once we will have something for you to work on

  5. stitesExpensify commented on Sep 12, 2025

    @stitesExpensify
    Contributor

    For the backend bug, I'm looking at the logs here

    We are getting 300 which means the account already exists, but then getting an error when we try to get an authToken for that same account which is weird. I'm guessing it's because we're using the email instead of the accountID. Still digging

  6. stitesExpensify commented on Sep 12, 2025

    @stitesExpensify
    Contributor

    Okay so the issue is actually this line combined with this change https://github.com/Expensify/Web-Expensify/blame/main/_libfop.php#L476.

    CreateAccount doesn't return email if it returns a 300.

  7. stitesExpensify commented on Sep 12, 2025

    @stitesExpensify
    Contributor

    I don't actually thing that is the issue :/ We do always get an email even if it is not from the command directly.

    It is also not a problem with the primary email vs secondary email. I think I need to find some more logs

  8. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Sep 15, 2025
  9. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    @CortneyOfstad, @narefyev91, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. 31 remaining items

  11. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.18-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-03. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    @shubham1206agra @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. CortneyOfstad commented on Oct 2, 2025

    @CortneyOfstad
    Contributor

    @shubham1206agra can you complete the checklist before EOD? Thanks!

  14. stitesExpensify commented on Oct 7, 2025

    @stitesExpensify
    Contributor
  15. shubham1206agra commented on Oct 7, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/69146/files#r2411066170

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    There are no particular test steps as it is difficult to induce BE error state naturally.

    Do we agree 👍 or 👎

  16. CortneyOfstad commented on Oct 7, 2025

    @CortneyOfstad
    Contributor

    Payment Summary

    @shubham1206agra – to be paid $250 via NewDot
    @narefyev91 — contracted

    Payment Summary

    Per comment here, test is not needed

  17. JmillsExpensify commented on Oct 21, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions