Repository navigation
Room - App crashed in IOS after tap on Room name to view details after creating a Policy Room #7055
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #6737
Action Performed:
- Launch the app and login
- Tap the global create + button and choose New Room
- Name it something and select your workspace
- After room created Tap on Room name to view details
Expected Result:
Room details displayed
Actual Result:
App crashed
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web - Blank screen
- iOS - App crashes
- Android - Blank screen
- Desktop App - Blank screen
- Mobile Web - Blank screen
Bug5396686_RPReplay_Final1641435006.mp4
Version Number: 1.1.26 -0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
In production blank page appears with page title "Detail" where as in staging blank page appears in all other environments except iOS app
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
OSBotify commentedon Jan 6, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Jan 6, 2022
Triggered auto assignment to @pecanoro (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]Room - Blank page displayed for the room details, app crashed in IOS[/-][+]Room - App crashed in IOS after tap on Room name to view details[/+]mvtglobally commentedon Jan 6, 2022
@pecanoro We made it a deploy blocker since the IOS crash is only repro in Staging, while Blank page in other requirements is repro in Prod today
francoisl commentedon Jan 6, 2022
@TomatoToaster any idea what could be causing this, in regards to #6737?
TomatoToaster commentedon Jan 6, 2022
Looking into this now, trying to recreate locally 👀
francoisl commentedon Jan 6, 2022
I can't reproduce on
main, going to try from1.1.26-0specifically.kavimuru commentedon Jan 7, 2022
@TomatoToaster Issue is still reproducible in all the environments in the build 1.1.26 -1. PR #7065 is failing still.
Note: If the New room created in another workspace where user is a member then it works fine. Attaching the video too
IMG_9364.mp4
.
TomatoToaster commentedon Jan 7, 2022
Hmm I see, thanks for the video! I'm able to recreate this too. But it seems like it works AFTER you've crashed and log back into the app right? I've got it to show me a policy room with 0 members that way.
This is how it should look for empty members:
Like it seems like the specific broken case is right after a policy room is created, it has no avatar, and it crashes after you try to look at room details, if you have no other members in the Workspace. The report must not be loading properly after it's created and is in some weird state, causing it to crash when the report details are clicked on.
Since this feature is in beta, and the app is usable after it crashes, I'm going to say this isn't a deployblocker but a daily we should be looking to fix (CC: @francoisl @jasperhuangg). I'll modify the issue body accordingly.
[-]Room - App crashed in IOS after tap on Room name to view details[/-][+]Room - App crashed in IOS after tap on Room name to view details after creating a Policy Room[/+]francoisl commentedon Jan 7, 2022
Sounds good to me. For the record, the beta flag is
defaultRooms, and there is no one other than internal testers on this beta yet.Let's maybe double-check that the crash doesn't occur for accounts that are not on the beta first?
TomatoToaster commentedon Jan 12, 2022
Still working on this. Was investigating a fix for this and haven't found it yet. What I know so far is we might have to rework how we add the new Chat Room Report "optimistically" because it seems to making incomplete report data.
TomatoToaster commentedon Jan 14, 2022
Got a draft that I think will address the icon issue for policy rooms which I think will fix the crash. I'm going to test a few platforms and scenarios (single member workspace, admin and user workspace, from user perspective).
mvtglobally commentedon Jan 25, 2022
Issue not reproducible during KI retests. (First week)