Skip to content

Reject violation is shown on Reports > Expenses for rejected and unreported expense #70587

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.14-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #62787
Email or phone of affected tester (no customers): sjdiojsdoinsjo@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Delayed submissions are disabled in Workflows settings
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create an expense in workspace chat
  4. Open expense report
  5. Click More > Reject
  6. Enter reason and click Reject expense
  7. Go to self DM
    → "This expense was rejected" violation is not shown on the expense preview in self DM
  8. Go to Reports > Expenses

Expected Result:

"This expense was rejected" violation will not be shown on the expense row on Reports > Expenses when the expense is rejected and unreported

Actual Result:

"This expense was rejected" violation is shown on the expense row on Reports > Expenses when the expense is rejected and unreported

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6945181_1757951482363.Screen_Recording_2025-09-15_at_23.47.26.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 15, 2025
  2. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 13 remaining items

  7. garrettmknight commented on Sep 22, 2025

    @garrettmknight
    Contributor

    Same as above.

  8. melvin-bot commented on Sep 25, 2025

    @melvin-bot

    @garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. garrettmknight commented on Sep 26, 2025

    @garrettmknight
    Contributor

    Same as above.

  10. garrettmknight commented on Sep 29, 2025

    @garrettmknight
    Contributor

    Same

  11. melvin-bot commented on Sep 29, 2025

    @melvin-bot

    @garrettmknight this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  12. garrettmknight commented on Oct 2, 2025

    @garrettmknight
    Contributor

    Ok, finally took a minute to test:

    • The violation is removed when the expenses is moved to selfDM/unreported
    • Since it takes manual action to move it onto a report, and we're implementing logic to remove the violation when the expense is edited, I think that's just fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions