Skip to content

[Due for payment 2025-09-26] [Due for payment 2025-09-23] Expense - Reject option appears for the second approver but the expense cannot be rejected #70608

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.14-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #62787
Email or phone of affected tester (no customers): jsodsjnoijsdos3@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a workspace with member and second admin.
  • Second admin is also a second approver.
  1. Go to staging.new.expensify.com
  2. [Member] Go to workspace chat.
  3. [Member] Create an expense.
  4. [Member] Click Submit on the expense preview.
  5. [Second approver] Open expense report submitted by member.
  6. [Second approver] Click More > Reject.
  7. [Second approver] Enter reason and click Reject expense.

Expected Result:

The expense will be rejected, or the reject option should not appear for the second approver.

Actual Result:

Reject option appears for the second approver but the expense cannot be rejected.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 15, 2025
  2. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 9 remaining items

  7. changed the title [-]Expense - Reject option appears for the second approver but the expense cannot be rejected[/-] [+][Due for payment 2025-09-23] Expense - Reject option appears for the second approver but the expense cannot be rejected[/+] on Sep 16, 2025
  8. melvin-bot commented on Sep 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.14-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @truph01 requires payment (Needs manual offer from BZ)
  9. melvin-bot commented on Sep 16, 2025

    @melvin-bot

    @mananjadhav / @truph01 @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. IuliiaHerets commented on Sep 16, 2025

    @IuliiaHerets

    Issue is not repro on Mac Chrome build 9.2.15-0 with Gmail account, no Reject option

    70608.mp4
  11. izarutskaya commented on Sep 17, 2025

    @izarutskaya

    Issue is not reproducible on Windows 11 / Chrome in v9.2.15-0 with Expensifail accounts. No Reject option on 6 step

    bandicam.2025-09-17.16-53-03-144.mp4
    Recording.3417.mp4
  12. mananjadhav commented on Sep 17, 2025

    @mananjadhav
    Collaborator

    @IuliiaHerets When we say the issue is not reproducible, I am assuming we're testing with beta enabled?

  13. garrettmknight commented on Sep 18, 2025

    @garrettmknight
    Contributor

    Retested on a beta enabled account, second approver can't see Reject anymore.

  14. changed the title [-][Due for payment 2025-09-23] Expense - Reject option appears for the second approver but the expense cannot be rejected[/-] [+][Due for payment 2025-09-26] [Due for payment 2025-09-23] Expense - Reject option appears for the second approver but the expense cannot be rejected[/+] on Sep 19, 2025
  15. melvin-bot commented on Sep 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.15-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-26. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @truph01 requires payment (Needs manual offer from BZ)
  16. melvin-bot commented on Sep 19, 2025

    @melvin-bot

    @mananjadhav / @truph01 @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions