Skip to content

[Due for payment 2025-11-17] Expense - Confirm modal shows "Delete expenses" when deleting the report #70728

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.15-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #70111
Email or phone of affected tester (no customers): dsjionsjosdijdso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses in the workspace chat.
  4. Open the expense report.
  5. Click More > Delete.

Expected Result:

The confirm modal will show "Delete report".

Actual Result:

The confirm modal shows "Delete expenses", which does not sound correct because the expenses are not deleted and they will move to self DM when deleting the entire report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 17, 2025
  2. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Sep 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MarioExpensify commented on Sep 17, 2025

    @MarioExpensify
    Contributor

    @zirgulis @mollfpr @alitoshmatov I believe this is a regression from #70111

    Can you guys take a look please?

  7. MarioExpensify commented on Sep 17, 2025

    @MarioExpensify
    Contributor

    @nyomanjyotisa I appreciate the proposal but we should follow up on the original PR before looking for other proposed solutions.

  8. alitoshmatov commented on Sep 17, 2025

    @alitoshmatov
    Contributor

    Yes looks like it is from our PR, @MarioExpensify please assign me. @zirgulis Can you create follow up PR?

  9. Beamanator commented on Sep 17, 2025

    @Beamanator
    Contributor

    CPing linked revert ^

  10. IuliiaHerets commented on Sep 17, 2025

    @IuliiaHerets

    Issue not repro anymore on Mac Chrome and Desktop, build 9.2.15-8

    KI.retest.3.mp4
    KI.retest.2.mp4
  11. Beamanator commented on Sep 17, 2025

    @Beamanator
    Contributor

    Niiice! Let's close this out @MarioExpensify ?

  12. MarioExpensify commented on Sep 17, 2025

    @MarioExpensify
    Contributor

    Reverts fixed!! Closing out and checking off!

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 10, 2025
  14. changed the title [-]Expense - Confirm modal shows "Delete expenses" when deleting the report[/-] [+][Due for payment 2025-11-17] Expense - Confirm modal shows "Delete expenses" when deleting the report[/+] on Nov 10, 2025
  15. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.47-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-17. 🎊

  17. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    @MarioExpensify @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions