You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-03] [$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report. #70741
Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.
Open the Expensify app.
Open any workspace chat.
Create at least two manual expenses.
Navigate to "Reports" > "Reports"
Note that no footer is displayed on section.
Open the report of the just created expenses.
Tap on "Submit"
Return to "Reports"
Note that footer with "Expenses" and "Total Spend" fields, appears and disappears.
Reopen report and tap on "Approve"
Return to "Reports"
Note that footer appears and disappears again.
Expected Result:
Footer on "Reports" section should not be briefly displayed when an expense is submitted, approved or paid via report.
Actual Result:
After submitting, approving or paying an expense via report, and returning to "Reports" section, footer with expenses information, appears and disappears.
What changes do you think we should make in order to solve the problem?
We need to use the same shouldCalculateTotals from Search/index component in MoneyReportHeader. To make it DRY, we can either create a util or a hook (useSearchShouldCalculateTotals). Every data can be get from the SearchContext, except the offset.
But I don't think making the offset global is a good idea. Maybe we can check the offset only in Search/index file. Let me know which one is preferable.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
changed the title [-]Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/-][+][$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/+]on Sep 22, 2025
changed the title [-][$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/-][+][Due for payment 2025-11-03] [$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/+]on Oct 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.38-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allroundexperts / @bernhardoj@trjExpensify / @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Sep 17, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Sep 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Total footer shown briefly after submit, approve, or pay report.
What is the root cause of that problem?
When we submit, approve, or pay, we trigger the search API and pass the
shouldCalculateTotalsas true.App/src/components/MoneyReportHeader.tsx
Lines 417 to 420 in 24fe08c
When we go back, another search API is triggered with
shouldCalculateTotalsas false, as decided here.App/src/components/Search/index.tsx
Lines 269 to 303 in 24fe08c
What changes do you think we should make in order to solve the problem?
We need to use the same
shouldCalculateTotalsfromSearch/indexcomponent in MoneyReportHeader. To make it DRY, we can either create a util or a hook (useSearchShouldCalculateTotals). Every data can be get from the SearchContext, except the offset.App/src/components/Search/index.tsx
Lines 269 to 272 in 24fe08c
To fix that, we can move the offset state to the SearchContext and name it
currentOffset.App/src/components/Search/index.tsx
Line 242 in 24fe08c
We can reset the offset here.
App/src/components/Search/index.tsx
Lines 316 to 329 in 24fe08c
But I don't think making the offset global is a good idea. Maybe we can check the offset only in Search/index file. Let me know which one is preferable.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
[-]Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/-][+][$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/+]melvin-bot commentedon Sep 22, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021970237779916738167
melvin-bot commentedon Sep 22, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)38 remaining items
[-][$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/-][+][Due for payment 2025-11-03] [$250] Reports - Footer on "Reports", is briefly shown when submitting, approving or paying report.[/+]melvin-bot commentedon Oct 27, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.38-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 27, 2025
@allroundexperts / @bernhardoj @trjExpensify / @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allroundexperts commentedon Nov 3, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/68770/files#r2487961951
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify there is no Reports footer shows briefly
Do we agree 👍 or 👎
melvin-bot commentedon Nov 3, 2025
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Nov 4, 2025
Caught from an existing test case. Payment summary as follows:
Go ahead and request. Closing!
bernhardoj commentedon Nov 4, 2025
Requested in ND.
garrettmknight commentedon Nov 21, 2025
$250 approved for @bernhardoj
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.
garrettmknight commentedon Jan 5, 2026
Payment summary here is correct