Repository navigation
Description
Holding on #66064 to implement for both % and amounts.
In Classic, when a user splits an expense, we try to update the amounts for all splits to equal the amount of the original transaction automatically. We opted to go a simpler route with NewDot splits to start, avoiding any automatic updates, and punted adding this logic to a follow-up. This is that follow-up:
Problem: When users are editing the separate portions of a split they are typically trying to ensure all the portions add up to the original transaction amount.
Solution: Automatically change amounts and percentages when creating a split to add up to the original transaction amount to remove clicks/steps for the submitter. To do so, we'll implement our Classic logic:
Core logic:
- Default/unmodified values adjust automatically: Any split that hasn't been manually edited (i.e., still at its default value) will auto-adjust evenly so that all splits add up to 100% (for percentages) or the total amount (for amounts).
- Edited values are preserved: Once a user manually edits a percentage (or amount), that value is “locked in” and will never be auto-updated.
- Editing an initial split will preserve all Split values: We've added the ability to edit existing splits in NewDot and the individaul splits of an expense may be on different reports and in different states. To avoid complexity, when a user edits an amount or percentage on an existing split, we treat all splits as manually edited and stop auto-adjusting them.
Behavior for Adding Splits
- When a new split is added: Instead of defaulting to 0%, the system will redistribute all unedited splits automatically so they balance out to 100%.
Simple adding splits Example:
- Submitter taps More > Split on a $10 expense
- Two initial splits exist at 50/50 = $5/$5
- Submitter taps 'Add split'
- A third split is added and the amounts are updated to 33%/33%/34% = $3.33/$3.33/$3.34
Further editing example:
- Submitter taps More > Split on a $10 expense
- Two initial splits exist at 50/50 = $5/$5
- Submitter edits Split A to $3.
- Split B automatically updates to $7
- Submitter taps 'Add split'
- A third split is added. A remains $3, B updates to $3.50, the new split C is added as $3.50.
Error handling:
- Users can still manually override and push totals over/under 100%.
- In those cases, the same existing error message for invalid totals will be shown.
Issue Owner
Current Issue Owner: @CortneyOfstadUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022026960234846731129
- Upwork Job ID: 2026960234846731129
- Last Price Increase: 2026-02-26
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
garrettmknight commentedon Oct 2, 2025
Still holding on Split by.
garrettmknight commentedon Oct 17, 2025
Still holding on Split by.
garrettmknight commentedon Oct 27, 2025
Still holding on Split by, but we're getting closer.
garrettmknight commentedon Nov 5, 2025
Split by should be done in a few weeks, then we'll get this going.
90 remaining items
melvin-bot commentedon Feb 26, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022026960234846731129
[-][Due for payment 2026-02-23] Update Split table logic to update amounts/percentages to match the original transaction amount[/-][+][$250] [Due for payment 2026-02-23] Update Split table logic to update amounts/percentages to match the original transaction amount[/+]ShridharGoel commentedon Feb 26, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
i) After clearing to just -, type a complete number like -50 and verify the redistribution works correctly
ii) Test with positive amounts as well to ensure normal functionality is not affected
Do we agree 👍 or 👎
ikevin127 commentedon Feb 27, 2026
@garrettmknight Please have me assigned to that issue and I'll proceed with the implementation as soon as that's done.
↪️ In the meantime, mind dropping a payment summary here so we can request the overdue 23rd payments ? I think $250 is fair even though we had some regressions because the work was quite comlpex 🙌
ShridharGoel commentedon Feb 27, 2026
Kindly assign me as well on the new issue, thanks
CortneyOfstad commentedon Feb 27, 2026
Payment Summary
@ShridharGoel — to be paid $250 via NewDot
@ikevin127 — to be paid $250 via NewDot
Regression Test
https://github.com/Expensify/Expensify/issues/605192
JmillsExpensify commentedon Feb 28, 2026
$250 approved for @ShridharGoel
garrettmknight commentedon Mar 2, 2026
$250 approved for @ikevin127