Skip to content

[HOLD for payment 2022-01-21] Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia #7093

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. open app
  2. Navigate to Settings > Profile
  3. Make any changes in the profile and hit "Enter" key (nothing happens)
  4. Select "Add phone number"
  5. Enter Password
  6. Enter any phone and hit "Enter" key

The "Password" input does save on "Enter" key, but the "Phone Number" doesn't.

Expected Result:

User should be able to save changes on Enter

Actual Result:

Pressing "Enter" does not submit the form.

Workaround:

The user can just click/tap on the "Save" button

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.26-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Profile form:

Screen.Recording.2022-01-04.at.11.42.57.PM.mov

Phone number form:

Screen.Recording.2022-01-10.at.10.17.40.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640962448344000

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Jan 8, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. sobitneupane commented on Jan 8, 2022

    @sobitneupane
    Contributor

    Prosposal
    We should add pressOnEnter props in following two buttons to solve the issue.

    <Button
    success
    isDisabled={isButtonDisabled}
    onPress={this.updatePersonalDetails}
    style={[styles.w100]}
    text={this.props.translate('common.save')}
    />

    <Button
    success
    isDisabled={this.validateForm()}
    isLoading={this.props.user.loading}
    text={this.props.translate('addSecondaryLoginPage.sendValidation')}
    onPress={this.submitForm}
    />

  3. thesahindia commented on Jan 8, 2022

    @thesahindia
    Member

    Proposal

    I reported this issue so proposing a solution to fix this.
    We need to pass pressOnEnter in Button on Secondary login page and Profile page

  4. changed the title [-]Can't submit the changes via the enter on profile & Phone number page - reported by @thesahindia[/-] [+]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+] on Jan 10, 2022
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 10, 2022
  6. MelvinBot commented on Jan 10, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  7. removed their assignment
    on Jan 10, 2022
  8. 12 remaining items

  9. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 10, 2022
  10. MelvinBot commented on Jan 10, 2022

    @MelvinBot
    Contributor

    📣 @thesahindia You have been assigned to this job by @puneetlath!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  11. luish00 commented on Jan 11, 2022

    @luish00

    i think that you need add event onSubmitEditing toTextInput phone on ./pages/settings/AddSecondaryLoginPage.js

  12. rushatgabhane commented on Jan 11, 2022

    @rushatgabhane
    Member

    Hi @luish00 thanks for your input! Using pressOnEnter is a cleaner solution.
    And a proposal that works has already been accepted.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 14, 2022
  14. botify commented on Jan 14, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.29-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-21. 🎊

  15. changed the title [-]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/-] [+][HOLD for payment 2022-01-21] Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+] on Jan 14, 2022
  16. mallenexpensify commented on Jan 22, 2022

    @mallenexpensify
    Contributor

    Paid @thesahindia $500 - $250 for job and $250 for reporting.
    @thesahindia in the future, can you not add the milestone to denote that you're due more $$$, with our current process it's likely to confuse a Contributor Manager (CM) when they see. If for some reason you're not properly compensated for an issue, you can comment on it and the CM can rectify it.

    @rushatgabhane can you apply here for C+ payment? https://www.upwork.com/jobs/~0133553ac0051c6374

  17. rushatgabhane commented on Jan 22, 2022

    @rushatgabhane
    Member

    Thanks!

  18. puneetlath commented on Jan 22, 2022

    @puneetlath
    Contributor

    @thesahindia in the future, can you not add the milestone to denote that you're due more $$$, with our current process it's likely to confuse a Contributor Manager (CM) when they see.

    Ah, I think this was actually me. I tend to do this so that I don't forget, but I'm happy to stop doing it if that is confusing with our process.

  19. mallenexpensify commented on Jan 22, 2022

    @mallenexpensify
    Contributor

    hahahahah, I'm sorry @puneetlath , I def stepped on your toes. If it helps you Puneet, then keep on doing it. I was trying to get payments issued before the weekend cuz of Upwork's 5-day hold time.

    @rushatgabhane I hired you, please accept and @puneetlath will pay next week. :)

  20. puneetlath commented on Jan 22, 2022

    @puneetlath
    Contributor

    No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions