You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-01-21] Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia #7093
changed the title [-]Can't submit the changes via the enter on profile & Phone number page - reported by @thesahindia[/-][+]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+]on Jan 10, 2022
📣 @thesahindia You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.29-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/-][+][HOLD for payment 2022-01-21] Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+]on Jan 14, 2022
Paid @thesahindia $500 - $250 for job and $250 for reporting. @thesahindia in the future, can you not add the milestone to denote that you're due more $$$, with our current process it's likely to confuse a Contributor Manager (CM) when they see. If for some reason you're not properly compensated for an issue, you can comment on it and the CM can rectify it.
@thesahindia in the future, can you not add the milestone to denote that you're due more $$$, with our current process it's likely to confuse a Contributor Manager (CM) when they see.
Ah, I think this was actually me. I tend to do this so that I don't forget, but I'm happy to stop doing it if that is confusing with our process.
hahahahah, I'm sorry @puneetlath , I def stepped on your toes. If it helps you Puneet, then keep on doing it. I was trying to get payments issued before the weekend cuz of Upwork's 5-day hold time.
Activity
MelvinBot commentedon Jan 8, 2022
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.sobitneupane commentedon Jan 8, 2022
Prosposal
We should add pressOnEnter props in following two buttons to solve the issue.
App/src/pages/settings/Profile/ProfilePage.js
Lines 274 to 280 in 6067100
App/src/pages/settings/AddSecondaryLoginPage.js
Lines 150 to 156 in 6067100
thesahindia commentedon Jan 8, 2022
Proposal
I reported this issue so proposing a solution to fix this.
We need to pass
pressOnEnterinButtonon Secondary login page and Profile page[-]Can't submit the changes via the enter on profile & Phone number page - reported by @thesahindia[/-][+]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+]MelvinBot commentedon Jan 10, 2022
Triggered auto assignment to @puneetlath (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.12 remaining items
MelvinBot commentedon Jan 10, 2022
📣 @thesahindia You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
luish00 commentedon Jan 11, 2022
i think that you need add event
onSubmitEditingtoTextInputphone on./pages/settings/AddSecondaryLoginPage.jsrushatgabhane commentedon Jan 11, 2022
Hi @luish00 thanks for your input! Using
pressOnEnteris a cleaner solution.And a proposal that works has already been accepted.
botify commentedon Jan 14, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.29-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-21. 🎊
[-]Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/-][+][HOLD for payment 2022-01-21] Can't submit the changes by pressing 'Enter' key on profile & Phone number page - reported by @thesahindia[/+]mallenexpensify commentedon Jan 22, 2022
Paid @thesahindia $500 - $250 for job and $250 for reporting.
@thesahindia in the future, can you not add the milestone to denote that you're due more $$$, with our current process it's likely to confuse a Contributor Manager (CM) when they see. If for some reason you're not properly compensated for an issue, you can comment on it and the CM can rectify it.
@rushatgabhane can you apply here for C+ payment? https://www.upwork.com/jobs/~0133553ac0051c6374
rushatgabhane commentedon Jan 22, 2022
Thanks!
puneetlath commentedon Jan 22, 2022
Ah, I think this was actually me. I tend to do this so that I don't forget, but I'm happy to stop doing it if that is confusing with our process.
mallenexpensify commentedon Jan 22, 2022
hahahahah, I'm sorry @puneetlath , I def stepped on your toes. If it helps you Puneet, then keep on doing it. I was trying to get payments issued before the weekend cuz of Upwork's 5-day hold time.
@rushatgabhane I hired you, please accept and @puneetlath will pay next week. :)
puneetlath commentedon Jan 22, 2022
No worries!