Skip to content

Investigate workflow job failing on main: lint / ESLint check #71090

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: lint / ESLint check
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @mateuuszzzzz
  • 🤝 Merged by: @Julesssss
  • 🐛 Error Message:
    failure: Process completed with exit code 1.
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
    warning: Cache not found for keys: Linux-node-modules-2e8ab53d8778c39a3d19e1eaf983aeec43f2ca3dbcfe6deb9741a8a8ba91fea0

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named lint / ESLint check.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Activity

  1. Julesssss commented on Sep 23, 2025

    @Julesssss
    Contributor

    We allow 183 warnings for the deprecated Onyx.connect(), but after the PR we merged there are now 184. I think the fix is to bump max warnings to 184, because the PR did not introduce this error:

    But the better fix is probably to resolve this lint error, do you want to do that?

    /home/runner/work/App/App/src/pages/workspace/accounting/PolicyAccountingPage.tsx
    Warning:   395:8  warning  React Hook useMemo has an unnecessary dependency: 'theme.spinner'. Either exclude it or remove the dependency array  react-hooks/exhaustive-deps
    
  2. Julesssss commented on Sep 23, 2025

    @Julesssss
    Contributor

    Resolved here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions