Skip to content

Android build failing after RN upgrade #7111

Closed

Description

@Jag96

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Run the deploy

Expected Result:

Android builds successfully

Actual Result:

Fastlane failed with the following error:

Execution failed for task ':app:mergeReleaseAssets'.
> Could not resolve all files for configuration ':app:releaseRuntimeClasspath'.
   > Could not find com.facebook.flipper:flipper-noop:0.66.0.

Original thread here: https://expensify.slack.com/archives/C03V9A4TB/p1641843892079000

Workaround:

None

Platform:

Where is this issue occurring?

  • Android

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 10, 2022
  2. self-assigned this
    on Jan 10, 2022
  3. OSBotify commented on Jan 10, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. MelvinBot commented on Jan 10, 2022

    @MelvinBot
    Contributor

    Current assignee @Jag96 is eligible for the Engineering assigner, not assigning anyone new.

  5. added and removed on Jan 10, 2022
  6. Jag96 commented on Jan 10, 2022

    @Jag96
    ContributorAuthor

    Looks like setting the noop version for Flipper for release builds will fix the issue:

    releaseImplementation "com.facebook.flipper:flipper-noop:${FLIPPER_VERSION}"
    

    Still looking into what actually caused this error just to confirm there aren't any other steps required for this fix.

    The error specifies

    [18:53:09]: ▸ Required by:
    [18:53:09]: ▸ project :app > project :flipper-plugin-react-native-performance
    

    But that package didn't change in our project during the upgrade: https://github.com/Expensify/App/pull/6914/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L97

    We also have a separate package included for flipper-plugin-react-native-performance, but looking at the npm page for that it seems to be deprecated.

    That package was introduced in #4760, so going to see if removing it fixes the issue and passes the tests on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions