You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-13] Enter your credentials menu item shows when there's no need. #71195
We're showing the "Enter your credentials" menu item when the connection isn't broken, which is somewhat unnecessary.
In the doc we said:
Should the connection fail or credentials become invalidated, we’ll re-use the RBR pattern we have for accounting integrations. Within the popover menu, an option to Enter your credentials will be included to navigate to Uber to reconnect
Please re-state the problem that we are trying to solve in this issue.
The "Enter your credentials" menu item is being shown for Uber receipt partner connections even when the connection is working properly and credentials are valid.
What is the root cause of that problem?
The receipt partner implementation doesn't check for authentication errors before showing the "Enter your credentials" menu item
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Alternatively, we can focus on authentication error message instead of uber enabled check
constisUberAuthenticationError=useCallback(()=>{constuberConnection=policy?.receiptPartners?.uber;// Check if there are any authentication-related errorsconsthasAuthenticationErrors=uberConnection?.errors ? Object.values(uberConnection.errors).some((error)=>error?.toLowerCase()?.includes('authentication')) : false;// Check if there are any authentication-related error fieldsconsthasAuthenticationErrorFields=uberConnection?.errorFields ? Object.keys(uberConnection.errorFields).some((field)=>field.toLowerCase().includes('authentication')) : false;returnhasAuthenticationErrors??hasAuthenticationErrorFields;},[policy?.receiptPartners?.uber]);
@narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.
Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:
Red dot on the Workspaces tab in the LHB/Bottom Tab Bar
Red dot on the workspace that contains the error in the list of workspaces
Red dot on the Receipt partners menu item in the LHN of the workspace settings
Red dot next to the three dots in the Uber connection card
Red error message in the Uber connection card.
Yeah i will add logic for RBR as a part of this issue. Unfortunately could not link PR to #71241 in case it was initially by Artem (could not edit description). Anyway RBR will be covered here
Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.
Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.
changed the title [-]`Enter your credentials` menu item shows when there's no need.[/-][+][Due for payment 2025-10-13] `Enter your credentials` menu item shows when there's no need.[/+]on Oct 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Sep 24, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
mukhrr commentedon Sep 25, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Enter your credentials" menu item is being shown for Uber receipt partner connections even when the connection is working properly and credentials are valid.
What is the root cause of that problem?
The receipt partner implementation doesn't check for authentication errors before showing the "Enter your credentials" menu item
App/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx
Lines 115 to 128 in 5edc01d
What changes do you think we should make in order to solve the problem?
We have already a check if uber is connected or not:
App/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx
Line 54 in 5edc01d
So we can show the option conditionally here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Alternatively, we can focus on authentication error message instead of uber enabled check
trjExpensify commentedon Sep 25, 2025
Ah, sorry @mukhrr. We have a project team on this one, @narefyev91 is working on the PR already. 👍
trjExpensify commentedon Sep 29, 2025
@narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.
Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:
Workspacestab in the LHB/Bottom Tab BarReceipt partnersmenu item in the LHN of the workspace settingsnarefyev91 commentedon Sep 30, 2025
Yeah i will add logic for RBR as a part of this issue. Unfortunately could not link PR to #71241 in case it was initially by Artem (could not edit description). Anyway RBR will be covered here
trjExpensify commentedon Sep 30, 2025
Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.
narefyev91 commentedon Oct 1, 2025
Today plan to open PR
[-]`Enter your credentials` menu item shows when there's no need.[/-][+][Due for payment 2025-10-13] `Enter your credentials` menu item shows when there's no need.[/+]melvin-bot commentedon Oct 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 6, 2025
@dukenv0307 @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
trjExpensify commentedon Oct 13, 2025
Payments will be handled centrally, going to close this.