Skip to content

[Due for payment 2025-10-13] Enter your credentials menu item shows when there's no need. #71195

Closed

Description

@trjExpensify

Coming from here.

We're showing the "Enter your credentials" menu item when the connection isn't broken, which is somewhat unnecessary.

Image

In the doc we said:

Should the connection fail or credentials become invalidated, we’ll re-use the RBR pattern we have for accounting integrations. Within the popover menu, an option to Enter your credentials will be included to navigate to Uber to reconnect

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 24, 2025
  2. melvin-bot commented on Sep 24, 2025

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. mukhrr commented on Sep 25, 2025

    @mukhrr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "Enter your credentials" menu item is being shown for Uber receipt partner connections even when the connection is working properly and credentials are valid.

    What is the root cause of that problem?

    The receipt partner implementation doesn't check for authentication errors before showing the "Enter your credentials" menu item

    (integration: string) => {
    switch (integration) {
    case CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER:
    return [
    {
    icon: Expensicons.Key,
    text: translate('workspace.accounting.enterCredentials'),
    onSelected: () => startIntegrationFlow({name: CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER}),
    shouldCallAfterModalHide: true,
    disabled: isOffline,
    iconRight: Expensicons.NewWindow,
    },
    {
    icon: Expensicons.Trashcan,

    What changes do you think we should make in order to solve the problem?

    We have already a check if uber is connected or not:

    const isUberConnected = useIsPolicyConnectedToUberReceiptPartner({policyID});

    So we can show the option conditionally here

                        return [
                            ...(!isUberConnected
                                ? [
                                      {
                                          icon: Expensicons.Key,
                                          text: translate('workspace.accounting.enterCredentials'),
                                          onSelected: () => startIntegrationFlow({name: CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER}),
                                          shouldCallAfterModalHide: true,
                                          disabled: isOffline,
                                          iconRight: Expensicons.NewWindow,
                                      },
                                  ]
                                : []),

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Alternatively, we can focus on authentication error message instead of uber enabled check

    const isUberAuthenticationError = useCallback(() => {
            const uberConnection = policy?.receiptPartners?.uber;
    
            // Check if there are any authentication-related errors
            const hasAuthenticationErrors = uberConnection?.errors ? Object.values(uberConnection.errors).some((error) => 
                error?.toLowerCase()?.includes('authentication')
            ) : false;
            // Check if there are any authentication-related error fields
            const hasAuthenticationErrorFields = uberConnection?.errorFields ? Object.keys(uberConnection.errorFields).some((field) => 
                field.toLowerCase().includes('authentication')
            ) : false;
            return hasAuthenticationErrors ?? hasAuthenticationErrorFields;
        }, [policy?.receiptPartners?.uber]);
  4. trjExpensify commented on Sep 25, 2025

    @trjExpensify
    ContributorAuthor

    Ah, sorry @mukhrr. We have a project team on this one, @narefyev91 is working on the PR already. 👍

  5. trjExpensify commented on Sep 29, 2025

    @trjExpensify
    ContributorAuthor

    @narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.

    Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:

    1. Red dot on the Workspaces tab in the LHB/Bottom Tab Bar
    2. Red dot on the workspace that contains the error in the list of workspaces
    3. Red dot on the Receipt partners menu item in the LHN of the workspace settings
    4. Red dot next to the three dots in the Uber connection card
    5. Red error message in the Uber connection card.
  6. narefyev91 commented on Sep 30, 2025

    @narefyev91
    Contributor

    @narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.

    Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:

    1. Red dot on the Workspaces tab in the LHB/Bottom Tab Bar
    2. Red dot on the workspace that contains the error in the list of workspaces
    3. Red dot on the Receipt partners menu item in the LHN of the workspace settings
    4. Red dot next to the three dots in the Uber connection card
    5. Red error message in the Uber connection card.

    Yeah i will add logic for RBR as a part of this issue. Unfortunately could not link PR to #71241 in case it was initially by Artem (could not edit description). Anyway RBR will be covered here

  7. trjExpensify commented on Sep 30, 2025

    @trjExpensify
    ContributorAuthor

    Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.

  8. narefyev91 commented on Oct 1, 2025

    @narefyev91
    Contributor

    Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.

    Today plan to open PR

  9. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 1, 2025
  10. changed the title [-]`Enter your credentials` menu item shows when there's no need.[/-] [+][Due for payment 2025-10-13] `Enter your credentials` menu item shows when there's no need.[/+] on Oct 6, 2025
  11. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @narefyev91 does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  13. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    @dukenv0307 @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. trjExpensify commented on Oct 13, 2025

    @trjExpensify
    ContributorAuthor

    Payments will be handled centrally, going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions