[$250] Track - Whisper options appears on workspace chat when Share it with your accountant

@twisterdotcom

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.17-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-898/folder/13176877/41237356/912950916
Email or phone of affected tester (no customers): applausetester+gm1038177@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Other

Action Performed:

Preconditions:

User have no workspace

Steps:

Go to old dot> Login with Expensifail account> Create unreported manual expense
Go to staging.new.expensify.com> Login with same account
Go to Self DM chat> Create expense
From the whisper options select Share it with your accountant
Select an accountant> Complete the process
Verify that the transaction is moved to the new workspace

Expected Result:

There should be no whisper options on workspace chat expense

Actual Result:

Whisper options appears on workspace chat when Share it with your accountant

Workaround:

Unknown

Platforms:

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021970973512761844896
Upwork Job ID: 1970973512761844896
Last Price Increase: 2025-10-01
Automatic offers:

mkzie2 | Contributor | 109029849

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Whisper options (including "Share it with your accountant") incorrectly appear on workspace chat expenses when they should be hidden.

What is the root cause of that problem?

The isActionableTrackExpense logic in PureReportActionItem.tsx shows whisper options for all actionable track expense actions without checking if the current report is a workspace chat
The code lacks a condition to differentiate between workspace chats (POLICY_EXPENSE_CHAT) and regular chats when determining whether to display whisper options

What changes do you think we should make in order to solve the problem?

Add a check using isPolicyExpenseChat(report) under this line to return an empty array when the report is a workspace chat to prevent whisper options from appearing

       if (isPolicyExpenseChat(report)) {
                return [];
            }

POC

Screen.Recording.2025-09-25.at.01.45.22.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test should not show whisper options for actionable track expense in workspace chat:

 describe('Actionable track expense whisper options', () => {
        it('should not show whisper options for actionable track expense in workspace chat', async () => {
            const action = createReportAction(CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_TRACK_EXPENSE_WHISPER, {
                transactionID: '12345',
            });

            // Create a workspace chat report (policy expense chat)
            const workspaceReport = {
                reportID: '123',
                type: CONST.REPORT.TYPE.CHAT,
                chatType: CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT,
                policyID: 'policy123',
            };

            renderItemWithAction(action, workspaceReport);
            await waitForBatchedUpdatesWithAct();

            expect(screen.queryByText(translateLocal('actionableMentionTrackExpense.submit'))).not.toBeOnTheScreen();
            expect(screen.queryByText(translateLocal('actionableMentionTrackExpense.share'))).not.toBeOnTheScreen();
            expect(screen.queryByText(translateLocal('actionableMentionTrackExpense.categorize'))).not.toBeOnTheScreen();
            expect(screen.queryByText(translateLocal('actionableMentionTrackExpense.nothing'))).not.toBeOnTheScreen();
        });

        it('should show whisper options for actionable track expense in regular chat', async () => {
            const action = createReportAction(CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_TRACK_EXPENSE_WHISPER, {
                transactionID: '12345',
            });

            const regularReport = {
                reportID: '123',
                type: CONST.REPORT.TYPE.CHAT,
                chatType: CONST.REPORT.CHAT_TYPE.SELF_DM,
            };

            renderItemWithAction(action, regularReport);
            await waitForBatchedUpdatesWithAct();

            expect(screen.getByText(translateLocal('actionableMentionTrackExpense.submit'))).toBeOnTheScreen();
            expect(screen.getByText(translateLocal('actionableMentionTrackExpense.nothing'))).toBeOnTheScreen();
        });
    });

What alternative solutions did you explore? (Optional)

NA

Job added to Upwork: https://www.upwork.com/jobs/~021970973512761844896

@Pujan92

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Whisper options appears on workspace chat when Share it with your accountant

What is the root cause of that problem?

If the user has no workspace, a draft report is created when share it with your accountant. When retrieving participants, we're obtaining the report from Onyx.connect here, but it's not updated when the draft report is merged, resulting in an incorrect participant. We can see in the UI that an unavailable workspace is displayed on the confirmation page.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 256 to 266 in ffe38b1

    
           const participants = useMemo( 
        
               () => 
        
                   transaction?.participants?.map((participant) => { 
        
                       if (participant.isSender && iouType === CONST.IOU.TYPE.INVOICE) { 
        
                           return participant; 
        
                       } 
        
                       return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived); 
        
                   }) ?? [], 
        
               [transaction?.participants, iouType, personalDetails, reportAttributesDerived], 
        
           ); 
        
           const isPolicyExpenseChat = useMemo(() => participants?.some((participant) => participant.isPolicyExpenseChat), [participants]);

Then the actionableTrackExpenseWhisper is created because isPolicyExpenseChat is false.

App/src/libs/actions/IOU.ts

Lines 4002 to 4009 in ffe38b1

    
           if (!isPolicyExpenseChat) { 
        
               actionableTrackExpenseWhisper = buildOptimisticActionableTrackExpenseWhisper(iouAction, optimisticTransaction.transactionID); 
        
           } 
        
           // STEP 5: Build Onyx Data 
        
           const trackExpenseOnyxData = buildOnyxDataForTrackExpense({ 
        
               participant, 
        
               chat: {report: chatReport, previewAction: reportPreviewAction},

What changes do you think we should make in order to solve the problem?

We should pass the draft report to getReportOption

const [allReportDrafts] = useOnyx(ONYXKEYS.COLLECTION.REPORT_DRAFT, {canBeMissing: true});
const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
const getReportOrDraft = useCallback((id?: string) => allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${id}`] ?? allReportDrafts?.[`${ONYXKEYS.COLLECTION.REPORT_DRAFT}${id}`], [allReports, allReportDrafts]);
const participants = useMemo(
    () =>
        transaction?.participants?.map((participant) => {
            if (participant.isSender && iouType === CONST.IOU.TYPE.INVOICE) {
                return participant;
            }
            const reportOrDraft = getReportOrDraft(participant?.reportID ?? '');
            return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived, reportOrDraft);
        }) ?? [],
    [transaction?.participants, iouType, personalDetails, reportAttributesDerived, getReportOrDraft],
);
function getReportOption(participant: Participant, reportAttributesDerived?: ReportAttributesDerivedValue['reports'], reportOrDraft?: OnyxEntry<Report>): OptionData {
    const report = getReportOrDraftReport(participant.reportID) ?? reportOrDraft;

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 256 to 266 in ffe38b1

    
           const participants = useMemo( 
        
               () => 
        
                   transaction?.participants?.map((participant) => { 
        
                       if (participant.isSender && iouType === CONST.IOU.TYPE.INVOICE) { 
        
                           return participant; 
        
                       } 
        
                       return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived); 
        
                   }) ?? [], 
        
               [transaction?.participants, iouType, personalDetails, reportAttributesDerived], 
        
           ); 
        
           const isPolicyExpenseChat = useMemo(() => participants?.some((participant) => participant.isPolicyExpenseChat), [participants]);

After this issue is fixed, we still have another problem where the report name of the iouReport is incorrect.

The RCA is the policy is undefined here since it's draft

App/src/libs/ReportUtils.ts

Line 6227 in ffe38b1

const policy = getPolicy(policyID);

Then we can't get the title field here.

App/src/libs/ReportUtils.ts

Line 6262 in ffe38b1

    
           const titleReportField = getTitleReportField(getReportFieldsByPolicyID(policyID) ?? {});

To fix this issue

We need to add the title field for the draft workspace

fieldList: {
    [CONST.POLICY.FIELDS.FIELD_LIST_TITLE]: {
        defaultValue: CONST.POLICY.DEFAULT_REPORT_NAME_PATTERN,
        pendingFields: {defaultValue: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, deletable: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD},
        type: CONST.POLICY.DEFAULT_FIELD_LIST_TYPE,
        target: CONST.POLICY.DEFAULT_FIELD_LIST_TARGET,
        name: CONST.POLICY.DEFAULT_FIELD_LIST_NAME,
        fieldID: CONST.POLICY.FIELDS.FIELD_LIST_TITLE,
        deletable: true,
    },
},

App/src/libs/actions/Policy/Policy.ts

Line 2429 in ffe38b1

const optimisticData: OnyxUpdate[] = [

Add policy parameter to buildOptimisticExpenseReport function and pass it here

function buildOptimisticExpenseReport(
    chatReportID: string | undefined,
    policyID: string | undefined,
    payeeAccountID: number,
    total: number,
    currency: string,
    nonReimbursableTotal = 0,
    parentReportActionID?: string,
    optimisticIOUReportID?: string,
    reportPolicy?: OnyxEntry<Policy>,
) {
...
   const policyName = reportPolicy?.name ?? getPolicyName({report});
   const policy = reportPolicy ?? getPolicy(policyID);
   const titleReportField = getTitleReportField(policy?.fieldList ?? {});
   if (!!titleReportField && isPaidGroupPolicyPolicyUtils(policy)) {
        expenseReport.reportName = populateOptimisticReportFormula(titleReportField.defaultValue, expenseReport, policy);
    }
}

App/src/libs/ReportUtils.ts

Line 6262 in ffe38b1

    
           const titleReportField = getTitleReportField(getReportFieldsByPolicyID(policyID) ?? {});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@Pujan92

@Pujan92 Eep! 4 days overdue now. Issues have feelings too...

Blocked from reproducing this as "Share with accountant" option is not displayed, Tried both public and expensifail domain.
Windows 11 / chrome / v9.2.55-3

@aldo-expensify

Yes, it is disabled in PR. I think we need to wait until it is enabled again or else @aldo-expensify can verify in dev mode by enabling it in the code.

@aldo-expensify

@aldo-expensify Can you please check the comment above?

@cristipaval

Yes, it is disabled in PR. I think we need to wait until it is enabled again or else @aldo-expensify can verify in dev mode by enabling it in the code.

hmm, I'm understanding it is not certain that the functionality will be enabled again, if that is the case, maybe we should just close all this and pay for the work done. What do you think @cristipaval ?

I don't think it makes sense to spend effort on those flows. We disabled them for unlimited time.

Okay, if we're not recommending going ahead, let's close and pay out for anybody who has written a PR and anybody who has reviewed a PR anyway.

@twisterdotcom

In that case, @twisterdotcom can you plz add a payment summary and close the issue?

@Pujan92

Payment Summary:

@Pujan92 paid $250 via NewDot Requests
@mkzie2 paid $250 via Upwork here

@Pujan92

approved $250 for @Pujan92.

@twisterdotcom

@twisterdotcom @trjExpensify Hi, my account is not eligible for NewDot payment yet. Please handle payment via the existing Upwork contract.

Updated #71212 (comment)

Navigation Menu

Repository navigation

[$250] Track - Whisper options appears on workspace chat when Share it with your accountant #71212

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const participants = useMemo(
	() =>
	transaction?.participants?.map((participant) => {
	if (participant.isSender && iouType === CONST.IOU.TYPE.INVOICE) {
	return participant;
	}
	return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant, reportAttributesDerived);
	}) ?? [],
	[transaction?.participants, iouType, personalDetails, reportAttributesDerived],
	);
	const isPolicyExpenseChat = useMemo(() => participants?.some((participant) => participant.isPolicyExpenseChat), [participants]);

	if (!isPolicyExpenseChat) {
	actionableTrackExpenseWhisper = buildOptimisticActionableTrackExpenseWhisper(iouAction, optimisticTransaction.transactionID);
	}

	// STEP 5: Build Onyx Data
	const trackExpenseOnyxData = buildOnyxDataForTrackExpense({
	participant,
	chat: {report: chatReport, previewAction: reportPreviewAction},

[$250] Track - Whisper options appears on workspace chat when Share it with your accountant #71212

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 24, 2025

abzokhattab commented on Sep 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 24, 2025

melvin-bot commented on Sep 24, 2025

mkzie2 commented on Sep 25, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 29, 2025

48 remaining items

m-natarajan commented on Nov 12, 2025

Pujan92 commented on Nov 14, 2025

mkzie2 commented on Nov 23, 2025

aldo-expensify commented on Nov 25, 2025

cristipaval commented on Nov 25, 2025

twisterdotcom commented on Nov 25, 2025

Pujan92 commented on Nov 28, 2025

twisterdotcom commented on Nov 28, 2025

trjExpensify commented on Dec 1, 2025

mkzie2 commented on Jan 20, 2026

twisterdotcom commented on Jan 20, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions