You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-04] [Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace #71381
Version Number: 9.2.18-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dylanexpensify Slack conversation (hyperlinked to channel name): #expensify Bugs
Action Performed:
Sign up as a new user
Complete the personal details step
When prompted to join available workspaces, click Skip
On the next screen, select Track and budget expenses.
Expected Result:
The onboarding flow should show a screen asking if the member wants to create a workspace, User should be guided to set up a workspace before being dropped into the main chat.
Actual Result:
Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceRecording.1713.mp4
isPrivateDomainAndHasAccessiblePolicies check if user hasAccessibleDomainPolicies that they can join and if user skip the previous model to join a workspace we want to show create workspace option when they choose track expenses.
Add above logic before checking bellow condition that complete onboarding instantly for reming option other then MANAGE_TEAM and PERSONAL_SPEND if it's a private domain has accessible policies.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
So that navigation goes to ROUTES.ONBOARDING_PERSONAL_DETAILS, and since personal details are already filled, the existing logic in BaseOnboardingPersonalDetails correctly routes PERSONAL_SPEND users to the workspace creation screen
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-][+][$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+]on Sep 26, 2025
Hey @samranahm@mkzie2@lorretheboy , thanks for the proposals. Since you’ve already suggested the solutions, could you please help me reproduce the join available workspaces prerequisite?
changed the title [-][Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-][+][Due for payment 2025-11-04] [Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+]on Oct 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani@lschurr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Sep 26, 2025
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Sep 26, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-10-06 11:35:10 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace
What is the root cause of that problem?
We call
completeOnboardingif we haveisPrivateDomainAndHasAccessiblePoliciesApp/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Lines 83 to 110 in 6c55198
What changes do you think we should make in order to solve the problem?
We should explicitly check the PERSONAL_SPEND
and navigate to next page like we did here
App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Lines 86 to 89 in 6c55198
isPrivateDomainAndHasAccessiblePoliciescheck if userhasAccessibleDomainPoliciesthat they can join and if user skip the previous model to join a workspace we want to show create workspace option when they choose track expenses.Add above logic before checking bellow condition that complete onboarding instantly for reming option other then
MANAGE_TEAMandPERSONAL_SPENDif it's a private domain has accessible policies.App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Line 91 in 7585b7f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mkzie2 commentedon Sep 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.
What is the root cause of that problem?
With a private domain user, we complete the onboarding if the purpose is not
manage team's expensesApp/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Lines 91 to 99 in 02b47d6
What changes do you think we should make in order to solve the problem?
We should navigate to the onboarding workspace page with the same condition here
App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Lines 91 to 99 in 02b47d6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
lorretheboy commentedon Sep 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.
What is the root cause of that problem?
The condition in BaseOnboardingPersonalDetails was wrong. It does not redirect private domain users to the workspace creation screen
App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Lines 91 to 108 in 80cff7c
What changes do you think we should make in order to solve the problem?
We should check
choice !== CONST.ONBOARDING_CHOICES.PERSONAL_SPENDhere as wellApp/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx
Line 91 in 80cff7c
So that navigation goes to ROUTES.ONBOARDING_PERSONAL_DETAILS, and since personal details are already filled, the existing logic in BaseOnboardingPersonalDetails correctly routes PERSONAL_SPEND users to the workspace creation screen
App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Lines 104 to 108 in 264155b
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-][+][$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+]melvin-bot commentedon Sep 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021971638239516583207
melvin-bot commentedon Sep 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)jayeshmangwani commentedon Sep 29, 2025
Hey @samranahm @mkzie2 @lorretheboy , thanks for the proposals. Since you’ve already suggested the solutions, could you please help me reproduce the
join available workspacesprerequisite?39 remaining items
lschurr commentedon Oct 22, 2025
Payment Summary
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @jayeshmangwani due $250 via NewDot
[-][Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-][+][Due for payment 2025-11-04] [Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+]melvin-bot commentedon Oct 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 28, 2025
@jayeshmangwani @lschurr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
twisterdotcom commentedon Nov 5, 2025
@jayeshmangwani has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-59d9-a3f7-be12-26483bb27331