Skip to content

[Due for payment 2025-11-04] [Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace #71381

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.18-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dylanexpensify
Slack conversation (hyperlinked to channel name): #expensify Bugs

Action Performed:

  1. Sign up as a new user
  2. Complete the personal details step
  3. When prompted to join available workspaces, click Skip
  4. On the next screen, select Track and budget expenses.

Expected Result:

The onboarding flow should show a screen asking if the member wants to create a workspace, User should be guided to set up a workspace before being dropped into the main chat.

Actual Result:

Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.1713.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021971638239516583207
  • Upwork Job ID: 1971638239516583207
  • Last Price Increase: 2025-10-03
  • Automatic offers:
    • mkzie2 | Contributor | 109039711
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 26, 2025
  2. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Sep 26, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-10-06 11:35:10 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace

    What is the root cause of that problem?

    We call completeOnboarding if we have isPrivateDomainAndHasAccessiblePolicies

    onPress: () => {
    setOnboardingPurposeSelected(choice);
    setOnboardingErrorMessage('');
    if (choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    Navigation.navigate(ROUTES.ONBOARDING_EMPLOYEES.getRoute(route.params?.backTo));
    return;
    }
    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
    completeOnboarding({
    engagementChoice: choice,
    onboardingMessage: onboardingMessages[choice],
    firstName: personalDetailsForm.firstName,
    lastName: personalDetailsForm.lastName,
    adminsChatReportID: onboardingAdminsChatReportID ?? undefined,
    onboardingPolicyID,
    });
    InteractionManager.runAfterInteractions(() => {
    Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
    });
    return;
    }
    Navigation.navigate(ROUTES.ONBOARDING_PERSONAL_DETAILS.getRoute(route.params?.backTo));
    },
    };

    What changes do you think we should make in order to solve the problem?

    We should explicitly check the PERSONAL_SPEND

    and navigate to next page like we did here

    if (choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    Navigation.navigate(ROUTES.ONBOARDING_EMPLOYEES.getRoute(route.params?.backTo));
    return;
    }

    • isPrivateDomainAndHasAccessiblePolicies check if user hasAccessibleDomainPolicies that they can join and if user skip the previous model to join a workspace we want to show create workspace option when they choose track expenses.
        if (isPrivateDomainAndHasAccessiblePolicies && choice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND) {
            Navigation.navigate(ROUTES.ONBOARDING_WORKSPACE.getRoute(route.params?.backTo));
            return;
        }

    Add above logic before checking bellow condition that complete onboarding instantly for reming option other then MANAGE_TEAM and PERSONAL_SPEND if it's a private domain has accessible policies.

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. mkzie2 commented on Sep 26, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.

    What is the root cause of that problem?

    With a private domain user, we complete the onboarding if the purpose is not manage team's expenses

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
    completeOnboarding({
    engagementChoice: choice,
    onboardingMessage: onboardingMessages[choice],
    firstName: personalDetailsForm.firstName,
    lastName: personalDetailsForm.lastName,
    adminsChatReportID: onboardingAdminsChatReportID ?? undefined,
    onboardingPolicyID,
    });

    What changes do you think we should make in order to solve the problem?

    We should navigate to the onboarding workspace page with the same condition here

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
                        if (choice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND) {
                            Navigation.navigate(ROUTES.ONBOARDING_WORKSPACE.getRoute(route.params?.backTo));
                            return;
                        }
    

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
    completeOnboarding({
    engagementChoice: choice,
    onboardingMessage: onboardingMessages[choice],
    firstName: personalDetailsForm.firstName,
    lastName: personalDetailsForm.lastName,
    adminsChatReportID: onboardingAdminsChatReportID ?? undefined,
    onboardingPolicyID,
    });

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. lorretheboy commented on Sep 26, 2025

    @lorretheboy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Onboarding flow completes immediately, User is dropped into the #admins chat with no prompt to create a workspace.

    What is the root cause of that problem?

    The condition in BaseOnboardingPersonalDetails was wrong. It does not redirect private domain users to the workspace creation screen

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
    completeOnboarding({
    engagementChoice: choice,
    onboardingMessage: onboardingMessages[choice],
    firstName: personalDetailsForm.firstName,
    lastName: personalDetailsForm.lastName,
    adminsChatReportID: onboardingAdminsChatReportID ?? undefined,
    onboardingPolicyID,
    });
    InteractionManager.runAfterInteractions(() => {
    Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
    });
    return;
    }
    Navigation.navigate(ROUTES.ONBOARDING_PERSONAL_DETAILS.getRoute(route.params?.backTo));

    What changes do you think we should make in order to solve the problem?

    We should check choice !== CONST.ONBOARDING_CHOICES.PERSONAL_SPEND here as well

    if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {

    So that navigation goes to ROUTES.ONBOARDING_PERSONAL_DETAILS, and since personal details are already filled, the existing logic in BaseOnboardingPersonalDetails correctly routes PERSONAL_SPEND users to the workspace creation screen

    if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {
    updateDisplayName(firstName, lastName, formatPhoneNumber, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, session?.email ?? '');
    Navigation.navigate(ROUTES.ONBOARDING_WORKSPACE.getRoute(route.params?.backTo));
    return;
    }

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 26, 2025
  7. changed the title [-]“Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-] [+][$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+] on Sep 26, 2025
  8. melvin-bot commented on Sep 26, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 26, 2025
  10. melvin-bot commented on Sep 26, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  11. jayeshmangwani commented on Sep 29, 2025

    @jayeshmangwani
    Contributor

    Hey @samranahm @mkzie2 @lorretheboy , thanks for the proposals. Since you’ve already suggested the solutions, could you please help me reproduce the join available workspaces prerequisite?

  12. 39 remaining items

  13. lschurr commented on Oct 22, 2025

    @lschurr
    Contributor

    Payment Summary

    Contributor: @mkzie2 paid $250 via Upwork
    Contributor+: @jayeshmangwani due $250 via NewDot

  14. changed the title [-][Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/-] [+][Due for payment 2025-11-04] [Due for payment 2025-10-22] [$250] “Track Intent” Users Skipping Workspace Join Are Not Prompted to Create a Workspace[/+] on Oct 28, 2025
  15. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-04. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    @jayeshmangwani @lschurr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. twisterdotcom commented on Nov 5, 2025

    @twisterdotcom
    Contributor

    @jayeshmangwani has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-59d9-a3f7-be12-26483bb27331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions