You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make it more apparent in the expense chat carousel view when expenses are added to a report #71390
In MoneyRequestReportPreview we will track the highlighted items via a state and pass shouldHighlight all the way down to TransactionPreviewContent if an item is part of it. Via an effect whenever there is a new transaction added we will set newItemsToHighlight
In that case we can imperatively call scrollAndHighlightItem approach like in SelectionLisht here The approach will similar to the above but we will only need to make notifyNewAction pass the new transactionIDs added then after scrolling to the report preview we will call scrollAndHighlightItem with the new transactionIDs and simialr to BaseSelectionList we will scroll to the new item and set a temporary itemsToHighlight state(that would be reset after a timeout).
REsult : 2025-09-27.02-56-40.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
⚠️@FitseTLT Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Verify that the new expenses created are scrolled to view and highlighted unless the report preview has more than 10 expenses and the new expenses are currently hidden on the report preview.
Open the iou report
Create an expense while on the iou report page
Quickly navigate back to the chat report
Verify that the scrolling and highlighting doesn't occur because the expense was added while on the iou report.
Activity
melvin-bot commentedon Sep 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)jamesdeanexpensify commentedon Sep 26, 2025
Shoot, I can't seem to get the video to show up right in the OP.
PiyushChandra17 commentedon Sep 26, 2025
I would like to work on this, the changes are already mentioned in OP
rushatgabhane commentedon Sep 26, 2025
need a proposal for this one
PiyushChandra17 commentedon Sep 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Make it more apparent in the expense chat carousel view when expenses are added to a report
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
We need to implement a
Carouselview when expenses are added to reportIt should consists with
prevButtonandnextButtonat the top > It should slide in and have fade view effectWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
n/A
What alternative solutions did you explore? (Optional)
n/A
jamesdeanexpensify commentedon Sep 26, 2025
I updated the video in the OP with a recording. You can see that there's already a carousel view in the expense chat!
jamesdeanexpensify commentedon Sep 26, 2025
The actual change is: new expenses should slide in and there should be a highlight that fades out slowly:
PiyushChandra17 commentedon Sep 26, 2025
Okay i think it's right here, we need to update this
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Line 387 in 58a0856
Need to figure out the slide in behaviour, highlight that fades out slowly we do it like this way:
App/src/pages/workspace/WorkspaceMembersPage.tsx
Line 495 in 58a0856
FitseTLT commentedon Sep 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Make it more apparent in the expense chat carousel view when expenses are added to a report
What is the root cause of that problem?
New Feature
What changes do you think we should make in order to solve the problem?
We will need to pass
shouldHighlightprop toTransactionPreviewContentand we will enable the highlight animation if it is trueApp/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx
Lines 199 to 202 in 9490950
In MoneyRequestReportPreview we will track the highlighted items via a state and pass shouldHighlight all the way down to TransactionPreviewContent if an item is part of it. Via an effect whenever there is a new transaction added we will set newItemsToHighlight
App/src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx
Line 146 in 9490950
Then pass itemsToHighlight
App/src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx
Line 138 in 9490950
Then insided MoneyRequestReportPreviewContent we will scroll to the first new item
Optionally we can start the scrolling and highlighting after the report preview is scrolled to view here
App/src/pages/home/report/ReportActionsList.tsx
Lines 443 to 449 in 9490950
In that case we can imperatively call
scrollAndHighlightItemapproach like in SelectionLisht here The approach will similar to the above but we will only need to makenotifyNewActionpass the new transactionIDs added then after scrolling to the report preview we will call scrollAndHighlightItem with the new transactionIDs and simialr to BaseSelectionList we will scroll to the new item and set a temporary itemsToHighlight state(that would be reset after a timeout).REsult :
2025-09-27.02-56-40.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
github-actions commentedon Sep 26, 2025
111 remaining items
melvin-bot commentedon May 6, 2026
This issue has not been updated in over 15 days. @marcochavezf, @dannymcclain, @FitseTLT, @situchan eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
situchan commentedon May 29, 2026
@mallenexpensify This is done and ready for payment
The linked blocker is not a regression.
Reason: #83760 (comment)
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/642938
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-f929-a01c-5d38-95bdeb8767f4mallenexpensify commentedon May 30, 2026
@situchan @FitseTLT what are you each due? Please post links to PRs you worked on (and.. any DBs or regressions). Thx
^ Test case created. Thx
situchan commentedon Jun 4, 2026
$250
#81446
Linked blocker: #81446 (comment)
Not regression. Reasoning: #83760 (comment)
situchan commentedon Jun 20, 2026
cc: @mallenexpensify ^
melvin-bot commentedon Jun 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Jun 22, 2026
Payment Summary
Contributor: @FitseTLT due $250 via NewDot
Contributor+: @situchan due $250 via NewDot
Apologies for the delay, thx for tagging
laurenreidexpensify commentedon Jul 7, 2026
$250 approved @situchan
flaviadefaria commentedon Jul 14, 2026
Approved: @FitseTLT due $250 via NewDot