Skip to content

[Due for payment 2025-10-21] [CFI] Add coloured labels to report statuses in New Expensify #71549

Closed

Description

@miljakljajic

Problem: The status of a NewDot report can sometimes be lost in the header.
Solution: Add coloured labels to signify the status, as we have in OldDot.

Discussion here.
Figma file linked here

Image Image Image Image Image Image Image
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 30, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 30, 2025
  3. melvin-bot commented on Sep 30, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  4. miljakljajic commented on Sep 30, 2025

    @miljakljajic
    ContributorAuthor
  5. lorretheboy commented on Sep 30, 2025

    @lorretheboy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The status of a NewDot report can sometimes be lost in the header, making it difficult for users to quickly identify the current state of their expense reports. Unlike OldDot which had colored labels to signify different report statuses, NewDot currently only displays status text without visual color coding, reducing the visual prominence and quick recognition of report states.

    What is the root cause of that problem?

    The root cause is that NewDot's current status display implementation only shows status text without any visual color differentiation. Currently:

    1. Status text is displayed but not visually prominent: The getReportStatusTranslation function in ReportUtils returns plain text statuses like "Draft", "Outstanding", "Approved", "Paid", and "Done" without any color coding.
      function getReportStatusTranslation(stateNum?: number, statusNum?: number): string {

    Status is currently shown in components like AvatarWithDisplayName, ParentNavigationSubtitle, and MoneyRequestReportPreviewContent as plain text without color differentiation.

    What changes do you think we should make in order to solve the problem?

    1. Create a new ReportStatusBadge component that displays status text with appropriate background colors:
    • Use the existing Badge component as a foundation (or can create new component for Icon-Based Status Indicators)
    • Map each report status to appropriate theme colors
    1. Extend the existing badge color system in StyleUtils.getBadgeColorStyle() to support report status colors:
    • Add new badge style variants for each report status
    • Ensure proper contrast and accessibility in both light and dark themes
    1. Update status display locations to use the new colored badge:
    • Modify AvatarWithDisplayName component to render ReportStatusBadge instead of plain text when shouldDisplayStatus is true
    • Update ParentNavigationSubtitle to use the colored badge for status display
    • Enhance MoneyRequestReportPreviewContent to show colored status badges

    ...etc

    {!!statusText && <Text style={[styles.optionAlternateText, styles.textLabelSupporting]}>{`${statusText} ${CONST.DOT_SEPARATOR} `}</Text>}

    <Text style={[styles.textLabelSupporting, styles.lh16]}>{`${reportStatus} ${CONST.DOT_SEPARATOR} ${expenseCount}`}</Text>

    statusText={statusText}

    1. Add a utility function getReportStatusBadgeProps() in ReportUtils.ts:
    • Maps stateNum and statusNum combinations to appropriate badge colors and styles
    • Returns props that can be passed directly to the ReportStatusBadge component
    • Maintains consistency across all status display locations
    1. Ensure responsive design: Make the badge size and positioning work well across different screen sizes and layouts.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  6. samranahm commented on Sep 30, 2025

    @samranahm
    Contributor

    @miljakljajic The images are not loading in OP

  7. miljakljajic commented on Sep 30, 2025

    @miljakljajic
    ContributorAuthor

    Reposting!

  8. miljakljajic commented on Sep 30, 2025

    @miljakljajic
    ContributorAuthor

    Should be all good now.

  9. self-assigned this
    on Sep 30, 2025
  10. melvin-bot commented on Sep 30, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.

  11. 30 remaining items

  12. sonialiap commented on Oct 21, 2025

    @sonialiap
    Contributor

    Payment summary:
    @suneox $250 please request in NewDot and propose a regression test
    @lorretheboy $250 offer sent in upwork - paid

  13. suneox commented on Oct 27, 2025

    @suneox
    Contributor

    We still have a PR fixing the regression issue that’s waiting to be merged

  14. suneox commented on Oct 27, 2025

    @suneox
    Contributor

    Regression Test Proposal
    Precondition: Prepare reports with different statuses

    1. Go to ND
    2. Go to Reports --> Chats
    3. Verify that there is a status badge UI on expense message card matches the design
    4. Go to Reports
    5. Verify that there is a status badge UI on report preview matches the design
    6. Click to view report details
    7. Verify that there is a status badge UI on report header matches the design

    Do we agree 👍 or 👎

  15. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. sonialiap commented on Oct 29, 2025

    @sonialiap
    Contributor

    Thanks!

  17. melvin-bot commented on Nov 1, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  18. garrettmknight commented on Nov 21, 2025

    @garrettmknight
    Contributor

    $250 approved for @suneox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions