You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-27] [$250] Public room is not open via link when logged out - Native app #71656
Version Number: v9.2.21-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#71271 Email or phone of affected tester (no customers):qaooxxasfds@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 12 / iOS 18.7 App Component: Other
What changes do you think we should make in order to solve the problem?
Use the hasAuthToken function to determine the value of isAuthenticated, and pass that to openReportFromDeepLink. hasAuthToken was previously used in openReportFromDeepLink but was removed in PR #70382
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
Public room is not open via link when logged out
What is the root cause of that problem?
This is a common React issue that happens when you don't include the variable in the effect's dependencies list, each effect run might have stale data.
What changes do you think we should make in order to solve the problem?
We can not simply add isAuthenticated to the above effect dependencies list because it might cause regressions, or use hasAuthToken because it can reintroduce the previous bug that it was removed to solve.
There's a workaround to useRef to store the isAuthenticated value instead. Then use a separate effect to update the isAuthenticatedRef to the latest value.
What alternative solutions did you explore? (Optional)
changed the title [-]Public room is not open via link when logged out - Native app[/-][+][$250] Public room is not open via link when logged out - Native app[/+]on Oct 2, 2025
changed the title [-][$250] Public room is not open via link when logged out - Native app[/-][+][Due for payment 2025-10-27] [$250] Public room is not open via link when logged out - Native app[/+]on Oct 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@akinwale@CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Oct 1, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Oct 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Public room is not open via link when logged out
What is the root cause of that problem?
When opening a deeplink in the native app, the app is navigated by calling
Report.openReportFromDeepLinkat this point:App/src/Expensify.tsx
Lines 235 to 237 in fa5e06d
Since the user was already signed in, the
isAuthenticatedvalue passed toopenReportFromDeepLinkremainstrue.Inside
openReportFromDeepLink, becauseisAuthenticated === true,openReportis not called:App/src/libs/actions/Report.ts
Lines 3419 to 3430 in fa5e06d
As a result,
openReportis never triggered, sowaitForUserSignInnever resolves, and the user is not navigated to the public room chat.App/src/libs/actions/Report.ts
Line 3452 in fa5e06d
What changes do you think we should make in order to solve the problem?
Use the
hasAuthTokenfunction to determine the value ofisAuthenticated, and pass that toopenReportFromDeepLink.hasAuthTokenwas previously used inopenReportFromDeepLinkbut was removed in PR #70382App/src/Expensify.tsx
Line 236 in fa5e06d
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
gijoe0295 commentedon Oct 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Public room is not open via link when logged out
What is the root cause of that problem?
This is a common React issue that happens when you don't include the variable in the effect's dependencies list, each effect run might have stale data.
App/src/Expensify.tsx
Line 236 in 460c43f
What changes do you think we should make in order to solve the problem?
We can not simply add
isAuthenticatedto the above effect dependencies list because it might cause regressions, or usehasAuthTokenbecause it can reintroduce the previous bug that it was removed to solve.There's a workaround to
useRefto store theisAuthenticatedvalue instead. Then use a separate effect to update theisAuthenticatedRefto the latest value.What alternative solutions did you explore? (Optional)
None
[-]Public room is not open via link when logged out - Native app[/-][+][$250] Public room is not open via link when logged out - Native app[/+]melvin-bot commentedon Oct 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021973851637553529167
melvin-bot commentedon Oct 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)CortneyOfstad commentedon Oct 2, 2025
Hey @akinwale! We have two proposals above for review when you have a chance – thanks!
akinwale commentedon Oct 7, 2025
@dmkt9's proposal looks good here.
🎀👀🎀 C+ reviewed.
15 remaining items
[-][$250] Public room is not open via link when logged out - Native app[/-][+][Due for payment 2025-10-27] [$250] Public room is not open via link when logged out - Native app[/+]melvin-bot commentedon Oct 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 20, 2025
@akinwale @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
CortneyOfstad commentedon Oct 24, 2025
Hey @akinwale — can you complete the checklist so there is no delay in payment?
@dmkt9 — I also sent you an offer via Upwork here. Please accept as soon as you can so there is no delay in payment either.
Thanks!
dmkt9 commentedon Oct 25, 2025
@CortneyOfstad Thank you. I've just requested payment on upwork.
akinwale commentedon Oct 26, 2025
BugZero Checklist:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎?
melvin-bot commentedon Oct 27, 2025
Payment Summary
Upwork Job
BugZero Checklist (@CortneyOfstad)
CortneyOfstad commentedon Oct 27, 2025
Payment Summary
@dmkt9 — paid $250 via Upwork
@akinwale — to be paid $250 via NewDot
Regression Test
https://github.com/Expensify/Expensify/issues/561976
garrettmknight commentedon Nov 4, 2025
$250 approved for @akinwale