Skip to content

[Due for payment 2025-10-15] [Due for payment 2025-10-13] Reports - "Category no longer valid" is shown briefly when moving expense #71835

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1142/folder/13176730/41237113/933086739
Email or phone of affected tester (no customers): sjinsdoisjos@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace
  3. Go to workspace chat
  4. Create an expense with category in workspace chat
  5. Create an empty report
  6. Go to Reports > Expenses
  7. Select the expense via checkbox
  8. Click dropdown button > Move expense
  9. Select the empty report

Expected Result:

"Category no longer valid" will not show when moving expense

Actual Result:

"Category no longer valid" is shown briefly when moving expense

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6964096_1759519091946.Screen_Recording_2025-10-04_at_03.15.51.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 3, 2025
  2. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 3, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 3, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. andriferry commented on Oct 4, 2025

    @andriferry

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - "Category no longer valid" is shown briefly when moving expense, Because the logic is incorrect, try to sending the policy data instead of the category list, So the category list is not being sent correctly.

    What is the root cause of that problem?

    The problem is coming from this line

    allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`],
    This line gonna be undefined result

    What changes do you think we should make in order to solve the problem?

    It should be change POLICY to POLICY_CATEGORIES like this to fix it

    allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${item.policyID}`],

    What alternative solutions did you explore? (Optional)

    N/A

    Result

    Screen.Recording.2025-10-04.at.18.07.02.mov

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. ikevin127 commented on Oct 5, 2025

    @ikevin127
    Contributor

    🔄 I ran Vector1 on this deploy blocker issue and here are the top 6 possible offending PRs based on semantic similarity2:

    • #71190: Fix - "This report has no expenses" briefly shown in Reports after clearing cache
      • semantic similarity 56.4%
    • #71444: fix: Error is not removed from the report preview after paying an expense with empty field
      • semantic similarity 55.9%
    • #69291: Fix - Expense - Paying the expense removed the amount violation, but it re-appeared later
      • semantic similarity 54.1%
    • #71371: fix(report-paylist): prevent empty state after paying report offline
      • semantic similarity 48.5%
    • #71136: Fix workspace change
      • semantic similarity 48.3%
    • #71457: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_CATEGORIES in src/libs/actions/Policy/Category.ts
      • semantic similarity 46.2%

    Please drop a 👍 (correct) or 👎 (incorrect) as feedback regarding the results.

    Note

    PR # and name added as text only to avoid triggering regression automation on the issues which the above PRs are addressing in case the finding is incorrect.

    @DylanDylann Looks like this one might be coming our PR based on #71835 (comment):

    • #71457: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_CATEGORIES in src/libs/actions/Policy/Category.ts

    Footnotes

    1. Vector is currently a local-only prototype stage app that uses AI embeddings to find offending PRs for a given deploy blocker issue. Because of the early stage of the app, results must be taken with with a grain of🧂. How it works: grab deploy blocker issue's OP data (title, steps, expected / actual result) and embed -> grab all deploy checklist issue PRs data (title, explanation of change, tests, changed files, AI diff summary) and embed -> calculate cosine similarity of issue embedding to each PRs embedding -> get results. ↩

    2. Semantic similarity, when applied to embeddings, measures the similarity in meaning between different pieces of text by comparing their vector representations in a high-dimensional "semantic space". Texts with similar meanings are mapped to vectors that are close together, and this "closeness" is quantified using metrics like cosine similarity. This technology enables search engines and chatbots to find relevant information even without exact keyword matches, providing more accurate and contextualized results. ↩

  8. 16 remaining items

  9. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  11. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    @ikevin127 / @DylanDylann @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. changed the title [-][Due for payment 2025-10-13] Reports - "Category no longer valid" is shown briefly when moving expense[/-] [+][Due for payment 2025-10-15] [Due for payment 2025-10-13] Reports - "Category no longer valid" is shown briefly when moving expense[/+] on Oct 8, 2025
  13. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.26-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  14. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    @ikevin127 / @DylanDylann @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. ikevin127 commented on Oct 10, 2025

    @ikevin127
    Contributor

    ♻️ This issue can be closed as it was a regression issue, payment will be handled in the main issue.

  16. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@isabelastisser)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. isabelastisser commented on Oct 15, 2025

    @isabelastisser
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions