[$500] - Chat Room - Handle API response inVBA flow when tapping finish Set up

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com
Log in with expensifail account
Find any room in LHN
Tap on plus button and tap Send Money
Select amount and user
Tap Pay with Expensify
Tap Add Bank Account
Put Wells Fargo credentials
Select Saving Account
Put Password and Tap Finish Set up

Expected Result:

If the API request fails, we handle that and show the error to the user.

Actual Result:

Unable procced with VBA flow after put password and tap finish Set up. No error shown.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.1.29.1

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Bug5404886_Screen_Recording_20220112-144533_Chrome.mp4

Slack conversation:

View all open jobs on GitHub

@francoisl

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I can't reproduce on dev, neither on the latest version of main nor on 1.1.29-1 specifically; I get to the identity verification step each time.

I could only test mweb on iOS though, for some reason I can't get anything to work with Android at the moment. Going to put this back in the pool and hopefully someone can chime in if they can reproduce.

Screen.Recording.2022-01-12.at.5.25.24.PM.mov

Not sure if it can be marked as an external issue until we can reproduce though.

I see something like this happening if you try to add a bank account that you already have. We get an error from the backend and we don't do anything we it, no feedback for the user. My steps:

Create account
Go to Old Dot
Add Open VBA using the SO (maybe this can be done in NewDot and the same should happen)
Go to NewDot
Navigate to Settings > Payments
Click Transfer Balance and then Bank account, it takes me to add a new bank account 🤷
Try to add bank account using same credentials as before
Fail, no feedback in the UI

Screen.Recording.2022-01-31.at.12.00.42.PM.mov

At least for the case I mentioned above, we are not doing anything with the error here:

App/src/libs/actions/BankAccounts.js

Lines 80 to 94 in 2cdb7c3

    
           .then((response) => { 
        
               if (response.jsonCode === 200) { 
        
                   PaymentMethods.getPaymentMethods() 
        
                       .then(() => { 
        
                           PaymentMethods.continueSetup(); 
        
                           Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false}); 
        
                       }); 
        
                   return; 
        
               } 
        
               if (response.message === 'Incorrect Expensify password entered') { 
        
                   ReimbursementAccount.setBankAccountFormValidationErrors({password: true}); 
        
               } 
        
               Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false}); 
        
           })

I'll label this as External as it seems just related to doing something in the front with the error that comes from the backend.

@puneetlath

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@kbecciv

@kbecciv to confirm if it is related to what I found, can you replicate the problem and look in the network tab of chrome dev tools and see if you are getting an error in the response of the request sent to the URL: .../api?command=BankAccount_Create

Upwork job for handling the API response is here: https://www.upwork.com/jobs/~0151453e9454631fab

Waiting for an update by rajat when he gets the chance.

Issue not reproducible during KI retests. (First week)

@chiragsalian

Due to the implementation of Open API and the unavailability of documentation, I am not sure how should I handle this case.

Technically, already existing bank account detection was fixed on the backend after I pointed it out and error handling was changed on the front.

@chiragsalian what do you suggest I should do next? Could you please update the OP for new behaviour?

Otherwise, I feel like there is no action left for me here. I will close the PR.

Hmm im not sure where we currently stand since so many APIs have changed lately. I'll retest this today and decide on the next steps.

I just retested. Looks like the error is now received appropriately in the onyxData. This means there is a proper error message when the same back account is selected.

Hence I don't think there is anything to be done here. Maybe in the future, we can clear up how the error message is shown but the original issue mentioned in this GH is resolved so closing it out.

@Christinadobrzyn

Thanks, Chirag. @Christinadobrzyn Could you please take care of the payment for this? Original job posting where contract is live https://www.upwork.com/jobs/Handle-API-response-inVBA-flow-when-tapping-finish-Set-7185-Expensify_~01c21d7847d9c14366

@Christinadobrzyn

Bump @Christinadobrzyn ⬆️

@Christinadobrzyn

@Christinadobrzyn Any update for me?

Hi @Expensify/contributor-management, can someone help out with the payment here?

@parasharrajat

Paid it @parasharrajat. Just to confirm, there was no C+ on this?

Yeah, no C+. Thanks.

Navigation Menu

Repository navigation

[$500] - Chat Room - Handle API response inVBA flow when tapping finish Set up #7185

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

152 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	.then((response) => {
	if (response.jsonCode === 200) {
	PaymentMethods.getPaymentMethods()
	.then(() => {
	PaymentMethods.continueSetup();
	Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false});
	});
	return;
	}

	if (response.message === 'Incorrect Expensify password entered') {
	ReimbursementAccount.setBankAccountFormValidationErrors({password: true});
	}
	Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false});
	})

[$500] - Chat Room - Handle API response inVBA flow when tapping finish Set up #7185

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Jan 12, 2022

francoisl commented on Jan 13, 2022

aldo-expensify commented on Jan 31, 2022

aldo-expensify commented on Jan 31, 2022

MelvinBot commented on Jan 31, 2022

aldo-expensify commented on Jan 31, 2022

puneetlath commented on Jan 31, 2022

152 remaining items

chiragsalian commented on Sep 30, 2022

mvtglobally commented on Oct 3, 2022

parasharrajat commented on Oct 6, 2022

chiragsalian commented on Oct 6, 2022

chiragsalian commented on Oct 6, 2022

parasharrajat commented on Oct 7, 2022

parasharrajat commented on Oct 16, 2022

parasharrajat commented on Oct 19, 2022

chiragsalian commented on Oct 19, 2022

puneetlath commented on Oct 20, 2022

parasharrajat commented on Oct 20, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions