Skip to content

Report fields - Blank RHP opens when opening formula report field in expense reports #71850

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.23-0
Reproducible in staging?: Y
Reproducible in production?: new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Pre-condition:
User has a control workspace created
Workspace has report fields enabled

  1. Sign in to staging.new.expensify.com with an account that fulfils the above preconditions
  2. Navigate to workspace > Workspace settings > Reports
  3. Click on Add fields
  4. Enter a name and click on type
  5. On type, select formula
  6. Save the new report field created
  7. Navigate to the workspace conversation
  8. Create an expense
  9. Navigate to the report with the expense created in step 8
  10. On the top, click on Formula report field

Expected Result:

RHP opens with contents in the formula report field

Actual Result:

A blank RHP opens when click on formula report field

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6964352_1759542324174.bandicam_2025-10-04_04-33-02-628.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 4, 2025
  2. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on Oct 4, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report fields - Blank RHP opens when opening formula report field in expense reports

    What is the root cause of that problem?

    We are checking reportField.type here but included formula type here for edit

    {(reportField.type === 'text' || isReportFieldTitle) && (
    <EditReportFieldText
    fieldName={Str.UCFirst(reportField.name)}
    fieldKey={fieldKey}
    fieldValue={fieldValue}
    isRequired={!isReportFieldDeletable}
    onSubmit={handleReportFieldChange}
    />
    )}
    {reportField.type === 'date' && (
    <EditReportFieldDate
    fieldName={Str.UCFirst(reportField.name)}
    fieldKey={fieldKey}
    fieldValue={fieldValue}
    isRequired={!reportField.deletable}
    onSubmit={handleReportFieldChange}
    />
    )}

    What changes do you think we should make in order to solve the problem?

    We should create a new component EditReportFieldFormula and let the user edit that as they do with other fields

      {reportField.type === 'formula' && (
          <EditReportFieldFormula
              fieldName={Str.UCFirst(reportField.name)}
              fieldKey={fieldKey}
              fieldValue={fieldValue}
              isRequired={!reportField.deletable}
              onSubmit={handleReportFieldChange}
          />
      )}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. lakchote commented on Oct 6, 2025

    @lakchote
    Contributor

    Coming from #71790 cc @iwiznia

  8. m-natarajan commented on Oct 6, 2025

    @m-natarajan

    Formula type not available -Motorola Moto G60 - Android 12, Windows 10/Chrome/Build v9.2.23-3

    2025-10-06.19-23-19.mp4
    screen-20251006-132230.mp4
  9. lakchote commented on Oct 6, 2025

    @lakchote
    Contributor

    PR has been reverted and CP'ed to staging. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions