Skip to content

Reports - No Save button on the edit initial value of the Formula type #71851

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.23-0
Reproducible in staging?: Y
Reproducible in production?: new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #71790
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to ND
  2. Create a workspace or use the existing workspace
  3. Go to Report settings and enable Report field
  4. Click Add field and fill with any random name
  5. Select the Type field as Formula > Save
  6. Open the recently created report field
  7. Try to edit the Initial value

Expected Result:

Save button on the edit initial value of the Formula type should be available

Actual Result:

No Save button on the edit initial value of the Formula type
Note:

  • Save button is available on the other report field type (e.g. Text)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6964368_1759545362990.71822_-_PR71790_-_Reports_-_No_Save_button_on_the_edit_initial_value_of_the_Formula_type.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 4, 2025
  2. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on Oct 4, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - No Save button on the edit initial value of the Formula type

    What is the root cause of that problem?

    Here

    isSubmitButtonVisible={isTextFieldType}

    we are returning false for isFormulaFieldType because we're only checking for isTextFieldType

    What changes do you think we should make in order to solve the problem?

    we should update this to

    isSubmitButtonVisible={isTextFieldType || isFormulaFieldType}

    since this formProvider is for both isTextFieldType and isFormulaFieldType

    {(isTextFieldType || isFormulaFieldType) && (
    <FormProvider
    addBottomSafeAreaPadding
    formID={ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM}
    onSubmit={submitForm}
    submitButtonText={translate('common.save')}
    validate={validateForm}
    style={styles.flex1}
    enabledWhenOffline
    isSubmitButtonVisible={isTextFieldType}
    submitButtonStyles={styles.mh5}
    shouldHideFixErrorsAlert
    >

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. lakchote commented on Oct 6, 2025

    @lakchote
    Contributor

    Coming from #71790 cc @iwiznia

  8. m-natarajan commented on Oct 6, 2025

    @m-natarajan

    Formula type not available , Win 11 / Chrome Web v9.2.23-3, Samsung Galaxy A40/Android 11/App/Build v9.2.23-2

    MicrosoftTeams-video.7.mp4
    bandicam.2025-10-06.19-14-18-439.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions