Skip to content

[Due for payment 2025-11-28] [Due for payment 2025-11-18] [$250] Expensify card- "auto-sync" opens Advanced instead of Auto-sync when connected to Sage Intacct #71875

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.23-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1144/folder/13176890/41237385/933088820
Email or phone of affected tester (no customers): applausetester+041001kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is set up with Expensify card feature.
  • Workspace is connected to Sage Intacct.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Click Advanced > Auto-sync.
  4. Disable auto-sync.
  5. Close RHP.
  6. Click Card reconciliation.
  7. Click auto-sync link.

Expected Result:

Auto-sync link will open Auto-sync page (this is the behavior when QBO is connected - #60603 and Xero is connected - https://github.com/Expensify/Expensify/issues/535609)

Actual Result:

Auto-sync link opens Advanced page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6964906_1759598028270.Screen_Recording_2025-10-05_at_01.08.47.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021976691035508678144
  • Upwork Job ID: 1976691035508678144
  • Last Price Increase: 2025-10-10
  • Automatic offers:
    • daledah | Contributor | 109127552
Issue OwnerCurrent Issue Owner: @Gonals

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 6, 2025
  2. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Oct 6, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Auto-sync link opens Advanced page.

    What is the root cause of that problem?

    We are navigating to POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED here

    case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
    return `${environmentURL}/${ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID)}`;

    What changes do you think we should make in order to solve the problem?

    1. We should navigate to POLICY_ACCOUNTING_SAGE_INTACCT_AUTO_SYNC instead
                case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
                    return `${environmentURL}/${ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_AUTO_SYNC.getRoute(policyID, backTo)}`;
    
    1. Then handle backTo in SageIntacctAutoSyncPage like the way we did in XeroAutoSyncPage

    const {backTo} = route.params as XeroAutoSyncPageRouteParams;

    const goBack = useCallback(() => {
    Navigation.goBack(backTo ?? ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));
    }, [policyID, backTo]);

    Note: we can do the same with the QBD feature (If only QBD had auto-sync feature)

    case CONST.POLICY.CONNECTIONS.ROUTE.QBD:
    return `${environmentURL}/${ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_DESKTOP_ADVANCED.getRoute(policyID, backTo)}`;

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. muhammad-ali-abbasi commented on Oct 6, 2025

    @muhammad-ali-abbasi

    🧩 Proposal

    Problem we are trying to solve

    When users click the Auto-sync link under Sage Intacct settings, they are incorrectly redirected to the Advanced configuration screen instead of the Auto-sync page.


    Root cause

    Inside CardReconciliationPage.tsx, the Sage Intacct navigation case still references the route for Advanced settings (POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED) instead of the Auto-sync route.
    Because of this, the Auto-sync button is mapped to the wrong destination and skips the expected page entirely.


    Suggested fix

    We can correct this by updating the navigation to point to the Auto-sync route and ensuring that the backTo parameter is handled consistently with other accounting integrations like Xero.

    In short:

    • Update the Sage Intacct navigation to use the correct route (POLICY_ACCOUNTING_SAGE_INTACCT_AUTO_SYNC).
    • Implement the same back navigation logic that’s already used in XeroAutoSyncPage.

    Expected behavior after the fix

    • The Auto-sync button should open the Auto-sync page for Sage Intacct.
    • Navigating back should return the user to the correct previous page.

    Additional consideration

    If the QuickBooks Desktop (QBD) feature eventually includes Auto-sync support, the same route pattern can be reused there.


    Test cases

    • Confirm that Auto-sync opens the correct screen.
    • Verify that clicking “back” from the Auto-sync page returns properly to the previous view.

    ✅ I’m happy to work on this fix free of charge as part of the open-source project.


    💡 Rephrased Solution

    File:
    App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

    Before:

    case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
        return `${environmentURL}/${ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID)}`;

    After (Updated Logic):

    case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
        return `${environmentURL}/${ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_AUTO_SYNC.getRoute(policyID, backTo)}`;

    Then, in:
    App/src/pages/workspace/accounting/sageIntacct/autoSync/SageIntacctAutoSyncPage.tsx

    Add handling for the backTo parameter like this (based on how it’s done in Xero):

    const {backTo} = route.params as SageIntacctAutoSyncPageRouteParams;
    
    const goBack = useCallback(() => {
        Navigation.goBack(
            backTo ?? ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID)
        );
    }, [policyID, backTo]);

    This ensures:

    • The correct Auto-sync page opens.
    • Back navigation behaves consistently.
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 10, 2025
  6. melvin-bot commented on Oct 10, 2025

    @melvin-bot
  7. changed the title [-]Expensify card- "auto-sync" opens Advanced instead of Auto-sync when connected to Sage Intacct[/-] [+][$250] Expensify card- "auto-sync" opens Advanced instead of Auto-sync when connected to Sage Intacct[/+] on Oct 10, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2025
  9. melvin-bot commented on Oct 10, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  10. allroundexperts commented on Oct 13, 2025

    @allroundexperts
    Contributor

    @daledah's proposal looks good to me.

    🎀 👀 🎀 C+ reviewed

  11. 24 remaining items

  12. abekkala commented on Nov 18, 2025

    @abekkala
    Contributor

    @daledah payment sent and contract ended - thank you!

  13. abekkala commented on Nov 18, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR NOV 18

  14. changed the title [-][Due for payment 2025-11-18] [$250] Expensify card- "auto-sync" opens Advanced instead of Auto-sync when connected to Sage Intacct[/-] [+][Due for payment 2025-11-28] [Due for payment 2025-11-18] [$250] Expensify card- "auto-sync" opens Advanced instead of Auto-sync when connected to Sage Intacct[/+] on Nov 21, 2025
  15. melvin-bot commented on Nov 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Nov 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.61-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-28. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Nov 21, 2025

    @melvin-bot

    @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. trjExpensify commented on Jan 5, 2026

    @trjExpensify
    Contributor

    approved $250 for @allroundexperts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions