Skip to content

[$250] LHN - Open app again, draft conversation returns original location instead at top on LHN #71961

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.24-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1163/folder/13176910/41237484/936936627
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 16 pro/ 18.6.2
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Open app login with account have some conversations on LHN
  2. Navigate to a conversation at bottom LHN
  3. Type something but not send message and go out this conversation
  4. Observe this conversation move to the top conversation of LHN
  5. Force close app
  6. Find this draft conversation

Expected Result:

Force close app and open again, this draft conversation should remain at the top conversation of LHN

Actual Result:

Force close app and open again, this draft conversation is displayed at bottom location on LHN

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021975907999845233835
  • Upwork Job ID: 1975907999845233835
  • Last Price Increase: 2025-10-15
Issue OwnerCurrent Issue Owner: @alitoshmatov

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2025
  2. melvin-bot commented on Oct 7, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Oct 7, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Force close app and open again, this draft conversation is displayed at bottom location on LHN

    What is the root cause of that problem?

    The draft report is marked as non-archived report

    nonArchivedReports.push(miniReport);

    The problem is here, hasValidDraftComment check is using the data from Onyx.connect, which can be not available at the time this function is called

    const hasDraft = reportID ? hasValidDraftComment(reportID) : false;

    What changes do you think we should make in order to solve the problem?

    We should pass reportDrafts to hasValidDraftComment as a new parameter and use this data to check

    const hasDraft = reportID ? hasValidDraftComment(reportID) : false;

    And then pass the reportDrafts from here to categorizeReportsForLHN function.

    () => SidebarUtils.sortReportsToDisplayInLHN(deepComparedReportsToDisplayInLHN ?? {}, priorityMode, localeCompare, reportNameValuePairs, reportAttributes),

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 8, 2025
  5. changed the title [-]LHN - Open app again, draft conversation returns original location instead at top on LHN[/-] [+][$250] LHN - Open app again, draft conversation returns original location instead at top on LHN[/+] on Oct 8, 2025
  6. melvin-bot commented on Oct 8, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 8, 2025
  8. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

  9. moved this from Tracking to Bugs and Follow Up Issues in #expensify-bugson Oct 8, 2025
  10. self-assigned this
    on Oct 9, 2025
  11. dangrous commented on Oct 9, 2025

    @dangrous
    Contributor

    Happy to handle internal review on this when ready!

  12. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

  14. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    @alitoshmatov Still overdue 6 days?! Let's take care of this!

  16. dangrous commented on Oct 17, 2025

    @dangrous
    Contributor

    bump for review of proposals, thanks @alitoshmatov !

  17. situchan commented on Oct 19, 2025

    @situchan
    Contributor

    Looks like this was fixed in #70409. Not able to reproduce anymore

  18. IuliiaHerets commented on Oct 20, 2025

    @IuliiaHerets

    QA team can' repro this issue on iPhone 13 / iOS 18.7.1 and Samsung Galaxy A52 / Android 14, build v9.2.33-4

    1760949041068.draft_chat_andro.mp4
    1760949041072.draft_chat.mp4
  19. bfitzexpensify commented on Oct 20, 2025

    @bfitzexpensify
    Contributor

    Great, let's close

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions