Skip to content

[Due for payment 2025-10-28] Expense - Negative expense can be added to IOU report, which causes error #72138

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.28-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #65001
Email or phone of affected tester (no customers): djojsijiosjsdi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense with negative amount.
  4. Open FAB > Create expense > Manual.
  5. Submit an expense to user.
  6. Open the expense report.
  7. Click More > Add unreported expense.
  8. Select the expense with negative amount.
  9. Click Add to report.

Expected Result:

Unreported expense list should not show the negative expense when adding unreported expense in IOU report.

Actual Result:

Unreported expense list shows the negative expense when adding unreported expense in IOU report.
After adding the negative expense, it throws error.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6969079_1759961516718.Screen_Recording_2025-10-09_at_06.07.03.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 8, 2025
  2. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 25 remaining items

  7. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.35-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-28. 🎊

    For reference, here are some details about the assignees on this issue:

  8. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    @nkuoch @sakluger @pasyukevich The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. c3024 commented on Oct 23, 2025

    @c3024
    Contributor
  10. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  11. c3024 commented on Oct 28, 2025

    @c3024
    Contributor

    No, Melvin. This needs payment.

    cc: @sakluger

  12. sakluger commented on Oct 28, 2025

    @sakluger
    Contributor

    Payment Summary

    Contributor+: @c3024 due $250 via Newdot

  13. c3024 commented on Oct 28, 2025

    @c3024
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: The same PR author fixed this. He is aware of the RCA of this bug.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not a critical bug.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Account has self DM

    Test:

    1. Go to self DM.
    2. Create an expense with negative amount.
    3. Open FAB > Create expense > Manual.
    4. Submit an expense to user.
    5. Open the expense report.
    6. Click More > Add unreported expense.
    7. Verify that there are no expenses with negative amount

    Do we agree 👍 or 👎

  14. twisterdotcom commented on Nov 19, 2025

    @twisterdotcom
    Contributor

    @c3024 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-1858-a83f-88a4-30d610896eb1
  15. added
    ReviewingHas a PR in review
    and removed on May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions