Skip to content

[Due for payment 2025-11-13] [$250] Expense report with a negative total amount can't be manually marked as paid  #72159

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.28-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #65001
Email or phone of affected tester (no customers): sdijsnoisjnosij@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense with negative amount in workspace chat.
  4. Click Submit and Approve.
  5. Go to Reports > Pay.

Expected Result:

The expense report with a negative total amount shows the Pay button with the option to manually mark as paid, like Classic.

Actual Result:

The expense report with negative total amount doesn't show the Pay button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6969254_1759979945688.Screen_Recording_2025-10-09_at_11.14.06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021976684117993762534
  • Upwork Job ID: 1976684117993762534
  • Last Price Increase: 2025-10-10
  • Automatic offers:
    • FitseTLT | Reviewer | 109144445
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Oct 9, 2025
  2. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. 45 remaining items

  6. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    @FitseTLT @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  7. trjExpensify commented on Nov 13, 2025

    @trjExpensify
    Contributor

    👋 @FitseTLT checklist time, here!

  8. mukhrr commented on Nov 17, 2025

    @mukhrr
    Contributor

    @FitseTLT kindly bump here #72159 (comment)

  9. trjExpensify commented on Nov 17, 2025

    @trjExpensify
    Contributor

    Still awaiting the checklist, Melv.

  10. FitseTLT commented on Nov 19, 2025

    @FitseTLT
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: More of a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Have a workspace with workflow and payment enabled

    Test:

    1. Submit and approve an expense with a negative amount
    2. Verify you see the "Mark as paid" button on the Report preview
    3. Open the report details view
    4. Verify there is a "Mark as paid" button on the top right primary actions
    5. Go to Reports -> Pay
    6. Verify you see the Pay button on the report with negative amount

    Do we agree 👍 or 👎

  11. FitseTLT commented on Nov 19, 2025

    @FitseTLT
    Contributor

    Sorry for the delay

  12. trjExpensify commented on Nov 19, 2025

    @trjExpensify
    Contributor

    Thanks! Payment summary as follows:

  13. trjExpensify commented on Nov 19, 2025

    @trjExpensify
    Contributor

    nice, that was fast. Paid @mukhrr... closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions