You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-12] [$250] Invoice - Delete option is missing in More menu of an unpaid invoice report #72212
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Invoice - Delete option is missing in More menu when Workflows are disabled[/-][+]Invoice - Delete option is missing in More menu of an unpaid invoice report[/+]on Oct 16, 2025
changed the title [-][$250] Invoice - Delete option is missing in More menu of an unpaid invoice report[/-][+][Due for payment 2025-11-12] [$250] Invoice - Delete option is missing in More menu of an unpaid invoice report[/+]on Nov 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Unable to identify the specific offending PR with certainty — it seems this logic has been in place for quite some time, and we’ve recently updated the logic related to displaying the delete action.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Invoice feature is enabled
Test:
Go to staging.new.expensify.com
Go to workspace settings > More features.
Disable Workflows.
Open FAB > Send invoice.
Send an invoice to any user.
Go to Reports.
Search with type:invoice.
Select the invoice via checkbox > Click dropdown button.
Go to Inbox.
Open the invoice thread.
Click More.
Expected Result: Delete option will be present in More menu
Activity
melvin-bot commentedon Oct 9, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.etCoderDysto commentedon Oct 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - Delete option is missing in More menu when Workflows are disabled
What is the root cause of that problem?
We have policy?.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL check here. And when we disable workflow, policy?.approvalMode will be optional
App/src/libs/ReportUtils.ts
Lines 2683 to 2684 in f50b779
What changes do you think we should make in order to solve the problem?
We should remove the check
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can write a test that asserts that
canDeleteMoneyRequestReportwill return true for invoice report when workflow is disabledWhat alternative solutions did you explore? (Optional)
Eskalifer1 commentedon Oct 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - Delete option is missing in More menu when Workflows are disabled
What is the root cause of that problem?
We dont check here if workflows are enabled
App/src/libs/ReportUtils.ts
Lines 2683 to 2685 in f50b779
What changes do you think we should make in order to solve the problem?
We should check if workflows are enabled And if they are enabled, only then check
approvalMode. Here is an example of the code::What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
trjExpensify commentedon Oct 13, 2025
Mhm... @cristipaval @joekaufmanexpensify for a hipcheck...
processing) and waiting on someone to pay itcristipaval commentedon Oct 14, 2025
trjExpensify commentedon Oct 16, 2025
Cool, thanks!
[-]Invoice - Delete option is missing in More menu when Workflows are disabled[/-][+]Invoice - Delete option is missing in More menu of an unpaid invoice report[/+]44 remaining items
[-][$250] Invoice - Delete option is missing in More menu of an unpaid invoice report[/-][+][Due for payment 2025-11-12] [$250] Invoice - Delete option is missing in More menu of an unpaid invoice report[/+]melvin-bot commentedon Nov 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 5, 2025
@suneox @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Nov 11, 2025
BugZero Checklist
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Unable to identify the specific offending PR with certainty — it seems this logic has been in place for quite some time, and we’ve recently updated the logic related to displaying the delete action.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Expected Result: Delete option will be present in More menu
Do we agree 👍 or 👎
trjExpensify commentedon Nov 12, 2025
We're not really focused on
Invoicesright now, so I'm going to forgo the test.Payment summary as follows:
All settled up, closing.
garrettmknight commentedon Dec 7, 2025
$250 approved for @suneox