You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black #72470
Version Number: 9.2.29-5 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp Email or phone of affected tester (no customers):sdoisnosjdsojnsiod@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Create a workspace.
Go to workspace settings > More features.
Enable Tags.
Go to Tags.
Click Import.
Select Multi-level tags.
Expected Result:
Tag icon on upgrade screen will show the correct icon.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The multi-level tags upgrade screen is showing a flat black tag icon instead of the yellow illustration that matches the rest of the upgrade art. This makes the upgrade prompt feel broken and out of place.
What is the root cause of that problem?
The icon loader logic picks assets from the illustrationIcons map before checking illustrations. The Tag asset exists in both maps, but the version in illustrationIcons renders as a monochrome SVG, so the UI never reaches the colored illustration.
What changes do you think we should make in order to solve the problem?
Flip the selection order so that we prefer the illustration set when it is available, and only fall back to the icon set when an illustration does not exist. That guarantees that the multi-level tags feature uses the yellow tag art while keeping the avatar fallback for other icons.
changed the title [-]Tags - Tag icon on upgrade page is black[/-][+][Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black[/+]on Oct 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.31-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323@sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 13, 2025
Triggered auto assignment to @inimaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 13, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 13, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ShridharGoel commentedon Oct 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The multi-level tags upgrade screen is showing a flat black tag icon instead of the yellow illustration that matches the rest of the upgrade art. This makes the upgrade prompt feel broken and out of place.
What is the root cause of that problem?
The icon loader logic picks assets from the
illustrationIconsmap before checkingillustrations. TheTagasset exists in both maps, but the version inillustrationIconsrenders as a monochrome SVG, so the UI never reaches the colored illustration.App/src/pages/workspace/upgrade/UpgradeIntro.tsx
Lines 96 to 103 in 42d0574
What changes do you think we should make in order to solve the problem?
Flip the selection order so that we prefer the illustration set when it is available, and only fall back to the icon set when an illustration does not exist. That guarantees that the multi-level tags feature uses the yellow tag art while keeping the avatar fallback for other icons.
ShridharGoel commentedon Oct 13, 2025
@inimaga I'm available to quickly create a PR for this deploy blocker, thanks.
16 remaining items
[-]Tags - Tag icon on upgrade page is black[/-][+][Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black[/+]melvin-bot commentedon Oct 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.31-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 15, 2025
@Krishna2323 @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sonialiap commentedon Oct 22, 2025
Edit
Payment summary:- @Krishna2323 $250 please request in NewDot and also complete the checklistparasharrajat commentedon Oct 22, 2025
This is was regression @sonialiap
melvin-bot commentedon Oct 22, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
mountiny commentedon Oct 23, 2025
I guess we can close this one as the authors of the regression know