Skip to content

[Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black #72470

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.29-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp
Email or phone of affected tester (no customers): sdoisnosjdsojnsiod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Go to workspace settings > More features.
  4. Enable Tags.
  5. Go to Tags.
  6. Click Import.
  7. Select Multi-level tags.

Expected Result:

Tag icon on upgrade screen will show the correct icon.

Actual Result:

Tag icon on upgrade screen shows a black icon.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6973642_1760366081716.Screen_Recording_2025-10-13_at_22.32.10.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 13, 2025
  2. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 13, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. ShridharGoel commented on Oct 13, 2025

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The multi-level tags upgrade screen is showing a flat black tag icon instead of the yellow illustration that matches the rest of the upgrade art. This makes the upgrade prompt feel broken and out of place.

    What is the root cause of that problem?

    The icon loader logic picks assets from the illustrationIcons map before checking illustrations. The Tag asset exists in both maps, but the version in illustrationIcons renders as a monochrome SVG, so the UI never reaches the colored illustration.

    const isIllustration = feature.icon in illustrations;
    const isIllustrationIcon = feature.icon in illustrationIcons;
    let iconSrc;
    if (isIllustrationIcon) {
    iconSrc = illustrationIcons[feature.icon as keyof typeof illustrationIcons];
    } else if (isIllustration) {
    iconSrc = illustrations[feature.icon as keyof typeof illustrations];
    }

    What changes do you think we should make in order to solve the problem?

    Flip the selection order so that we prefer the illustration set when it is available, and only fall back to the icon set when an illustration does not exist. That guarantees that the multi-level tags feature uses the yellow tag art while keeping the avatar fallback for other icons.

    const isIllustration = feature.icon in illustrations;
    const isIllustrationIcon = feature.icon in illustrationIcons;
    let iconSrc;
    if (isIllustration) {
        iconSrc = illustrations[feature.icon as keyof typeof illustrations];
    } else if (isIllustrationIcon) {
        iconSrc = illustrationIcons[feature.icon as keyof typeof illustrationIcons];
    }
  7. ShridharGoel commented on Oct 13, 2025

    @ShridharGoel
    Contributor

    @inimaga I'm available to quickly create a PR for this deploy blocker, thanks.

  8. 16 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 15, 2025
  10. changed the title [-]Tags - Tag icon on upgrade page is black[/-] [+][Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black[/+] on Oct 15, 2025
  11. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.31-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-22. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Oct 15, 2025

    @melvin-bot

    @Krishna2323 @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. sonialiap commented on Oct 22, 2025

    @sonialiap
    Contributor

    Edit
    Payment summary:
    - @Krishna2323 $250 please request in NewDot and also complete the checklist

  15. parasharrajat commented on Oct 22, 2025

    @parasharrajat
    Member

    This is was regression @sonialiap

  16. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @martasudol is from an agency-contributor and not due payment
    • Reviewer: @Krishna2323 owed $250 via NewDot

    BugZero Checklist (@sonialiap)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. mountiny commented on Oct 23, 2025

    @mountiny
    Contributor

    I guess we can close this one as the authors of the regression know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions