Skip to content

Expense - "Waiting for you to pay" message appears for approver after approving report #72524

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72217
Email or phone of affected tester (no customers): agexptest+pr0810app@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15, iPhone 13 Mini/ iOS 18.5
App Component: Money Requests

Action Performed:

Preconditions:
Have a control workspace with the Rules feature enabled.
Enable the auto approval rule.
Invite an employee and an approver.
Set the approver for everyone's expenses in Workflows.
Submission frequency set to Instantly

  1. Go to staging.new.expensify.com
  2. As the employee, create an expense that exceeds the auto approval amount
  3. Submit the expense
  4. As the approver, open the expense report and approve

Expected Result:

[Approver] The next step message in the header should be "Waiting for Admin to pay expenses."
[Admin] The next step message in the header should be "Waiting for you to pay expenses."

Actual Result:

[Approver] The next step message in the header should be "Waiting for you to pay expenses."
[Admin] The next step message in the header should be "Waiting for Approver to pay expenses."

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 14, 2025
  2. melvin-bot commented on Oct 14, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mountiny commented on Oct 14, 2025

    @mountiny
    Contributor

    #72217 @nkdengineer @rojiphil @puneetlath This issue was found during testing your PR, can you please check it out and make sure if your PR enabled this behaviour and if its expected or not and we should follow up to fix it? thank you

  4. nkdengineer commented on Oct 14, 2025

    @nkdengineer
    Contributor

    @mountiny It's not related to my PR. My PR only changes the logic related to violation, not next step.

  5. mountiny commented on Oct 14, 2025

    @mountiny
    Contributor

    So is this just an exploration issue @jponikarchuk ?

  6. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    @puneetlath, @rojiphil, @NicMendonca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. jponikarchuk commented on Oct 17, 2025

    @jponikarchuk
    Author

    @mountiny This is exploratory issue around PR steps

  8. puneetlath commented on Oct 17, 2025

    @puneetlath
    Contributor

    I don't understand the bug report. The expected result and actual result are the same.

    Image
  9. jponikarchuk commented on Oct 17, 2025

    @jponikarchuk
    Author

    @puneetlath Not the same

    Image
  10. 5 remaining items

  11. rayane-d commented on Oct 28, 2025

    @rayane-d
    Contributor

    My PRs are on staging. @jponikarchuk, could you please check if this issue is still reproducible there?

  12. puneetlath commented on Oct 28, 2025

    @puneetlath
    Contributor

    Asked for a re-test in Slack.

  13. m-natarajan commented on Oct 28, 2025

    @m-natarajan

    Repro on Web v9.2.39-1 and Repro on iOS v9.2.39-0

    ScreenRecording_10-28-2025.11-27-24_1.MP4
    bandicam.2025-10-28.11-23-46-703.mp4
  14. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    @puneetlath @rojiphil @NicMendonca this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  15. puneetlath commented on Oct 30, 2025

    @puneetlath
    Contributor

    @rayane-d mind taking a look?

  16. rayane-d commented on Oct 31, 2025

    @rayane-d
    Contributor

    @puneetlath, This issue was not introduced by my PRs — the problem has existed for a long time. The incorrect logic was first introduced in this PR:

    I've created a PR to fix it:

    And this one also:

  17. self-assigned this
    on Oct 31, 2025
  18. added
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 31, 2025
  19. puneetlath commented on Oct 31, 2025

    @puneetlath
    Contributor

    Ah nice find. Thanks so much for raising the PRs to fix.

  20. rayane-d commented on Nov 4, 2025

    @rayane-d
    Contributor

    PR is deployed to production. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions