Skip to content

[HOLD 72613] Refactor optimistic custom report names to use Onyx derived values #72611

Closed
1 of 1 issue completed

Description

@neil-marcellini

Problem

As explained in this Slack thread, we ran into some problems when trying to implement the original plan from the design doc to compute customer report names optimistically based on the optimistic Onyx data that was about to be sent in a write request.

The problem was that we would go through each individual Onyx update and figure out if a report naming update was needed for it. But the context for computing those updates would come from Onyx and the current value saved there. So if there were multiple updates that affected each other, then stale values would be used when computing the report name and we would end up with the wrong final result. We encountered this problem while working on this issue

Solution

The solution that we landed on was to refactor the entire system to use onyx derived values so that the report name would be computed optimistically, although after the optimistic updates were applied, based on the formula and its dependencies. We'll use this issue to track the refactor from the current optimistic middleware solution to the solution using Onyx derived values.

We can consider the issue complete once some of the basic computation is working using derived values, and we are no longer using any type of middleware. We have other issues to track the overall implementation of the optimistic functionality.

Issue OwnerCurrent Issue Owner: @sosek108

Activity

  1. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    @sosek108 Eep! 4 days overdue now. Issues have feelings too...

  2. melvin-bot commented on Oct 22, 2025

    @melvin-bot

    @sosek108 Still overdue 6 days?! Let's take care of this!

  3. neil-marcellini commented on Oct 24, 2025

    @neil-marcellini
    ContributorAuthor

    We're starting this first step of the sub-issue (Refactor getReportName to prepare for formula computation) / general refactoring plan in the design doc.

  4. sosek108 commented on Oct 27, 2025

    @sosek108
    Contributor

    @neil-marcellini Can we make this issue on Hold due to #72613?

  5. melvin-bot commented on Oct 30, 2025

    @melvin-bot

    @sosek108 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. changed the title [-]Refactor optimistic custom report names to use Onyx derived values[/-] [+][HOLD 72613] Refactor optimistic custom report names to use Onyx derived values[/+] on Nov 3, 2025
  7. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    @sosek108 Still overdue 6 days?! Let's take care of this!

  8. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    @sosek108 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  9. melvin-bot commented on Nov 7, 2025

    @melvin-bot

    @sosek108 10 days overdue. Is anyone even seeing these? Hello?

  10. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    This issue has not been updated in over 14 days. @sosek108, @neil-marcellini eroding to Weekly issue.

  11. neil-marcellini commented on Dec 1, 2025

    @neil-marcellini
    ContributorAuthor

    We're scrapping this as explained here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions