You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD 72613] Refactor optimistic custom report names to use Onyx derived values #72611
As explained in this Slack thread, we ran into some problems when trying to implement the original plan from the design doc to compute customer report names optimistically based on the optimistic Onyx data that was about to be sent in a write request.
The problem was that we would go through each individual Onyx update and figure out if a report naming update was needed for it. But the context for computing those updates would come from Onyx and the current value saved there. So if there were multiple updates that affected each other, then stale values would be used when computing the report name and we would end up with the wrong final result. We encountered this problem while working on this issue
The solution that we landed on was to refactor the entire system to use onyx derived values so that the report name would be computed optimistically, although after the optimistic updates were applied, based on the formula and its dependencies. We'll use this issue to track the refactor from the current optimistic middleware solution to the solution using Onyx derived values.
We can consider the issue complete once some of the basic computation is working using derived values, and we are no longer using any type of middleware. We have other issues to track the overall implementation of the optimistic functionality.
changed the title [-]Refactor optimistic custom report names to use Onyx derived values[/-][+][HOLD 72613] Refactor optimistic custom report names to use Onyx derived values[/+]on Nov 3, 2025
Activity
melvin-bot commentedon Oct 20, 2025
@sosek108 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Oct 22, 2025
@sosek108 Still overdue 6 days?! Let's take care of this!
neil-marcellini commentedon Oct 24, 2025
We're starting this first step of the sub-issue (Refactor getReportName to prepare for formula computation) / general refactoring plan in the design doc.
sosek108 commentedon Oct 27, 2025
@neil-marcellini Can we make this issue on Hold due to #72613?
melvin-bot commentedon Oct 30, 2025
@sosek108 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Refactor optimistic custom report names to use Onyx derived values[/-][+][HOLD 72613] Refactor optimistic custom report names to use Onyx derived values[/+]melvin-bot commentedon Nov 3, 2025
@sosek108 Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Nov 5, 2025
@sosek108 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Nov 7, 2025
@sosek108 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Nov 12, 2025
This issue has not been updated in over 14 days. @sosek108, @neil-marcellini eroding to Weekly issue.
neil-marcellini commentedon Dec 1, 2025
We're scrapping this as explained here