You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-03] [$250] Infinite skeleton loading when navigating to Newdot from OD #72673
Version Number: v9.2.31-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory Email or phone of affected tester (no customers):htad26+eruoiuiy@gmail.com Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome App Component: Other
Action Performed:
Navigate to New dot and sign in with a new account
Navigate to troubleshoot > Switch to Expensify classic > Finish the flow
When you are redirected to Old dot, Click on "Try new Expensify"
After you are navigated to New dot, wait without changing reports or tabs
However, this setParams call doesn’t wait for the transition route to finish, so the reportID isn’t set.
(In reality, this is a race condition between the transition route finishing and the setParams call.)
What changes do you think we should make in order to solve the problem?
We should only call setParams after the transition route has completed.
For example:
changed the title [-]Infinite skeleton loading when navigating to Newdot from OD[/-][+][$250] Infinite skeleton loading when navigating to Newdot from OD[/+]on Oct 15, 2025
Activity
melvin-bot commentedon Oct 15, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Oct 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an infinite skeleton loading displayed
What is the root cause of that problem?
When opening the app via a transition deeplink, the
ReportScreenis initialized withreportID === ''.App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx
Lines 43 to 47 in 5c27729
When the transition ends, navigation occurs here, and
exitTousually has the value/, so no actual route gets added.App/src/pages/LogOutPreviousUserPage.tsx
Lines 71 to 74 in 5c27729
App/src/pages/LogInWithShortLivedAuthTokenPage.tsx
Lines 54 to 60 in 5c27729
When
ReportScreenmounts, it checks whetherreportID === ''. If so, it sets the reportID params usinglastAccessedReportID.App/src/pages/home/ReportScreen.tsx
Lines 200 to 209 in 5c27729
However, this
setParamscall doesn’t wait for the transition route to finish, so the reportID isn’t set.(In reality, this is a race condition between the transition route finishing and the
setParamscall.)What changes do you think we should make in order to solve the problem?
We should only call
setParamsafter the transition route has completed.For example:
App/src/pages/home/ReportScreen.tsx
Lines 189 to 210 in 5c27729
2025-10-15.18-37-34.mp4
melvin-bot commentedon Oct 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021978601781165939079
[-]Infinite skeleton loading when navigating to Newdot from OD[/-][+][$250] Infinite skeleton loading when navigating to Newdot from OD[/+]melvin-bot commentedon Oct 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)alexpensify commentedon Oct 15, 2025
@jjcoffee - When you get a chance, please review if this proposal will fix the issue? Thanks!
lorretheboy commentedon Oct 16, 2025
Hmmm... I cannot reproduce the issue in latest main
jjcoffee commentedon Oct 16, 2025
@dmkt9 Are you able to reproduce on main?
dmkt9 commentedon Oct 16, 2025
@jjcoffee Yes, I can still reproduce it on the latest main branch.
2025-10-16.15-59-28.mp4
32 remaining items
melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.alexpensify commentedon Nov 3, 2025
@strepanier03 - Reassigning the label so this one doesn't get lost.
We need a payment summary here. Thanks!
melvin-bot commentedon Nov 3, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
jjcoffee commentedon Nov 7, 2025
@strepanier03 Friendly bump for payment 🙏
strepanier03 commentedon Nov 10, 2025
Payment summary
strepanier03 commentedon Nov 10, 2025
Payment summary above for the Newdot payment, everything else is wrapped so closing out.
trjExpensify commentedon Nov 12, 2025
approved $250 for @jjcoffee.