Skip to content

Expense - No confirm modal when clicking Create report button from Report field #72817

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.33-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #71609
Email or phone of affected tester (no customers): ionjdssjiodjnois@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Create two empty reports.
  5. Open the report with expense.
  6. Click Report field.
  7. Click Create report.

Expected Result:

Confirm modal will appear because there are two empty reports.

Actual Result:

Confirm modal does not appear when clicking Create report button from Report field when there are two empty reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6977128_1760658537832.3.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 17, 2025
  2. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    Triggered auto assignment to @chuckdries (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. mountiny commented on Oct 17, 2025

    @mountiny
    Contributor
  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Oct 17, 2025
  8. hungvu193 commented on Oct 17, 2025

    @hungvu193
    Contributor

    Looks like it was reverted

  9. chuckdries commented on Oct 21, 2025

    @chuckdries
    Contributor

    Not overdue - relevant PR was reverted, new PR to re-add the functionality is in review

  10. brianlee-expensify commented on Oct 21, 2025

    @brianlee-expensify
    Contributor

    @chuckdries to confirm, no need for me to add any label (whether External or Internal), or assign to any project for this one?

  11. chuckdries commented on Oct 21, 2025

    @chuckdries
    Contributor

    I don't believe so. We can just close it when the linked PR goes through

  12. puneetlath commented on Oct 21, 2025

    @puneetlath
    Contributor

    The PR implementing the confirmation modal was reverted, so I think we can just close this issue out. It'll be re-implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions